From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: kbuild: fixing the select problem Date: Fri, 07 May 2010 12:31:19 +0100 Message-ID: References: <1273096160.23208.35.camel@mulgrave.site> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:45361 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604Ab0EGLbd (ORCPT ); Fri, 7 May 2010 07:31:33 -0400 In-Reply-To: <1273096160.23208.35.camel@mulgrave.site> (James Bottomley's message of "Wed, 05 May 2010 17:49:20 -0400") Sender: linux-arch-owner@vger.kernel.org List-ID: To: James Bottomley Cc: linux-arch@vger.kernel.org, linux-kernel , Sam Ravnborg , linux-kbuild@vger.kernel.org, Randy Dunlap James Bottomley wrote: > The select problem is that the kbuild select directive will turn a > symbol on without reference to its dependencies. This, in turn, means > that either selected symbols must select their dependencies, or that > people using select have to be aware of the selected symbol's dependency > and build those dependencies into their symbol (leading to duplication > and the possibility of getting the dependencies out of sync). We use > select for the scsi transport classes, so we run into this problem in > SCSI quite a lot. > > I think the correct fix is to make a symbol that selects another symbol > automatically inherit all of the selected symbol's dependencies. You may want to have a look at a patch I proposed some time ago, which at just warns of selecting options with unmet dependencies. I think it's a better approach that forcing the selection of the dependencies: http://lkml.org/lkml/2009/9/16/413 -- Catalin