From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Subject: Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips) Date: Fri, 19 Dec 2014 01:43:13 +0000 Message-ID: References: <1418849927.28384.1.camel@perches.com> <1418951658.28384.20.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1418951658.28384.20.camel@perches.com> (Joe Perches's message of "Thu, 18 Dec 2014 17:14:18 -0800") Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches Cc: Thomas Gleixner , linux-arch , LKML , Geert Uytterhoeven , linux-m68k , Steven Miao , Ralf Baechle , linux-mips List-Id: linux-arch.vger.kernel.org Joe Perches writes: > On Fri, 2014-12-19 at 00:33 +0100, Thomas Gleixner wrote: >> On Wed, 17 Dec 2014, Joe Perches wrote: >> > It seems like early_printk can be configured into >> > a few architectures but also appear not to be used. >> >=20 >> > $ git grep -w "early_printk" >> ... >> > These seem to the only uses: >> ...=20 >> > So blackfin, m68k, and mips seems to have it possible to enable, >> > but also don't appear at first glance to use it, >>=20 >> Hint: CONFIG_EARLY_PRINTK covers far more than early_printk() > > I know this. > > Note also I didn't specify CONFIG_EARLY_PRINTK, > just early_printk. > >> > Is early_printk really used by these architectures? >> > Should it be removed? >>=20 >> Sure, if you have a good reason to remove working functionality. > > Unused. What exactly are you proposing to remove? I see no unused code related to early printk (in any variant) under arch/mips. --=20 M=E5ns Rullg=E5rd mans@mansr.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from unicorn.mansr.com ([81.2.72.234]:59564 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbaLSBnX convert rfc822-to-8bit (ORCPT ); Thu, 18 Dec 2014 20:43:23 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Subject: Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips) References: <1418849927.28384.1.camel@perches.com> <1418951658.28384.20.camel@perches.com> Date: Fri, 19 Dec 2014 01:43:13 +0000 In-Reply-To: <1418951658.28384.20.camel@perches.com> (Joe Perches's message of "Thu, 18 Dec 2014 17:14:18 -0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-arch-owner@vger.kernel.org List-ID: To: Joe Perches Cc: Thomas Gleixner , linux-arch , LKML , Geert Uytterhoeven , linux-m68k , Steven Miao , Ralf Baechle , linux-mips Message-ID: <20141219014313.5EsSACpodk3JLIHrJOw1KKjUFpEnX-nOQ5mxSM5bFXE@z> Joe Perches writes: > On Fri, 2014-12-19 at 00:33 +0100, Thomas Gleixner wrote: >> On Wed, 17 Dec 2014, Joe Perches wrote: >> > It seems like early_printk can be configured into >> > a few architectures but also appear not to be used. >> > >> > $ git grep -w "early_printk" >> ... >> > These seem to the only uses: >> ... >> > So blackfin, m68k, and mips seems to have it possible to enable, >> > but also don't appear at first glance to use it, >> >> Hint: CONFIG_EARLY_PRINTK covers far more than early_printk() > > I know this. > > Note also I didn't specify CONFIG_EARLY_PRINTK, > just early_printk. > >> > Is early_printk really used by these architectures? >> > Should it be removed? >> >> Sure, if you have a good reason to remove working functionality. > > Unused. What exactly are you proposing to remove? I see no unused code related to early printk (in any variant) under arch/mips. -- Måns Rullgård mans@mansr.com