From: Giuseppe.Calderaro@arm.com (Giuseppe Calderaro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] ARM: Introduce *_relaxed() I/O accessors
Date: Wed, 14 Jul 2010 16:15:08 +0100 [thread overview]
Message-ID: <000001cb2367$590b2f60$0b218e20$@Calderaro@arm.com> (raw)
In-Reply-To: <20100714150117.16555.75662.stgit@e102109-lin.cambridge.arm.com>
+#define writeb_relaxed(v,c) ((void)__raw_writeb(v,__mem_pci(c)))
+#define writew_relaxed(v,c) ((void)__raw_writew((__force u16) \
+ cpu_to_le16(v),__mem_pci(c)))
+#define writel_relaxed(v,c) ((void)__raw_writel((__force u32) \
Adding the cast here means that someone could use the __raw_writeb/w/l
macros and still get the side effect.
What about adding the same cast to the __raw_* defines as well?
Giuseppe
next prev parent reply other threads:[~2010-07-14 15:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 15:01 [PATCH v3 0/3] Ordered I/O accessors Catalin Marinas
2010-07-14 15:01 ` [PATCH v3 1/3] ARM: Introduce *_relaxed() " Catalin Marinas
2010-07-14 15:15 ` Giuseppe Calderaro [this message]
2010-07-14 15:24 ` Catalin Marinas
2010-07-14 15:01 ` [PATCH v3 2/3] ARM: Convert L2x0 to use the IO relaxed operations Catalin Marinas
2010-07-14 15:01 ` [PATCH v3 3/3] ARM: Add barriers to the I/O accessors if ARM_DMA_MEM_BUFFERABLE Catalin Marinas
2010-07-27 11:03 ` [PATCH v3 0/3] Ordered I/O accessors Russell King - ARM Linux
2010-07-28 12:48 ` Rabin VINCENT
2010-07-28 13:06 ` Will Deacon
2010-07-29 10:43 ` Russell King - ARM Linux
2010-07-29 10:44 ` Russell King - ARM Linux
2010-07-28 21:09 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cb2367$590b2f60$0b218e20$@Calderaro@arm.com' \
--to=giuseppe.calderaro@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).