From: colin.tuckley@arm.com (Colin Tuckley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5 v4] ARM Realview PCIX map include file changes
Date: Thu, 13 Oct 2011 10:09:16 +0100 [thread overview]
Message-ID: <000001cc8987$c9079790$5b16c6b0$@tuckley@arm.com> (raw)
In-Reply-To: <20111012172007.GA21648@n2100.arm.linux.org.uk>
> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> Subject: Re: [PATCH 1/5 v4] ARM Realview PCIX map include file changes
> On Mon, Oct 10, 2011 at 10:27:08AM +0100, Colin Tuckley wrote:
> > Ah, I wasn't aware of that. However when I include asm/io.h and
> remove the
>
> The general rule is that linux/io.h includes asm/io.h, which in turn
> includes mach/io.h includes and nothing should include either asm/io.h
> nor mach/io.h directly - if it does, things probably break - which is
> desirable behaviour because that indicates that the include is wrong.
Right sounds very sensible :)
> > A quick check shows that the piece of code you quote above does not
> exist in
> > my (3.1.0-rc9) source tree.
>
> It's not in -rc9, but will be during the next merge window - and is in
> linux-next.
Ah, understood. Do you have any other concerns about this patch? If not then
I'll submit it to your patch system with the IO_SPACE_LIMIT stuff fixed.
Colin
next prev parent reply other threads:[~2011-10-13 9:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 14:27 [PATCH 0/5 v4] ARM Realview PCIX patch series Colin Tuckley
2011-10-07 14:27 ` [PATCH 1/5 v4] ARM Realview PCIX map include file changes Colin Tuckley
2011-10-07 19:22 ` Russell King - ARM Linux
2011-10-10 9:27 ` Colin Tuckley
2011-10-12 17:20 ` Russell King - ARM Linux
2011-10-13 9:09 ` Colin Tuckley [this message]
2011-10-07 14:28 ` [PATCH 2/5 v4] ARM Realview PCIX IRQ " Colin Tuckley
2011-10-07 14:28 ` [PATCH 3/5 v4] ARM Realview PCIX board " Colin Tuckley
2011-10-07 14:28 ` [PATCH 4/5 v4] Realview PCIX support - add main support module code Colin Tuckley
2011-10-07 23:19 ` Russell King - ARM Linux
2011-10-10 9:32 ` Colin Tuckley
2011-10-12 17:22 ` Russell King - ARM Linux
2011-10-07 14:29 ` [PATCH 5/5 v4] ARM Realview PCIX build file changes Colin Tuckley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cc8987$c9079790$5b16c6b0$@tuckley@arm.com' \
--to=colin.tuckley@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).