From: jingoohan1@gmail.com (Jingoo Han)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] PCI: exynos: refactor exynos pcie driver
Date: Fri, 10 Feb 2017 18:06:56 -0500 [thread overview]
Message-ID: <000001d283f2$62016ab0$26044010$@gmail.com> (raw)
In-Reply-To: <20170210225558.GV29169@bhelgaas-glaptop.roam.corp.google.com>
On Friday, February 10, 2017 5:56 PM, Bjorn Helgaas wrote:
>
> On Wed, Feb 01, 2017 at 10:13:06AM +0530, Pankaj Dubey wrote:
> > From: Niyas Ahmed S T <niyas.ahmed@samsung.com>
> >
> > Currently Exynos PCIe driver is only supported for Exynos5440 SoC.
> > This patch does refactoring of Exynos PCIe driver to extend support
> > for other Exynos SoC.
> >
> > Following are the main changes done via this patch:
> >
> > 1) It adds separate structs for memory, clock resources.
> >
> > Reason behind this change is, moving ahead various Exynos SoC will
> > have different hardware resources such as iomem, clocks, regmap handles
> > etc. for PCIe controller, so keeping these resources in separate struct
> > will help us in intiailizing them via per SoC ops, and will avoid too
> > many of_machine_is_compatible in code, and help us simplifying
> > exynos_pcie struct.
> >
> > 2) It add exynos_pcie_ops struct which will allow us to support the
> > differences in resources in different Exynos SoC.
> >
> > No functional change intended.
> >
> > Signed-off-by: Niyas Ahmed S T <niyas.ahmed@samsung.com>
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> Jingoo, any thoughts on this?
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
>
> > ---
> > This patch set is prepared on top of Krzysztof's for-next and
> > PCIe driver cleanup patch-v3 [1] by Jaehoon Chung.
> >
> > [1]: https://lkml.org/lkml/2017/1/16/19
> >
> > Changes from v2:
> > - Included Acked-by from Krzysztof
> > - Rebased on top of cleanup patch-v3 from Jaehoon Chung and latest
> > for-next of Krzysztof tree.
> >
> > Changes from v1:
> > - Addressed review comments from Krzysztof and Jingoo Han.
> >
> > drivers/pci/host/pci-exynos.c | 346 ++++++++++++++++++++++++++---------
> -------
> > 1 file changed, 217 insertions(+), 129 deletions(-)
> >
[snip]
next prev parent reply other threads:[~2017-02-10 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170201044024epcas5p372ee4f1632da87b351acfa0b57926a1c@epcas5p3.samsung.com>
2017-02-01 4:43 ` [PATCH v3] PCI: exynos: refactor exynos pcie driver Pankaj Dubey
2017-02-10 22:55 ` Bjorn Helgaas
2017-02-10 23:06 ` Jingoo Han [this message]
2017-02-10 23:12 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d283f2$62016ab0$26044010$@gmail.com' \
--to=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox