From: dustinb@codeaurora.org (Dustin Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: Export save_stack_trace_tsk()
Date: Wed, 12 Jul 2017 11:06:26 -0700 [thread overview]
Message-ID: <000001d2fb39$948f1b80$bdad5280$@codeaurora.org> (raw)
In-Reply-To: <20170613184056.23433-1-dustinb@codeaurora.org>
Hi Everyone,
I just wanted to touch base and see where we are with respect to this one. I
see that the arm64 version of this patch has already landed for 4.13. Is
there anything needed from me for this? I apologize in advance if I am just
being impatient.
Thanks,
-Dustin
-----Original Message-----
From: Dustin Brown [mailto:dustinb at codeaurora.org]
Sent: Tuesday, June 13, 2017 11:41 AM
To: linux at armlinux.org.uk; catalin.marinas at arm.com; will.deacon at arm.com;
linux-arm-kernel at lists.infradead.org
Cc: Dustin Brown <dustinb@codeaurora.org>
Subject: [PATCH 1/2] arm: Export save_stack_trace_tsk()
The kernel watchdog is a great debugging tool for finding tasks that
consume a disproportionate amount of CPU time in contiguous chunks. One
can imagine building a similar watchdog for arbitrary driver threads
using save_stack_trace_tsk() and print_stack_trace(). However, this is
not viable for dynamically loaded driver modules on ARM platforms
because save_stack_trace_tsk() is not exported for those architectures.
Export save_stack_trace_tsk() for the ARM architecture to align with x86
and support various debugging use cases such as arbitrary driver thread
watchdog timers.
Signed-off-by: Dustin Brown <dustinb@codeaurora.org>
---
arch/arm/kernel/stacktrace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/kernel/stacktrace.c b/arch/arm/kernel/stacktrace.c
index 3a2fa203637a..564bb468b7ba 100644
--- a/arch/arm/kernel/stacktrace.c
+++ b/arch/arm/kernel/stacktrace.c
@@ -171,6 +171,7 @@ void save_stack_trace_tsk(struct task_struct *tsk,
struct stack_trace *trace)
{
__save_stack_trace(tsk, trace, 1);
}
+EXPORT_SYMBOL_GPL(save_stack_trace_tsk);
void save_stack_trace(struct stack_trace *trace)
{
--
2.12.2
next prev parent reply other threads:[~2017-07-12 18:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 22:24 [PATCH] Export save_stack_trace_tsk for ARM and ARM64 Dustin Brown
2017-06-13 8:50 ` Will Deacon
2017-06-13 17:33 ` [PATCH 1/2] arm: Export save_stack_trace_tsk() Dustin Brown
2017-06-13 17:33 ` [PATCH 2/2] arm64: " Dustin Brown
2017-06-13 17:44 ` Will Deacon
2017-06-13 18:16 ` Russell King - ARM Linux
2017-06-13 18:40 ` [PATCH 1/2] arm: " Dustin Brown
2017-06-13 18:40 ` [PATCH 2/2] arm64: " Dustin Brown
2017-07-12 18:06 ` Dustin Brown [this message]
2017-06-14 10:06 ` Will Deacon
2017-06-14 16:51 ` Dustin Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d2fb39$948f1b80$bdad5280$@codeaurora.org' \
--to=dustinb@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).