RE: [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service interface

From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Stanley Chu'" <stanley.chu@mediatek.com>,
	"'Alim Akhtar'" <alim.akhtar@gmail.com>
Cc: f.fainelli@gmail.com, linux-scsi@vger.kernel.org,
	"'Martin K. Petersen'" <martin.petersen@oracle.com>,
	"'Leon Chen (陳文鏘)'" <Leon.Chen@mediatek.com>,
	"'Andy Teng (^[$B{}G!9(^[(B)'" <Andy.Teng@mediatek.com>,
	"'James E.J. Bottomley'" <jejb@linux.ibm.com>,
	"'Chun-Hung Wu (巫駿宏)'" <Chun-hung.Wu@mediatek.com>,
	"'Kuohong Wang (王國鴻)'" <kuohong.wang@mediatek.com>,
	"'open list'" <linux-kernel@vger.kernel.org>,
	"'Avri Altman'" <avri.altman@wdc.com>,
	linux-mediatek@lists.infradead.org,
	"'Peter Wang (王信友)'" <peter.wang@mediatek.com>,
	"'Matthias Brugger'" <matthias.bgg@gmail.com>,
	"'Pedro Sousa'" <pedrom.sousa@synopsys.com>,
	linux-arm-kernel@lists.infradead.org,
	"'Bean Huo (beanhuo)'" <beanhuo@micron.com>
Subject: RE: [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service interface
Date: Thu, 26 Dec 2019 14:10:09 +0530	[thread overview]
Message-ID: <000001d5bbc8$1714f380$453eda80$@samsung.com> (raw)
In-Reply-To: <1577259276.13056.54.camel@mtkswgap22>

Hi Stanley,
Its ok, I will take a look in your new patch set soon.
Thanks

Regards,
Alim

> -----Original Message-----
> From: Stanley Chu <stanley.chu@mediatek.com>
> Sent: 25 December 2019 13:05
> To: Alim Akhtar <alim.akhtar@gmail.com>
> Cc: f.fainelli@gmail.com; linux-scsi@vger.kernel.org; Martin K. Petersen
> <martin.petersen@oracle.com>; Leon Chen (陳文鏘)
> <Leon.Chen@mediatek.com>; Andy Teng (^[$B{}G!9(^[(B)
> <Andy.Teng@mediatek.com>; James E.J. Bottomley <jejb@linux.ibm.com>;
> Chun-Hung Wu (巫駿宏) <Chun-hung.Wu@mediatek.com>; Kuohong Wang (王
> 國鴻) <kuohong.wang@mediatek.com>; open list <linux-
> kernel@vger.kernel.org>; Avri Altman <avri.altman@wdc.com>; linux-
> mediatek@lists.infradead.org; Peter Wang (王信友)
> <peter.wang@mediatek.com>; Alim Akhtar <alim.akhtar@samsung.com>;
> Matthias Brugger <matthias.bgg@gmail.com>; Pedro Sousa
> <pedrom.sousa@synopsys.com>; linux-arm-kernel@lists.infradead.org; Bean
> Huo (beanhuo) <beanhuo@micron.com>
> Subject: Re: [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service
> interface
> 
> Hi Alim,
> 
> Would you think below explanation is OK to you?
> 
> BTW, FYI, this series was combined to the new series "scsi: ufs: add MediaTek
> vendor implementations" with this same patch in it.
> 
> Thanks,
> Stanley
> 
> 
> On Fri, 2019-12-20 at 09:15 +0800, Stanley Chu wrote:
> > Hi Alim,
> >
> > On Fri, 2019-12-20 at 02:00 +0800, Alim Akhtar wrote:
> > > > +/* UFS related SMC call */
> > > > +#define MTK_SIP_UFS_CONTROL \
> > > > +       MTK_SIP_SMC_CMD(0x276)
> > > > +
> > > How about moving UFS specific stuff to MTK UFS driver and include
> > > this header in driver file?
> > > Rest looks fine.
> >
> > Thanks so much for your review.
> >
> > Our intention is to collect all SMC call command types in MediaTek
> > Chipsets here for easier management.
> >
> > This is the first time we show this header thus only UFS related stuff
> > is present here.
> >
> > > > +#endif
> > > > --
> > > > 2.18.0
> > >
> > >
> >
> > Thanks,
> > Stanley
> >
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel