From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFEFFC388F7 for ; Wed, 11 Nov 2020 01:21:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46DF4221F9 for ; Wed, 11 Nov 2020 01:21:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aAWsb2o0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j4d8d1bw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46DF4221F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:In-Reply-To: References:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Kv1JIGJ8xXK6bGJQOMoMWTjl7OkzAvQTF9vvhDyX+G0=; b=aAWsb2o0YD8npkzaYSZ4hfBx+ EIszvE/PEgUYa540sUjtPg+i7LhkOWYDrzQVY4AT8Tvt6Nv5WIzNu8CimvUcQi0Zee4oBmDNvCOJJ +8vu3vJdd0iw0nUI/C1qukUNY8VP0IYRJcqyBd9Aie/CoKfMcDBW8QQTQI4q+VndBMzmtIHpg5qbE R70cdiT7ywzOIhaMgHAJa4uCoT6LhSpugMtOLZ7Yp0GfcgyWnwlQli75OSmqAiUMFCRR+roCGSvSn H1pzSL+DuG8Rpn3I9ipGuVG8/RNZr1X47GjLg0rddFjw7xqDPfO5ajqA1rH33fiLQD2RriFH2ArFz p+fLI6RHA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kceng-0000rl-U5; Wed, 11 Nov 2020 01:19:52 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcend-0000qt-P5 for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 01:19:50 +0000 Received: by mail-wr1-x442.google.com with SMTP id 23so736264wrc.8 for ; Tue, 10 Nov 2020 17:19:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=F+pUNae2Ork6DSx79r9ToYogqYk1+vYxanQo0ue5F60=; b=j4d8d1bwTh7SwUSSB6Qh8Yi2GfiQg9HLpfhrcMwGazALFW3pCTDB1xgirsWSqT2HZR G4WKQTtXXz+/2+xKKN8n4oDKV7PXc9Vj92aNucY5x+wdg/xBSSSWYYbtZTfGoP3z1gsr D2PYMCwBkxyqZl7FmwTjrZ6+2qq46Emb9T5A7RK2569Bc4hC/eMlttic401BiqQY81Gs l+2NoOyCz0ozAA/hq+MUBkNbcOb2onXOovWPVfEBA3t4bYy+AJW71NbYJcgZtRYMhL0S cg2fQ4cVhOQdvckLx0J84Swxy+HSlMCAlQbW31aa/tIONQ5+5gqHMtAwTKsFYWjjkd+2 dtYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:thread-index :content-language; bh=F+pUNae2Ork6DSx79r9ToYogqYk1+vYxanQo0ue5F60=; b=rgW4Afx/q2vcoi4qdWwsOM59YV4kZNOt+w8IKcqdBwLLhTiEV+yCF2tgLptnkjvPep cDMjA2uPL8hF3xF6gaCOnCbhObaPLYBZ4ryQn07HlAUu5Tbci6c6rWc9qUFR/4VhXHH4 eKI53LgDXf74Z5jMYHVnZlUbSSQWJRx+P2EtzU2L+nrf40E/0naNWbr1wfJenKaFvO9V OPakaylCf09E/kYJoXvfPgy23HT7Es9wJMdSuUQi1NAR/S0hp7iFi5GUZ7tK5FNk0cns pJjnIxwREN4rH9ImINKWjoILehFooD0A8ko/qldpqbCLgqpisnDYeV3lRiM/30Bv0IsD Y+Kw== X-Gm-Message-State: AOAM533tMGpXEBlivNy97qrWHjtcYsgX8NLTMB5RBpuc6F1bzqvi7adC L27uQKzigR006oksTqtlagzgBNk+rqI= X-Google-Smtp-Source: ABdhPJxFFnxCWeCAyBCZWm++vw5KrxfC8o4qIBCHc+cIerppIWoZCuYYggLE/xxCwDuY6Lkpa9j8bA== X-Received: by 2002:a05:6000:143:: with SMTP id r3mr15703912wrx.212.1605057587006; Tue, 10 Nov 2020 17:19:47 -0800 (PST) Received: from ansuelxps20 (93-39-149-95.ip76.fastwebnet.it. [93.39.149.95]) by smtp.gmail.com with ESMTPSA id r8sm486497wrq.14.2020.11.10.17.19.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2020 17:19:46 -0800 (PST) From: To: "'Al Viro'" References: <20201111004440.8783-1-ansuelsmth@gmail.com> <20201111005826.GY3576660@ZenIV.linux.org.uk> <20201111010910.GZ3576660@ZenIV.linux.org.uk> In-Reply-To: <20201111010910.GZ3576660@ZenIV.linux.org.uk> Subject: R: [PATCH] arm64: fix missing include in asm uaccess.h Date: Wed, 11 Nov 2020 02:19:48 +0100 Message-ID: <000001d6b7c8$bfed23e0$3fc76ba0$@gmail.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQMmE+bT5DKvLtqt64q97NbcO3B/eQK8xGH0AfXCMfKm/dRbgA== Content-Language: it X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201110_201949_877678_D060D84B X-CRM114-Status: GOOD ( 24.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 'Mark Rutland' , 'Pavel Tatashin' , 'Catalin Marinas' , linux-kernel@vger.kernel.org, 'Andrew Morton' , 'Will Deacon' , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Wed, Nov 11, 2020 at 12:58:26AM +0000, Al Viro wrote: > > On Wed, Nov 11, 2020 at 01:44:38AM +0100, Ansuel Smith wrote: > > > Fix a compilation error as PF_KTHREAD is defined in linux/sched.h and > > > this is missing. > > > > > > Fixes: df325e05a682 ("arm64: Validate tagged addresses in access_ok() > > > called from kernel threads") > > > Signed-off-by: Ansuel Smith > > > --- > > > arch/arm64/include/asm/uaccess.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/arm64/include/asm/uaccess.h > b/arch/arm64/include/asm/uaccess.h > > > index 991dd5f031e4..51a4f63f464a 100644 > > > --- a/arch/arm64/include/asm/uaccess.h > > > +++ b/arch/arm64/include/asm/uaccess.h > > > @@ -7,6 +7,8 @@ > > > #ifndef __ASM_UACCESS_H > > > #define __ASM_UACCESS_H > > > > > > +#include > > > + > > > #include > > > #include > > > #include > > > > NAK. The real bug is in arch/arm64/include/asm/asm-prototypes.h - > > it has no business pulling asm/uaccess.h > > > > Just include linux/uaccess.h instead. > > BTW, > $ grep -n uaccess.h `find -name asm-prototypes.h` > ./arch/alpha/include/asm/asm-prototypes.h:7:#include > ./arch/arm64/include/asm/asm-prototypes.h:18:#include > ./arch/ia64/include/asm/asm-prototypes.h:12:#include > ./arch/mips/include/asm/asm-prototypes.h:6:#include > ./arch/powerpc/include/asm/asm-prototypes.h:14:#include > ./arch/sparc/include/asm/asm-prototypes.h:9:#include > ./arch/x86/include/asm/asm-prototypes.h:3:#include > > Spot the irregularity... > > While we are at it, > $ git grep -n -w '#.*include.*asm/uaccess.h' > arch/arm64/include/asm/asm-prototypes.h:18:#include > arch/nds32/math-emu/fpuemu.c:5:#include > arch/powerpc/kvm/book3s_xive_native.c:15:#include > arch/powerpc/mm/book3s64/radix_pgtable.c:30:#include > drivers/s390/net/ctcm_mpc.c:50:#include /* instead of > ok ? */ > include/linux/uaccess.h:11:#include > > The last one is the only such include that should exist; drivers/s390 one > is obviously a false positive. And IMO the right thing to do is to > replace the remaining arch/* instances with includes of linux/uaccess.h. > > All of those are asking for trouble; any change moving e.g. a common > variant of some primitive into linux/uaccess.h might end up breaking > those. Thx for the quick response. I found this error while working on a qcom driver that use this include. I can confirm that by using linux/uaccess.h the problem is solved. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel