From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7564FC6FD1F for ; Wed, 3 Apr 2024 02:09:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vESy10Dppi38yth4STiVmKr3Uor7pMnsUdHrRzWX5CI=; b=2yiu3Y5Ah74mcP vxXvU/MbEGMmc3UHR+mdIr6n6Pe3S8AOdjJe0ts0rfTfqm47fUDaRy1ktpPsEwVj9mTVdV/bSJ+FP db0h0Gm5ISR41nJNhI7F/H8eBfX+1SxFCpTvUMDVniDF0H0nCux6Cn8nrAlvKT11A3Gxn5syqEe5W zxvSFVN4FuophcT6RSYuKZ5ndLgUQcza4Ms27+EzCjP9RnsT+T76JqncoGCgFLamBY71zrSdVMgrC iFrFpLg1IXsbZPWUUskxI9s+vTigXhKKAnlelIKF+2iaaC/nqrbAH5doq6VILW+juwo/1ApozrVc8 ZGmVjT/vH44XesEexiew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrq3S-0000000Dc4T-0Bxh; Wed, 03 Apr 2024 02:08:46 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrq3N-0000000Dc3e-1hPQ for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 02:08:44 +0000 Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20240403020833epoutp04cb49a4e0d848635871e834437c645a99~CoxOmXRdy0129901299epoutp04q for ; Wed, 3 Apr 2024 02:08:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20240403020833epoutp04cb49a4e0d848635871e834437c645a99~CoxOmXRdy0129901299epoutp04q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1712110113; bh=6aAlCwh36DxYyqqRLPW/CkqmSDRsRrrjCxjY+2Lohl0=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=aQIoUwMPrq/UEhIUJ8Na/IewxZh6lhwkYbsIOGrJgRcQ0ZPmgLQhCUlXRa1cnIM0t i/b9JnKlqRVeCD5Qfh4RIcYuX9C+ms71dCRtsn57vP4yj+guI9LqKdmxjI9qAzGBZi dDJ2BKg/M+Sq6FBChvZMo6E0rQpamKZ/HFx85Xug= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20240403020832epcas1p4ceaa211c97cb824c32041117feeb56c1~CoxOOhOa_1150311503epcas1p4X; Wed, 3 Apr 2024 02:08:32 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.38.243]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4V8SpS4WyLz4x9Q6; Wed, 3 Apr 2024 02:08:32 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id 15.A7.10076.02ABC066; Wed, 3 Apr 2024 11:08:32 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p2.samsung.com (KnoxPortal) with ESMTPA id 20240403020832epcas1p23578fb643a6af77b4467e8ab0a882567~CoxNx2HCE0576005760epcas1p2h; Wed, 3 Apr 2024 02:08:32 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240403020832epsmtrp219eaeab6bca99a8c7b2b42e9084203dc~CoxNxK92C1861118611epsmtrp2a; Wed, 3 Apr 2024 02:08:32 +0000 (GMT) X-AuditID: b6c32a39-7edf87000000275c-81-660cba20b7a8 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 9F.58.08390.02ABC066; Wed, 3 Apr 2024 11:08:32 +0900 (KST) Received: from sgsupark03 (unknown [10.252.69.53]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20240403020832epsmtip15132efaadb16880c685889b90e819fc8~CoxNlkJ2J3119931199epsmtip1G; Wed, 3 Apr 2024 02:08:32 +0000 (GMT) From: "Seongsu Park" To: "'Will Deacon'" Cc: , , , , , "'Leem ChaeHoon'" , "'Gyeonggeon Choi'" , "'Soomin Cho'" , "'DaeRo Lee'" , "'kmasta'" In-Reply-To: <20240402115841.GA16533@willie-the-truck> Subject: RE: [PATCH] arm64: Fix double TCR_T0SZ_OFFSET shift Date: Wed, 3 Apr 2024 11:08:31 +0900 Message-ID: <000001da856b$d37bed00$7a73c700$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQG4lO0QCCmP+gAvhK58w9Ata5ns/QFI4YWxAYI4YrGxg1FpAA== Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDJsWRmVeSWpSXmKPExsWy7bCmga7CLp40g1nvZS1+fnnPaPF+WQ+j xaa2+4wWfzbuZrL48ncps8Wmx9dYLS7vmsNmsfT6RSaLST+2MFq0f37BatFyx9SB22PNvDWM Hjtn3WX32LSqk81j85J6j0NnF7B6fN4kF8AWlW2TkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pm YKhraGlhrqSQl5ibaqvk4hOg65aZA3SdkkJZYk4pUCggsbhYSd/Opii/tCRVISO/uMRWKbUg JafArECvODG3uDQvXS8vtcTK0MDAyBSoMCE74+6Sa8wFHfwVH67sZGpgXMfTxcjBISFgIrGv NbKLkYtDSGAHo8SplpssEM4nRonWxkZ2COcbo8SOxX+Yuxg5wTq27+5jhUjsZZToXTIHquo5 o8SuW3sYQarYBHQkvn2bwgJiiwioSuz7uYERpIhZ4DGTxO8nB8BGcQqYSWydtpAV5BBhARuJ DQ+9QMIsAioSy572MYHYvAKWEo/vfYWyBSVOznwCNpNZQF5i+9s5UBcpSPx8uowVYpeTxMZH N5kgakQkZne2MYPslRDYwyFxftcCqAYXielH1kLZwhKvjm9hh7ClJD6/28sGYRdL7PuyBqqm RuLBvD1Qtr1Ex7M2FpCbmQU0Jdbv0ofYxSfx7msPKyRMeSU62oQgTGWJc1sdIUxJiT8L9CBm eEh07G9jmcCoOAvJX7OQ/DULyf2zEFYtYGRZxSiWWlCcm55abFhgCo/q5PzcTYzgZKtluYNx +tsPeocYmTgYDzFKcDArifD+9OZME+JNSaysSi3Kjy8qzUktPsRoCgzpicxSosn5wHSfVxJv aGJpYGJmZGJhbGlspiTOe+ZKWaqQQHpiSWp2ampBahFMHxMHp1QD054377IexC364f7p75u0 ZSeiup5fqTl93nI3b+I7qTC7gzNncvHX7W9PmGL2hudei8zHpavzf5j+ffBVssHgu3uVqcO/ WYcq7+38CUwMdYsv5Gcu62Z/f9UmdFmc3vfX69iCw+s0rGKXzbn5o+q9+ouoWO2lwuaLT22v vcy0zzWmXVO/8MyWPSJnvxo7GASbvLqlFV3F8DJk3fkN9btyp6p9dd347ZBE5tXEtksyE0PS zf2v8FS7a8rMPWgkEvtVLc5uD+9jddbmcr+AJ+tZ95x9MmtH3oaLb/mu32mYUN7ld0bDy2en z9TT2XrV2x7q3lta7da70Sbj0VI+bzvpvprc2s7T2rLVy41SxBLtlViKMxINtZiLihMBwbjn Oz8EAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsWy7bCSnK7CLp40g0u9XBY/v7xntHi/rIfR YlPbfUaLPxt3M1l8+buU2WLT42usFpd3zWGzWHr9IpPFpB9bGC3aP79gtWi5Y+rA7bFm3hpG j52z7rJ7bFrVyeaxeUm9x6GzC1g9Pm+SC2CL4rJJSc3JLEst0rdL4Mq4u+Qac0EHf8WHKzuZ GhjX8XQxcnJICJhIbN/dx9rFyMUhJLCbUeLY6qPMEAlJifZ3l1m6GDmAbGGJw4eLIWqeMkqs u3GbBaSGTUBH4tu3KWC2iICqxL6fGxhBipgF3jJJnJ65lQmiYzujxNpd3YwgVZwCZhJbpy1k BZkqLGAjseGhF0iYRUBFYtnTPiYQm1fAUuLxva9QtqDEyZlPwI5gFtCTaNsINoVZQF5i+9s5 UHcqSPx8uowV4gYniY2PbjJB1IhIzO5sY57AKDwLyaRZCJNmIZk0C0nHAkaWVYySqQXFuem5 xYYFRnmp5XrFibnFpXnpesn5uZsYwZGnpbWDcc+qD3qHGJk4GA8xSnAwK4nw/vTmTBPiTUms rEotyo8vKs1JLT7EKM3BoiTO++11b4qQQHpiSWp2ampBahFMlomDU6qBKfkgM7fX1a17d/4p +RDN1qxfcuW44Bum2WY2m9fIH/C6p8X03cp246SrmQLONTfl1LXiF9WfWmDedFbWaMK+ilrr Xwf3/dlYxmuv2MM2v6/YKHj53VOlKYKrlja0mHjnN8+U4/x/Y8PfOvUDz84WLEl+eYg1+lb3 +gk9Nb+zXoc+uWCb+Ooa2xzN6d/2f47oDD6xJfGQopWzkUz5gXbZEwr7lN659Xz/ZbdJ4vH7 f5vaO6Uk7pzqVEnXqrx4Xyg1a9eUYBubr9JLrZecXXN78qoH5Re/h9xmXLN/akr3OrmLP7oZ TCS+H3z2I0mju3d1h4BuxU0P/3UJxe5X1TwfNl+Qyj+p9ytqe9vcNY/0ypVYijMSDbWYi4oT AeELf1ErAwAA X-CMS-MailID: 20240403020832epcas1p23578fb643a6af77b4467e8ab0a882567 X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20240402104955epcas1p3dd15334a1305b99f3e1b82000e3c7c42 References: <20240402104950.170632-1-sgsu.park@samsung.com> <20240402115841.GA16533@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_190842_171102_6ECEA19B X-CRM114-Status: GOOD ( 24.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Tue, Apr 02, 2024 at 07:49:50PM +0900, Seongsu Park wrote: > > We have already shifted the value of t0sz in TCR_T0SZ by TCR_T0SZ_OFFSET. > > So, the TCR_T0SZ_OFFSET shift here should be removed. > > > > Co-developed-by: Leem ChaeHoon > > Signed-off-by: Leem ChaeHoon > > Co-developed-by: Gyeonggeon Choi > > Signed-off-by: Gyeonggeon Choi > > Co-developed-by: Soomin Cho > > Signed-off-by: Soomin Cho > > Co-developed-by: DaeRo Lee > > Signed-off-by: DaeRo Lee > > Co-developed-by: kmasta > > Signed-off-by: kmasta > > Signed-off-by: Seongsu Park > > heh, that's quite a lot of people. Did you remove three chars each? :p We are studying the Linux kernel based on arm64 together every Saturday for 7 hours! :) > > > --- > > arch/arm64/include/asm/mmu_context.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/include/asm/mmu_context.h > > b/arch/arm64/include/asm/mmu_context.h > > index c768d16b81a4..58de99836d2e 100644 > > --- a/arch/arm64/include/asm/mmu_context.h > > +++ b/arch/arm64/include/asm/mmu_context.h > > @@ -76,7 +76,7 @@ static inline void __cpu_set_tcr_t0sz(unsigned long > t0sz) > > return; > > > > tcr &= ~TCR_T0SZ_MASK; > > - tcr |= t0sz << TCR_T0SZ_OFFSET; > > + tcr |= t0sz; > > Thankfully, TCR_T0SZ_OFFSET is 0 so this isn't as alarming as it looks. > Even so, if we're going to make the code consistent, then shouldn't the > earlier conditional be updated too? > > if ((tcr & TCR_T0SZ_MASK) >> TCR_T0SZ_OFFSET == t0sz) > return; > > seems to assume that t0sz is unshifted. > > Will Thank you for feedback. I'll send v2 patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel