From: colin.tuckley@arm.com (Colin Tuckley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5 v4] Realview PCIX support - add main support module code
Date: Mon, 10 Oct 2011 10:32:20 +0100 [thread overview]
Message-ID: <000101cc872f$82425660$86c70320$@tuckley@arm.com> (raw)
In-Reply-To: <20111007231937.GC25689@n2100.arm.linux.org.uk>
> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> Subject: Re: [PATCH 4/5 v4] Realview PCIX support - add main support
> module code
Russell said:
> I thought one of my previous review points on this was that it was
> completely unsafe to match only on dev->device, rather than on both
> dev->device and dev->vendor. Device IDs are allocated by individual
> vendors and are meaningless without also checking the vendor ID.
And
> And I thought we'd got to the point where we had a swizzle here.
The patch I sent to the list was indeed an old version. However the reason
is that despite the testing we did and your suggested changes the swizzle
based code still does not fully work. So I thought it best to post working
code.
I'm still waiting for a response from you on the last round of test results
I sent.
Regards,
Colin
next prev parent reply other threads:[~2011-10-10 9:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 14:27 [PATCH 0/5 v4] ARM Realview PCIX patch series Colin Tuckley
2011-10-07 14:27 ` [PATCH 1/5 v4] ARM Realview PCIX map include file changes Colin Tuckley
2011-10-07 19:22 ` Russell King - ARM Linux
2011-10-10 9:27 ` Colin Tuckley
2011-10-12 17:20 ` Russell King - ARM Linux
2011-10-13 9:09 ` Colin Tuckley
2011-10-07 14:28 ` [PATCH 2/5 v4] ARM Realview PCIX IRQ " Colin Tuckley
2011-10-07 14:28 ` [PATCH 3/5 v4] ARM Realview PCIX board " Colin Tuckley
2011-10-07 14:28 ` [PATCH 4/5 v4] Realview PCIX support - add main support module code Colin Tuckley
2011-10-07 23:19 ` Russell King - ARM Linux
2011-10-10 9:32 ` Colin Tuckley [this message]
2011-10-12 17:22 ` Russell King - ARM Linux
2011-10-07 14:29 ` [PATCH 5/5 v4] ARM Realview PCIX build file changes Colin Tuckley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101cc872f$82425660$86c70320$@tuckley@arm.com' \
--to=colin.tuckley@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).