linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pankaj.dubey@samsung.com (Pankaj Dubey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] clk: samsung: remove unnecessary CONFIG_OF from clk.c
Date: Mon, 29 Sep 2014 13:00:10 +0530	[thread overview]
Message-ID: <000101cfdbb7$3f02a5f0$bd07f1d0$@samsung.com> (raw)
In-Reply-To: <5426B9BB.90606@gmail.com>

Hi Tomasz,

On Saturday, September 27, 2014 6:51 PM, Tomasz Figa wrote,
> Hi Pankaj,
> 
> On 27.09.2014 07:41, Pankaj Dubey wrote:
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> 
> Missing patch description.

OK, will add it.

> 
> > ---
> >  drivers/clk/samsung/clk.c |    2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c
> > index deab84d..31bf391 100644
> > --- a/drivers/clk/samsung/clk.c
> > +++ b/drivers/clk/samsung/clk.c
> > @@ -281,7 +281,6 @@ void __init samsung_clk_register_gate(struct
> samsung_clk_provider *ctx,
> >   * obtain the clock speed of all external fixed clock sources from
device
> >   * tree and register it
> >   */
> > -#ifdef CONFIG_OF
> 
> We still have non-DT platforms which use this code, i.e. s3c24xx and
s3c64xx. Have
> you checked if this compiles fine on them with CONFIG_OF disabled?
> 

Compile tested with s3c2410_defconfig and s3c6400_defconfig, and its
compiled fine.
In both cases CONFIG_OF was disabled.

Thanks,
Pankaj Dubey

> Best regards,
> Tomasz

  reply	other threads:[~2014-09-29  7:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-27  5:41 [PATCH 0/3] Some cleanup for samsung clock Pankaj Dubey
2014-09-27  5:41 ` [PATCH 1/3] clk: samsung: Spelling s/bwtween/between/ Pankaj Dubey
2014-09-27 12:56   ` Tomasz Figa
2014-09-27  5:41 ` [PATCH 2/3] clk: samsung: remove unnecessary CONFIG_OF from clk.c Pankaj Dubey
2014-09-27 13:20   ` Tomasz Figa
2014-09-29  7:30     ` Pankaj Dubey [this message]
2014-09-27  5:41 ` [PATCH 3/3] clk: samsung: remove unnecessary inclusion of header files from clk.h Pankaj Dubey
2014-12-02 15:23   ` Sylwester Nawrocki
2014-12-03 11:42     ` Pankaj Dubey
2014-12-03 12:04       ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000101cfdbb7$3f02a5f0$bd07f1d0$@samsung.com' \
    --to=pankaj.dubey@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).