From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F72C43331 for ; Sat, 28 Mar 2020 12:02:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D69AC206E6 for ; Sat, 28 Mar 2020 12:02:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PBA9UKWy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="eijlXx60" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D69AC206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject: In-Reply-To:References:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QsHwv7kVEe2D5SySEcPzt0mFgkCIm4LADY546d6c/ZI=; b=PBA9UKWy2ssOUI 9hA5o+VZ6OpobXBqFCbJ7LbhpjjzR0PnaY8xwx/4xvFQl0UleQgQ5JOp+I5et90vLJHW0S6EjNHML /UJ1uG4FXFBW1F+CHRpmJf15mD2qAJPrrCQwsBvNCyUIdfl8wnE9pEu+MIkeqQQU5jl3cmzBhZoS9 7/KslR4PuCGRpyMP8I15dAOo5NMx548mfLKw7LJeaf2NjuhYpmQNmRS+HhpB7W2FQlJYYRUhQKWYW ffSdqIPzSeeHpfMAi5hyXwLUS+k1YlvrTb0GM0IcSVzyqWgpPph48840cmmoIbH1kdmehx8vwiNT/ v80tH4tbfmSEybs1PeAA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jIAAk-0000mV-CE; Sat, 28 Mar 2020 12:02:42 +0000 Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jIAAg-0000m0-C4 for linux-arm-kernel@lists.infradead.org; Sat, 28 Mar 2020 12:02:41 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585396959; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: Subject: In-Reply-To: References: Cc: To: From: Sender; bh=zzBLtQ+//D0bBXPqSlcrMZohpTUdmpgajv0NPqBclSs=; b=eijlXx60EXH6EaRqQHfeYEtDuGQicPHuuH0tjjuncFzBqW2XtQpGb7V4LGQt0HM/T3Uu+boS jSGcY/H1jkKe6nmA4XeleLcI/3PT0V7021P49dxDsrsOmVPt6YaVT25ajp8SY+DwLXC3Svvq Q5pYWTSzENPqvN/aTPQoaNYdRT4= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e7f3cba.7f9b3a196c38-smtp-out-n03; Sat, 28 Mar 2020 12:02:02 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CD5C0C433BA; Sat, 28 Mar 2020 12:02:02 +0000 (UTC) Received: from Pillair (unknown [183.83.66.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: pillair) by smtp.codeaurora.org (Postfix) with ESMTPSA id 86CE5C433D2; Sat, 28 Mar 2020 12:01:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 86CE5C433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=pillair@codeaurora.org From: To: "'Bjorn Andersson'" References: <1585219723-28323-1-git-send-email-pillair@codeaurora.org> <20200327230025.GJ5063@builder> In-Reply-To: <20200327230025.GJ5063@builder> Subject: RE: [PATCH v7] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Date: Sat, 28 Mar 2020 17:31:52 +0530 Message-ID: <000101d604f8$afc48220$0f4d8660$@codeaurora.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFGsu5WNDBp+FP/TOeyoiVSrY11cwGGydAyqXBTCQA= Content-Language: en-us X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200328_050240_140678_D3D267DF X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bjorn, Comments inline. > -----Original Message----- > From: Bjorn Andersson > Sent: Saturday, March 28, 2020 4:30 AM > To: Rakesh Pillai > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org > Subject: Re: [PATCH v7] arm64: dts: qcom: sc7180: Add WCN3990 WLAN > module device node > > On Thu 26 Mar 03:48 PDT 2020, Rakesh Pillai wrote: > > > Add device node for the ath10k SNOC platform driver probe > > and add resources required for WCN3990 on sc7180 soc. > > > > Signed-off-by: Rakesh Pillai > > --- > > > > Depends on https://patchwork.kernel.org/patch/11455345/ > > The above patch adds the dt-bindings for wifi-firmware > > subnode > > --- > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 8 ++++++++ > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 > +++++++++++++++++++++++++++ > > 2 files changed, 35 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > index 043c9b9..a6168a4 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > @@ -327,6 +327,14 @@ > > }; > > }; > > > > +&wifi { > > + status = "okay"; > > + qcom,msa-fixed-perm; > > + wifi-firmware { > > + iommus = <&apps_smmu 0xc2 0x1>; > > How is sc7180 different from sdm845, where the iommus property goes > directly in the &wifi node? Sc7180 IDP is a target without TrustZone support and also with S2 IOMMU enabled. Since in Trustzone based targets, the iommu SID configuration was done by TZ, there was nothing required to be done by driver. But in non-TZ based targets, the IOMMU mappings need to be done by the driver. Since this is the mapping of the firmware memory and to keep it different from the driver memory access, a different device has been created for firmware and these SIDs are configured. The below ath10k series brings-in this support. https://patchwork.kernel.org/project/linux-wireless/list/?series=261367&stat e=* Thanks, Rakesh Pillai. > > Regards, > Bjorn > > > + }; > > +}; > > + > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > &qspi_clk { > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index 998f101..2745128 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -83,6 +83,11 @@ > > reg = <0 0x8f600000 0 0x500000>; > > no-map; > > }; > > + > > + wlan_fw_mem: memory@94104000 { > > + reg = <0 0x94104000 0 0x200000>; > > + no-map; > > + }; > > }; > > > > cpus { > > @@ -835,6 +840,28 @@ > > }; > > }; > > > > + wifi: wifi@18800000 { > > + compatible = "qcom,wcn3990-wifi"; > > + reg = <0 0x18800000 0 0x800000>; > > + reg-names = "membase"; > > + iommus = <&apps_smmu 0xc0 0x1>; > > + interrupts = > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */ >, > > + */>, > > + */>; > > + memory-region = <&wlan_fw_mem>; > > + status = "disabled"; > > + }; > > + > > config_noc: interconnect@1500000 { > > compatible = "qcom,sc7180-config-noc"; > > reg = <0 0x01500000 0 0x28000>; > > -- > > 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel