linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] arm: provide a mechanism to reserve performance counters
Date: Fri, 11 Dec 2009 15:31:21 -0000	[thread overview]
Message-ID: <000201ca7a76$fdc9f080$f95dd180$@deacon@arm.com> (raw)

* Jamie Iles <jamie.iles@picochip.com> wrote:

> To add support for perf events and to allow the hardware
> counters to be shared with oprofile, we need a way to reserve
> access to the pmu (performance monitor unit).
>
> Signed-off-by: Jamie Iles <jamie.iles <at> picochip.com>
> ---
> arch/arm/include/asm/pmu.h |   54 ++++++++++++++++++++++++++++++++++++++++++++
> arch/arm/kernel/Makefile   |    1 +
> arch/arm/kernel/pmu.c      |   32 ++++++++++++++++++++++++++
> arch/arm/mm/Kconfig        |    4 +++
> 4 files changed, 91 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/include/asm/pmu.h
> create mode 100644 arch/arm/kernel/pmu.c

Hi Jamie,

I like the idea of having a separate file for reserving the PMU across subsystems.
I also think it would be neat to extend it to request the relevant IRQs (or at
least return the PMU IRQs) once you've got it reserved.

This way, there will be no need to duplicate the inevitable collection of machine 
#ifdefs across tools [such as oprofile and perf]. It would also ensure that you can't 
reserve the PMU if somebody else has claimed the IRQs [and similarly, you can't
release it without giving them up].

What do you think?

Will

             reply	other threads:[~2009-12-11 15:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 15:31 Will Deacon [this message]
2009-12-11 15:41 ` [PATCH 1/4] arm: provide a mechanism to reserve performance counters Jamie Iles
2009-12-11 17:17   ` Will Deacon
2009-12-11 17:30     ` Jamie Iles
2009-12-11 17:34       ` Will Deacon
2009-12-11 18:07         ` Jamie Iles
2009-12-11 21:09     ` Russell King - ARM Linux
  -- strict thread matches above, loose matches on Subject: below --
2009-12-11  9:44 perf events for ARMv6 Jamie Iles
2009-12-11  9:44 ` [PATCH 1/4] arm: provide a mechanism to reserve performance counters Jamie Iles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000201ca7a76$fdc9f080$f95dd180$@deacon@arm.com' \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).