linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Improve MMC performance on Versatile Express
Date: Mon, 24 Jan 2011 17:54:18 -0000	[thread overview]
Message-ID: <000201cbbbef$bcec4610$36c4d230$@moll@arm.com> (raw)
In-Reply-To: <20110124170304.GH24104@n2100.arm.linux.org.uk>

> My final mail on this subject.

Ah, and I was really enjoying our pleasant discussion...

> Take a mainline kernel.  Apply the attached three patches.  MMC
> will then work without any problems.  No hacks required.  There is
> *absolutely* *no* need to waste time with hardware modifications.
> 
> With this you will find that MMCI FIFO underruns/overruns are no
> longer any problem.

$ git log -1
commit d315777b32a4696feb86f2a0c9e9f39c94683649
Merge: 5a05a6d 1765e3a
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon Jan 24 19:58:39 2011 +1000
[...]
$ git diff > changes.diff

Attached, I trust you will find all your changes there (and only them).

/ # uname -a
Linux (none) 2.6.38-rc2+ #11 SMP Mon Jan 24 17:11:35 GMT 2011 armv7l GNU/Linux
/ # cat /dev/sda > /dev/null &
/ # dd if=/dev/mmcblk0 of=/dev/null bs=64k count=128
dd: /dev/mmcblk0: Input/output error

And dmesg is full of:
[...]
mmcblk0: error -5 transferring data, sector 254, nr 2, cmd response 0x900, card status 0xb00
end_request: I/O error, dev mmcblk0, sector 254
mmcblk0: error -5 transferring data, sector 255, nr 1, cmd response 0x900, card status 0xb00
end_request: I/O error, dev mmcblk0, sector 255
mmcblk0: error -5 transferring data, sector 0, nr 8, cmd response 0x900, card status 0x900
mmcblk0: retrying using single block read
mmcblk0: error -5 transferring data, sector 0, nr 8, cmd response 0x900, card status 0xb00
[...]

Now:

$ git am 0001-arm-Improve-MMC-performance-on-Versatile-Express.patch

/ # uname -a
Linux (none) 2.6.38-rc2+ #12 SMP Mon Jan 24 17:41:53 GMT 2011 armv7l GNU/Linux
/ # cat /dev/sda > /dev/null &
/ # dd if=/dev/mmcblk0 of=/dev/null bs=64k count=128
128+0 records in
128+0 records out
8388608 bytes (8.0MB) copied, 1.501529 seconds, 5.3MB/s

> THERE IS NO ISSUE WITH MMCI.  THE HARDWARE DOES NOT NEED "FIXING".

I'm really pleased you think so. It's always nice to have happy customers :-)

Cheers!

Pawe?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: changes.diff
Type: application/octet-stream
Size: 7990 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110124/35e18346/attachment-0001.obj>

  reply	other threads:[~2011-01-24 17:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 13:59 [PATCH] arm: Improve MMC performance on Versatile Express Pawel Moll
2011-01-21 15:09 ` Sergei Shtylyov
2011-01-21 19:59 ` Nicolas Pitre
2011-01-21 21:51   ` Russell King - ARM Linux
2011-01-21 22:20     ` Nicolas Pitre
2011-01-21 22:29       ` Russell King - ARM Linux
2011-02-01 14:29         ` Linus Walleij
2011-02-01 17:25           ` Pawel Moll
2011-01-24 12:27   ` Pawel Moll
2011-01-24 13:35     ` Russell King - ARM Linux
2011-01-24 16:13       ` Pawel Moll
2011-01-24 16:24         ` Russell King - ARM Linux
2011-01-24 16:30           ` Russell King - ARM Linux
2011-01-24 16:39           ` Pawel Moll
2011-01-24 16:53             ` Russell King - ARM Linux
2011-01-24 17:03               ` Russell King - ARM Linux
2011-01-24 17:54                 ` Pawel Moll [this message]
2011-01-24 18:09                   ` Russell King - ARM Linux
2011-01-24 19:59                     ` Pawel Moll
2011-01-24 23:10                       ` Russell King - ARM Linux
2011-02-01 11:18                         ` Russell King - ARM Linux
2011-02-01 13:34                           ` Pawel Moll
2011-02-01 14:28                             ` Russell King - ARM Linux
2011-02-01 17:25                               ` Pawel Moll
2011-02-03 14:15       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000201cbbbef$bcec4610$36c4d230$@moll@arm.com' \
    --to=pawel.moll@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).