From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] mm: cma: add a simple kernel module as the helper to test CMA
Date: Wed, 04 Jul 2012 08:52:01 +0200 [thread overview]
Message-ID: <000301cd59b1$87094eb0$951bec10$%szyprowski@samsung.com> (raw)
In-Reply-To: <op.wgvfgmm03l0zgt@mpn-glaptop>
Hello,
On Tuesday, July 03, 2012 2:54 PM Michal Nazarewicz wrote:
> > 2012/7/3 Marek Szyprowski <m.szyprowski@samsung.com>:
> >> IMHO the right place for such code is in drivers/misc instead of tools/cma.
> >>
> >> This patch contains a kernel module source code so it should be put with other kernel
> >> modules. tools/ directory is aimed to contain user space code useful for developing and
> >> testing Linux kernel.
>
> On Tue, 03 Jul 2012 09:39:34 +0200, Barry Song <21cnbao@gmail.com> wrote:
> > this one is aiming to test CMA, it should be in tools/ as Michal
> > Nazarewicz and i have talked about that.
> > it is not a real driver at all.
>
> Yeah, I feel like it's better placed in tools/ not to pollute other directories with
> drivers that are of no use to regular users. I don't have strong feelings about it
> though, so I'm fine either way.
Other test devices/drivers are in drivers directory (drivers/usb/misc/usbtest.c for
example), I don't see any good reason for polluting tools/ directory with kernel code.
IMHO the right person to decide if it makes sense to have such drivers in drivers/mics/
or tools/cma/ is Greg KH. Barry, please resend it and ask Greg for the decision.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2012-07-04 6:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 11:37 [PATCH v4] mm: cma: add a simple kernel module as the helper to test CMA Barry Song
2012-03-07 12:11 ` Michal Nazarewicz
2012-07-03 7:20 ` Marek Szyprowski
2012-07-03 7:39 ` Barry Song
2012-07-03 12:54 ` Michal Nazarewicz
2012-07-04 6:52 ` Marek Szyprowski [this message]
2012-07-04 6:56 ` Barry Song
2012-07-04 7:00 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301cd59b1$87094eb0$951bec10$%szyprowski@samsung.com' \
--to=m.szyprowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox