From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] ARM: msm: update GPIO chained IRQ handler to use EOI in parent chip
Date: Thu, 24 Feb 2011 14:12:46 -0000 [thread overview]
Message-ID: <000401cbd42c$e9a957b0$bcfc0710$@deacon@arm.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1102241338410.2701@localhost6.localdomain6>
> On Wed, 23 Feb 2011, Abhijeet Dharmapurikar wrote:
>
> > Will Deacon wrote:
> > > The chained GPIO IRQ handler on MSM8x60 calls ->ack on the parent chip
> > > after handling the interrupt.
> > >
> > > This patch updates the code to use ->irq_eoi now that the GIC has moved
> > > to using the fasteoi flow model.
> > >
> > > Cc: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
> > > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > > ---
> > > arch/arm/mach-msm/gpio-v2.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-msm/gpio-v2.c b/arch/arm/mach-msm/gpio-v2.c
> > > index 0de19ec..04fb411 100644
> > > --- a/arch/arm/mach-msm/gpio-v2.c
> > > +++ b/arch/arm/mach-msm/gpio-v2.c
> > > @@ -318,7 +318,7 @@ static void msm_summary_irq_handler(unsigned int irq,
> > > struct irq_desc *desc)
> > > generic_handle_irq(msm_gpio_to_irq(&msm_gpio.gpio_chip,
> > > i));
> > > }
> > > - desc->chip->ack(irq);
> > > + desc->chip->irq_eoi(irq);
> >
> > should be dec->chip->irq_eoi(&desc->irq_data);
>
> Nope, it should do:
>
> struct irq_chip *chip = get_irq_desc_chip(desc);
>
> chip->irq_eoi();
Something like this?
diff --git a/arch/arm/mach-msm/gpio-v2.c b/arch/arm/mach-msm/gpio-v2.c
index 0de19ec..90a968f 100644
--- a/arch/arm/mach-msm/gpio-v2.c
+++ b/arch/arm/mach-msm/gpio-v2.c
@@ -310,6 +310,7 @@ static int msm_gpio_irq_set_type(unsigned int irq, unsigned int flow_type)
static void msm_summary_irq_handler(unsigned int irq, struct irq_desc *desc)
{
unsigned long i;
+ struct irq_chip *chip = get_irq_desc_chip(desc);
for (i = find_first_bit(msm_gpio.enabled_irqs, NR_GPIO_IRQS);
i < NR_GPIO_IRQS;
@@ -318,7 +319,7 @@ static void msm_summary_irq_handler(unsigned int irq, struct irq_desc *desc)
generic_handle_irq(msm_gpio_to_irq(&msm_gpio.gpio_chip,
i));
}
- desc->chip->ack(irq);
+ chip->irq_eoi(&desc->irq_data);
}
Will
next prev parent reply other threads:[~2011-02-24 14:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 15:28 [PATCH 0/5] Migrate GIC to fasteoi flow control Will Deacon
2011-02-21 15:28 ` [PATCH 1/5] ARM: gic: use handle_fasteoi_irq for SPIs Will Deacon
2011-02-21 15:28 ` [PATCH 2/5] ARM: omap: update GPIO chained IRQ handler to use EOI in parent chip Will Deacon
2011-02-21 19:15 ` Santosh Shilimkar
2011-02-22 14:14 ` Santosh Shilimkar
2011-02-22 18:30 ` Will Deacon
2011-02-22 18:18 ` Tony Lindgren
2011-02-22 18:32 ` Will Deacon
2011-02-21 15:28 ` [PATCH 3/5] ARM: tegra: " Will Deacon
2011-02-22 19:09 ` Colin Cross
2011-02-22 19:21 ` Will Deacon
2011-02-22 19:52 ` Russell King - ARM Linux
2011-02-23 10:39 ` Will Deacon
2011-02-21 15:28 ` [PATCH 4/5] ARM: s5pv310: update IRQ combiner " Will Deacon
2011-02-23 6:59 ` Kyungmin Park
2011-02-23 15:58 ` Will Deacon
2011-02-21 15:28 ` [PATCH 5/5] ARM: msm: update GPIO chained IRQ handler " Will Deacon
2011-02-24 0:22 ` Abhijeet Dharmapurikar
2011-02-24 12:40 ` Thomas Gleixner
2011-02-24 14:12 ` Will Deacon [this message]
2011-02-24 15:42 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401cbd42c$e9a957b0$bcfc0710$@deacon@arm.com' \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).