From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: perf: reword comments relating to perf_event_do_pending
Date: Mon, 16 Aug 2010 12:00:34 +0100 [thread overview]
Message-ID: <000501cb3d32$40447b00$c0cd7100$@deacon@arm.com> (raw)
In-Reply-To: <20100816103526.GB2954@pulham.picochip.com>
Hi Jamie,
> On Mon, Aug 16, 2010 at 11:25:31AM +0100, Will Deacon wrote:
> > This is purely a cosmetic change to the ARM perf backend because the current
> > comments about the relationship between NMIs, interrupt context and
> > perf_event_do_pending are misleading.
> >
> > This patch updates the comments so that they reflect what the code
> > actually does (which is in line with other architectures).
> >
> > Cc: Jamie Iles <jamie.iles@picochip.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> Yep, that makes much more sense!
>
> Acked-by: Jamie Iles <jamie.iles@picochip.com>
Thanks for that. We could go a step further and remove the call to
perf_event_do_pending entirely because we don't have NMI and therefore
never queue up any pending events. I guess the caveat here is that
we might hit subtle bugs in the future if pending events are used for
things other than NMI (or if somebody crazy decides to use FIQ as a PMU
interrupt).
I'll leave it in for the moment and submit this patch to the system.
Cheers,
Will
prev parent reply other threads:[~2010-08-16 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 10:25 [PATCH] ARM: perf: reword comments relating to perf_event_do_pending Will Deacon
2010-08-16 10:35 ` Jamie Iles
2010-08-16 11:00 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000501cb3d32$40447b00$c0cd7100$@deacon@arm.com' \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).