From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH] ARM: ptrace: remove single-step emulation code
Date: Wed, 19 Jan 2011 15:37:38 -0000 [thread overview]
Message-ID: <000501cbb7ee$cdccc680$69665380$@deacon@arm.com> (raw)
In-Reply-To: <20110119151915.GG31652@n2100.arm.linux.org.uk>
Hi Russell,
> On Wed, Jan 19, 2011 at 03:07:15PM +0000, Will Deacon wrote:
> > I'm posting this as an RFC to see if anybody has a good reason to keep this
> > code around. There's also a chance I've missed an opportunity to remove some
> > related code, but I think I found everything. Tested on a Versatile Express,
> > single-stepping in GDB worked fine.
>
> Have you checked whether strace and ltrace use single stepping?
strace works fine with this patch applied and, looking at the
sources, it doesn't use the SINGLESTEP request. As for ltrace,
it *does* use SINGLESTEP but it can use PTRACE_SYSCALL instead
(indeed, it does this for sparc, ia64 and mips). ltrace doesn't
have code for checking the ptrace return value so I'd say it's
their bug.
Will
next prev parent reply other threads:[~2011-01-19 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 15:07 [RFC][PATCH] ARM: ptrace: remove single-step emulation code Will Deacon
2011-01-19 15:19 ` Russell King - ARM Linux
2011-01-19 15:37 ` Will Deacon [this message]
2011-01-19 22:06 ` Arnaud Patard (Rtp)
2011-01-20 9:23 ` Will Deacon
2011-01-24 9:50 ` Timo Juhani Lindfors
2011-01-24 16:18 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000501cbb7ee$cdccc680$69665380$@deacon@arm.com' \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).