From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: Configure reference clock for Versatile Express timers
Date: Mon, 24 Jan 2011 19:13:27 -0000 [thread overview]
Message-ID: <000601cbbbfa$c83d4db0$58b7e910$@moll@arm.com> (raw)
In-Reply-To: <20110124171007.GI24104@n2100.arm.linux.org.uk>
> Right, I'm chucking your original patch out of my tree.
Ok, I'd like to separate these two things.
First is the reference clock configuration, and this change is really important. I'll send v3 in a second, which does not touch the TIMER_CTRL lines. I hope you are happy about this.
The second thing is the SP804 reset... You said:
> Some platforms have four timers. Should we leave two uninitialized?
VE _has_ four timers - two dual-timer modules - and you don't initialize V2M_TIMER[23]. True, the (potential) problem lies at "twin timers", sharing common interrupt, but if you want to reset all available timers on all platforms, we should perform the rites on them as well.
I also had a look at the TRM and the reset value for the control register is 0, but I'm guessing you are worried about boot monitor leftovers.
Cheers!
Pawe?
next prev parent reply other threads:[~2011-01-24 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 18:04 [PATCH v2] arm: Configure reference clock for Versatile Express timers Pawel Moll
2011-01-24 14:47 ` Russell King - ARM Linux
2011-01-24 16:12 ` Pawel Moll
2011-01-24 16:14 ` Russell King - ARM Linux
2011-01-24 16:38 ` Pawel Moll
2011-01-24 16:42 ` Russell King - ARM Linux
2011-01-24 17:10 ` Russell King - ARM Linux
2011-01-24 19:13 ` Pawel Moll [this message]
2011-01-24 20:20 ` Russell King - ARM Linux
2011-01-25 14:18 ` Pawel Moll
2011-01-25 14:38 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000601cbbbfa$c83d4db0$58b7e910$@moll@arm.com' \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).