From: "Aakarsh Jain" <aakarsh.jain@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: <m.szyprowski@samsung.com>, <andrzej.hajda@intel.com>,
<mchehab@kernel.org>, <hverkuil-cisco@xs4all.nl>,
<ezequiel@vanguardiasur.com.ar>, <jernej.skrabec@gmail.com>,
<benjamin.gaignard@collabora.com>,
<krzysztof.kozlowski+dt@linaro.org>,
<stanimir.varbanov@linaro.org>, <dillon.minfei@gmail.com>,
<david.plowman@raspberrypi.com>, <mark.rutland@arm.com>,
<robh+dt@kernel.org>, <krzk+dt@kernel.org>, <andi@etezian.org>,
<alim.akhtar@samsung.com>, <aswani.reddy@samsung.com>,
<pankaj.dubey@samsung.com>
Subject: RE: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-schema
Date: Thu, 9 Mar 2023 12:52:27 +0530 [thread overview]
Message-ID: <000701d95257$e97ebd50$bc7c37f0$@samsung.com> (raw)
In-Reply-To: <9b93849d-d4a4-67ba-e8a0-ee6c7209bd65@linaro.org>
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 09 March 2023 12:15
> To: Aakarsh Jain <aakarsh.jain@samsung.com>; linux-arm-
> kernel@lists.infradead.org; linux-media@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com;
> mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
> ezequiel@vanguardiasur.com.ar; jernej.skrabec@gmail.com;
> benjamin.gaignard@collabora.com; krzysztof.kozlowski+dt@linaro.org;
> stanimir.varbanov@linaro.org; dillon.minfei@gmail.com;
> david.plowman@raspberrypi.com; mark.rutland@arm.com;
> robh+dt@kernel.org; krzk+dt@kernel.org; andi@etezian.org;
> alim.akhtar@samsung.com; aswani.reddy@samsung.com;
> pankaj.dubey@samsung.com
> Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-
> schema
>
> On 02/03/2023 16:18, Aakarsh Jain wrote:
> >>
> >> iommus:
> >> maxItems: 1
> >> iommu-names: false
> >>
> > I am getting compilation errors with above property set and its breaking the
> bindings.
> > If we see these two nodes in dtsi files.
> > mfc: codec@13400000 {
> > compatible = "samsung,mfc-v5"; ..
> > iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;
> > iommu-names = "left", "right"; } And
> > mfc: codec@13400000 {
> > compatible = "samsung,exynos3250-mfc", "samsung,mfc-v7";
> > reg = <0x13400000 0x10000>; ...
> > iommus = <&sysmmu_mfc>;
> > };
> > There is no iommu-names property for compatible "samsung,exynos3250-
> mfc, samsung,mfc-v7", that’s why I kept
> > iommus:
> > minItems: 1
> > maxItems: 2
> > I would even go with below if you agree?
> > iommus:
> > minItems: 1
> > maxItems: 2
> > iommus-names: false
>
> No, I don't agree. Why do you need two IOMMUs for Exynos3250?
> >
Here IOMMUs minItems:1 is meant for Exynos3250 while IOMMUs maxItems:2 meant for samsung,mfc-v5(Exynos 4).
As you suggested
iommus:
maxItems: 1
iommu-names: false
won't fit here.
Since IOMMUs maxItems is 2 here for Exynos4. Giving maxItems:2 alone will also break the bindings. Thanks why suggested
iommus:
minItems: 1
maxItems: 2
>
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-09 7:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230301035153epcas5p40f576188a9a69835c1050135219a3720@epcas5p4.samsung.com>
2023-03-01 3:51 ` [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-schema Aakarsh Jain
2023-03-02 8:37 ` Krzysztof Kozlowski
2023-03-02 15:18 ` Aakarsh Jain
2023-03-09 6:45 ` Krzysztof Kozlowski
2023-03-09 7:22 ` Aakarsh Jain [this message]
2023-03-09 8:10 ` Krzysztof Kozlowski
2023-03-09 8:48 ` Aakarsh Jain
2023-03-10 9:08 ` Krzysztof Kozlowski
2023-03-13 3:56 ` Aakarsh Jain
2023-03-13 6:44 ` Krzysztof Kozlowski
2023-03-09 5:38 ` Aakarsh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000701d95257$e97ebd50$bc7c37f0$@samsung.com' \
--to=aakarsh.jain@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=andrzej.hajda@intel.com \
--cc=aswani.reddy@samsung.com \
--cc=benjamin.gaignard@collabora.com \
--cc=david.plowman@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).