From: k.debski@samsung.com (Kamil Debski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: exynos: fix building as a module
Date: Thu, 13 Mar 2014 14:35:26 +0100 [thread overview]
Message-ID: <000801cf3ec1$18117040$483450c0$%debski@samsung.com> (raw)
In-Reply-To: <10501799.dhM9cVfZmk@wuerfel>
Hi Arnd,
> From: Arnd Bergmann [mailto:arnd at arndb.de]
> Sent: Wednesday, March 12, 2014 4:48 PM
>
> The top-level phy-samsung-usb2 driver may be configured as a loadable
> module, which currently causes link errors because of the dependency on
> the exynos{5250,4x12,4210}_usb2_phy_config
> symbol. Solving this could be achieved by exporting these symbols, but
> as the SoC-specific parts of the driver are not currently built as
> modules, it seems better to just link everything into one module and
> avoid the need for the export.
Thank you for this patch and spotting this error.
Acked-by: Kamil Debski <k.debski@samsung.com>
Best wishes,
--
Kamil Debski
Samsung R&D Institute Poland
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index
> 2faf78e..7728518 100644
> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile
> @@ -13,8 +13,9 @@ obj-$(CONFIG_TI_PIPE3) +=
phy-ti-pipe3.o
> obj-$(CONFIG_TWL4030_USB) += phy-twl4030-usb.o
> obj-$(CONFIG_PHY_EXYNOS5250_SATA) += phy-exynos5250-sata.o
> obj-$(CONFIG_PHY_SUN4I_USB) += phy-sun4i-usb.o
> -obj-$(CONFIG_PHY_SAMSUNG_USB2) += phy-samsung-usb2.o
> -obj-$(CONFIG_PHY_EXYNOS4210_USB2) += phy-exynos4210-usb2.o
> -obj-$(CONFIG_PHY_EXYNOS4X12_USB2) += phy-exynos4x12-usb2.o
> -obj-$(CONFIG_PHY_EXYNOS5250_USB2) += phy-exynos5250-usb2.o
> +obj-$(CONFIG_PHY_SAMSUNG_USB2) += phy-exynos-usb2.o
> +phy-exynos-usb2-y += phy-samsung-usb2.o
> +phy-exynos-usb2-$(CONFIG_PHY_EXYNOS4210_USB2) +=
phy-exynos4210-usb2.o
> +phy-exynos-usb2-$(CONFIG_PHY_EXYNOS4X12_USB2) +=
phy-exynos4x12-usb2.o
> +phy-exynos-usb2-$(CONFIG_PHY_EXYNOS5250_USB2) +=
phy-exynos5250-usb2.o
> obj-$(CONFIG_PHY_XGENE) += phy-xgene.o
prev parent reply other threads:[~2014-03-13 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 15:48 [PATCH] phy: exynos: fix building as a module Arnd Bergmann
2014-03-13 13:35 ` Kamil Debski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000801cf3ec1$18117040$483450c0$%debski@samsung.com' \
--to=k.debski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox