From: tony.kn@samsung.com (Tony K Nadackal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: samsung: exynos7: Add clocks for MSCL block
Date: Mon, 22 Dec 2014 17:16:03 +0530 [thread overview]
Message-ID: <000901d01ddc$eac0d120$c0427360$@samsung.com> (raw)
In-Reply-To: <549450A6.9020205@samsung.com>
Hi Sylwester,
On Friday, December 19, 2014 9:52 PM Sylwester Nawrocki wrote,
> Hi,
>
> On 17/12/14 08:33, Tony K Nadackal wrote:
> > Add clock support for the MSCL block for Exynos7.
> >
> > Signed-off-by: Tony K Nadackal <tony.kn@samsung.com>
> > ---
> > .../devicetree/bindings/clock/exynos7-clock.txt | 1 +
> > drivers/clk/samsung/clk-exynos7.c | 124
+++++++++++++++++++++
> > include/dt-bindings/clock/exynos7-clk.h | 40 ++++++-
> > 3 files changed, 164 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/exynos7-clock.txt
> > b/Documentation/devicetree/bindings/clock/exynos7-clock.txt
> > index 6d3d5f8..d0e048c 100644
> > --- a/Documentation/devicetree/bindings/clock/exynos7-clock.txt
> > +++ b/Documentation/devicetree/bindings/clock/exynos7-clock.txt
> > @@ -34,6 +34,7 @@ Required Properties for Clock Controller:
> > - "samsung,exynos7-clock-peris"
> > - "samsung,exynos7-clock-fsys0"
> > - "samsung,exynos7-clock-fsys1"
> > + - "samsung,exynos7-clock-mscl"
>
> I can't see anything controversial in the patch, but I've got some doubts
regarding
> the compatible string. Is there a SoC named just "Exynos7"?
Yes, We have an SoC named Exynos7.
Please refer http://www.spinics.net/lists/linux-samsung-soc/msg36765.html
> If not, what are exact SoC names the "samsung,exynos7-clock-mscl" compatible
> is supposed to cover ?
> It would be good to list in this file the exact SoCs names this binding
applies to,
> unless there is indeed Exynos7 SoC.
>
> --
> Thanks,
> Sylwester
Regards,
Tony
next prev parent reply other threads:[~2014-12-22 11:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 7:33 [PATCH] clk: samsung: exynos7: Add clocks for MSCL block Tony K Nadackal
2014-12-19 16:21 ` Sylwester Nawrocki
2014-12-22 11:46 ` Tony K Nadackal [this message]
2014-12-22 14:57 ` Sylwester Nawrocki
2014-12-23 8:13 ` Tony K Nadackal
2014-12-23 4:59 ` Pankaj Dubey
2014-12-23 11:55 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000901d01ddc$eac0d120$c0427360$@samsung.com' \
--to=tony.kn@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).