linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: wufan@codeaurora.org (wufan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] EDAC, ghes: use CPER module handles to locate DIMMs
Date: Thu, 30 Aug 2018 08:20:32 -0600	[thread overview]
Message-ID: <000901d4406c$9d04f360$d70eda20$@codeaurora.org> (raw)
In-Reply-To: <20180830104307.GC20005@nazgul.tnic>

Hi Boris, 
 
> If we're going to do this, it needs to be tested on an x86 box which loads
> ghes_edac. Adding Toshi to Cc.
> 
> Otherwise it must remain ARM-specific.

Toshi it would be great if you can help! I'll also test the change in x86 but
not sure if the firmware updates module_handle.

> > +static int ghes_edac_dimm_index(u16 handle)
> 
> get_dimm_smbios_handle()

This function returns an index. So how about get_dimm_smbios_index()?

> > +{
> > +	struct mem_ctl_info *mci;
> > +	int i;
> > +
> > +	if (!ghes_pvt)
> > +		return -1;
> 
> You don't need that test.

Will remove.
 
> > +
> > +	mci = ghes_pvt->mci;
> > +
> > +	if (!mci)
> > +		return -1;
> 
> Ditto.

Will remove

Thanks,
Fan

  reply	other threads:[~2018-08-30 14:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 18:33 [PATCH] EDAC, ghes: use CPER module handles to locate DIMMs Fan Wu
2018-08-30 10:43 ` Borislav Petkov
2018-08-30 14:20   ` wufan [this message]
2018-08-30 15:12     ` Boris Petkov
2018-08-30 16:34   ` James Morse
2018-08-30 10:48 ` James Morse
2018-08-30 14:40   ` wufan
2018-08-30 16:32     ` James Morse
2018-08-30 16:45       ` wufan
2018-08-30 16:46       ` Tyler Baicar
2018-08-30 17:11         ` wufan
2018-08-30 16:34 ` James Morse
2018-08-30 16:50   ` John Garry
2018-08-31 10:06     ` tanxiaofei
2018-09-03 15:05       ` wufan
2018-09-03 19:18         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000901d4406c$9d04f360$d70eda20$@codeaurora.org' \
    --to=wufan@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).