From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A2CFC3DA7D for ; Tue, 3 Jan 2023 13:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject: In-Reply-To:References:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y3euUJzuJAJ/MNwDsqJPjj+MnmB0V4cV75wCwj+2LQU=; b=LejyRi96YNMxKH w/foZE4TZ4y3pprXhfDhwlSNd0VHTlXVA8RK93zmEdcCRcIBePqWosxN/f3fviPyvlLgbYogL9Rwd i9zDnsBR2hgM7GhfDt/79wEfHPUBiKuh0a7qn1gWb51E5eyavcMp7m/iGkHIV+uEhZs49peTW0PKx S5H12Hj+T7PdmKVmLZmM48+WA0ZECkZB3KDrRWxXxtvScC1DnV9MX45DPxKMik8xUH2zFEnaaIp4Z IrWr77683hu71hoNGDLw0WPTYQy/fA8wjqKltT4tzm7yE4wAcznOR7qI+mARUAxPnGhS0RZfifZsK jmgoFX6htn+LsZQZuZUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCh7a-001RpQ-8l; Tue, 03 Jan 2023 13:14:27 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCcPl-0006TF-Am for linux-arm-kernel@lists.infradead.org; Tue, 03 Jan 2023 08:12:57 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30379K9x010968; Tue, 3 Jan 2023 09:12:33 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : references : in-reply-to : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=selector1; bh=f45oBMJc844ZCXMDbesSeS3x9ZTo6pQSGJmchQpW4CE=; b=CntXIfyrB2Haka5FHYiT9KwrsvH98wf90+C87RvonfGhMc0tZ1iBuRqdAvEdeZAHZMXs lgpkifQsLrLXPkbwoSL+zpmJ/UQK0ZKT8OPYLX+IBeNHFfsip+wqyNMKT+EMK8nnqRWH 8DwWdn6rKKgPOpW38tNE7BbwKU6Zz4fIQfC11ExKxB6j6eHlbBoNih8BDek6CkcR/OfH JRAfxn7eP/n98Wec+uoU9zW9FBSc7XHEBhBAeQpqglvvyxXftE9VNjU9P5Qn4CEw+3B6 1AhOz+fEak/8hFUpYnYNvTSjU7wmCU8o8pcI0dgVfUVqQ97/BerPSyM9h0RkiiktfBwQ Gg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3mtb3e3q3x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Jan 2023 09:12:33 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 340FD10002A; Tue, 3 Jan 2023 09:12:31 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id E8DEF2132EC; Tue, 3 Jan 2023 09:12:31 +0100 (CET) Received: from LMECWL1288 (10.201.28.198) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.13; Tue, 3 Jan 2023 09:12:30 +0100 From: To: 'Linus Walleij' , 'Herbert Xu' , "'David S. Miller'" , 'Rob Herring' , 'Krzysztof Kozlowski' , 'Maxime Coquelin' , 'Alexandre Torgue' CC: , , , , References: <20221227-ux500-stm32-hash-v1-0-b637ac4cda01@linaro.org> <20221227-ux500-stm32-hash-v1-2-b637ac4cda01@linaro.org> In-Reply-To: <20221227-ux500-stm32-hash-v1-2-b637ac4cda01@linaro.org> Subject: RE: [PATCH 2/7] crypto: stm32/hash: Simplify code Date: Tue, 3 Jan 2023 09:12:24 +0100 Message-ID: <000901d91f4b$20c2dcf0$624896d0$@foss.st.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Content-Language: en-us Thread-Index: AQE9xJnjLNHmulQwHw6lCuUzVFT/vQHXDoT+r7RUDhA= msip_labels: MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Enabled=true; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_SetDate=2023-01-03T08:12:24Z; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Method=Standard; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_Name=23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_SiteId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_ActionId=4898ab01-b61a-4506-99cb-8cb4532979e5; MSIP_Label_23add6c0-cfdb-4bb9-b90f-bf23b83aa6c0_ContentBits=2 X-Originating-IP: [10.201.28.198] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-02_14,2022-12-30_01,2022-06-22_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_001255_053157_31AF3AE4 X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus Acked-by: Lionel Debieve ST Restricted -----Original Message----- From: Linus Walleij Sent: Wednesday, December 28, 2022 12:04 AM To: Herbert Xu ; David S. Miller ; Rob Herring ; Krzysztof Kozlowski ; Maxime Coquelin ; Alexandre Torgue ; Lionel Debieve Cc: linux-crypto@vger.kernel.org; devicetree@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Linus Walleij Subject: [PATCH 2/7] crypto: stm32/hash: Simplify code We are passing (rctx->flags & HASH_FLAGS_FINUP) as indicator for the final request but we already know this to be true since we are in the (final) arm of an if-statement set from the same flag. Just open-code it as true. Signed-off-by: Linus Walleij --- drivers/crypto/stm32/stm32-hash.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c index d33006d43f76..0473ced7b4ea 100644 --- a/drivers/crypto/stm32/stm32-hash.c +++ b/drivers/crypto/stm32/stm32-hash.c @@ -399,8 +399,7 @@ static int stm32_hash_update_cpu(struct stm32_hash_dev *hdev) if (final) { bufcnt = rctx->bufcnt; rctx->bufcnt = 0; - err = stm32_hash_xmit_cpu(hdev, rctx->buffer, bufcnt, - (rctx->flags & HASH_FLAGS_FINUP)); + err = stm32_hash_xmit_cpu(hdev, rctx->buffer, bufcnt, 1); } return err; -- 2.38.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel