* [PATCH] drm/exynos: exynos7_drm_decon: Consstify struct decon_data
@ 2025-03-18 8:07 ` Krzysztof Kozlowski
2025-03-18 10:49 ` Alim Akhtar
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-18 8:07 UTC (permalink / raw)
To: Inki Dae, Seung-Woo Kim, Kyungmin Park, David Airlie,
Simona Vetter, Krzysztof Kozlowski, Alim Akhtar, dri-devel,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Krzysztof Kozlowski
static 'struct decon_data' is only read, so it can be const for code
safety.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
index 5170f72b0830..f91daefa9d2b 100644
--- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
@@ -43,13 +43,13 @@ struct decon_data {
unsigned int wincon_burstlen_shift;
};
-static struct decon_data exynos7_decon_data = {
+static const struct decon_data exynos7_decon_data = {
.vidw_buf_start_base = 0x80,
.shadowcon_win_protect_shift = 10,
.wincon_burstlen_shift = 11,
};
-static struct decon_data exynos7870_decon_data = {
+static const struct decon_data exynos7870_decon_data = {
.vidw_buf_start_base = 0x880,
.shadowcon_win_protect_shift = 8,
.wincon_burstlen_shift = 10,
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] drm/exynos: exynos7_drm_decon: Consstify struct decon_data
2025-03-18 8:07 ` [PATCH] drm/exynos: exynos7_drm_decon: Consstify struct decon_data Krzysztof Kozlowski
@ 2025-03-18 10:49 ` Alim Akhtar
0 siblings, 0 replies; 2+ messages in thread
From: Alim Akhtar @ 2025-03-18 10:49 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Inki Dae',
'Seung-Woo Kim', 'Kyungmin Park',
'David Airlie', 'Simona Vetter',
'Krzysztof Kozlowski', dri-devel, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Hello Krzysztof
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Tuesday, March 18, 2025 1:38 PM
> To: Inki Dae <inki.dae@samsung.com>; Seung-Woo Kim
> <sw0312.kim@samsung.com>; Kyungmin Park
> <kyungmin.park@samsung.com>; David Airlie <airlied@gmail.com>; Simona
> Vetter <simona@ffwll.ch>; Krzysztof Kozlowski <krzk@kernel.org>; Alim
> Akhtar <alim.akhtar@samsung.com>; dri-devel@lists.freedesktop.org; linux-
> arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH] drm/exynos: exynos7_drm_decon: Consstify struct
> decon_data
>
> static 'struct decon_data' is only read, so it can be const for code
safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-18 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20250318080746epcas5p476317bb7bae69a8a85b5ad870bb3d0a5@epcas5p4.samsung.com>
2025-03-18 8:07 ` [PATCH] drm/exynos: exynos7_drm_decon: Consstify struct decon_data Krzysztof Kozlowski
2025-03-18 10:49 ` Alim Akhtar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).