From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 186D5D72343 for ; Fri, 23 Jan 2026 07:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:In-Reply-To:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F+3k78bx1aX7CBbym1BrLkgKSsh2Cn7diJb826znBUg=; b=eCirrjFdeVmD40AOC07IN6j/tk UvG1vJEeDiLy7FftNiQC2venHIMFGdq8lb7TSlUraENXoVxTGBECdvoK5OJrpQGUD1rMX3dcqNA69 ui0idvWZcjFyN0OFDt4C1slFqKh6Y7ZnGB2b3b2K442X+sCa5XOx1cUuwI7C2+PN2Cwg9HyrPVi+0 176Ejn1Pa8ScxeINHiXY1ZnGNZwtaIPHWdXGhgmLUoZBVDQznOIcU1BgPcjxdboTycIgKNh4m9Nwi Y5PKGkxS46gVeBomF+Rmtj6Pvx7INl4YczDDv9tcNAMe9wfaBShm8KUG0+92INM5LIMe9iEqeojwG qXVtitIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vjC4q-00000008PBF-2h5W; Fri, 23 Jan 2026 07:59:32 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vjC4l-00000008PAV-3M89 for linux-arm-kernel@lists.infradead.org; Fri, 23 Jan 2026 07:59:31 +0000 Received: from epcas5p4.samsung.com (unknown [182.195.41.42]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20260123075920epoutp0429452d30c3fcc809e1b5c0515c7aafeb~NTT7FkO6C2978829788epoutp04d for ; Fri, 23 Jan 2026 07:59:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20260123075920epoutp0429452d30c3fcc809e1b5c0515c7aafeb~NTT7FkO6C2978829788epoutp04d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1769155160; bh=F+3k78bx1aX7CBbym1BrLkgKSsh2Cn7diJb826znBUg=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=QfJDIxQFm9JlURO19h5MsBM1YjXfD2k+Tb4byGG7QcOLb/Fk1QupI1JK2VaaA2yiV h5O/6i1+BaI8bm+zakquLqF4LUDuwKf50s7BpTEkjKzvxY2/PMqy/ZfqwkBV+Ue2dD 1rlqYBoC6euYYXkdx7zlG0+JH4N+YaUZaNwMdxXg= Received: from epsnrtp02.localdomain (unknown [182.195.42.154]) by epcas5p1.samsung.com (KnoxPortal) with ESMTPS id 20260123075920epcas5p1a8e1797ca9ca254f0784b76c549cc8d1~NTT6rkSWT0288002880epcas5p1b; Fri, 23 Jan 2026 07:59:20 +0000 (GMT) Received: from epcas5p1.samsung.com (unknown [182.195.38.87]) by epsnrtp02.localdomain (Postfix) with ESMTP id 4dy9Lb0skfz2SSKj; Fri, 23 Jan 2026 07:59:19 +0000 (GMT) Received: from epsmtip2.samsung.com (unknown [182.195.34.31]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPA id 20260123075918epcas5p44ea70a01dc6d73b60ce3276e189f8aa0~NTT5LwGGK3122531225epcas5p42; Fri, 23 Jan 2026 07:59:18 +0000 (GMT) Received: from INBRO001840 (unknown [107.122.3.105]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260123075914epsmtip2caf2751058022b16f1134256e4821cb3~NTT1XNrGb2636326363epsmtip2k; Fri, 23 Jan 2026 07:59:13 +0000 (GMT) From: "Pritam Manohar Sutar" To: "'Krzysztof Kozlowski'" , , , , Cc: , , , , , , , , In-Reply-To: <6f381f88-3a51-4fc8-844c-41b167b07628@kernel.org> Subject: RE: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes Date: Fri, 23 Jan 2026 13:29:09 +0530 Message-ID: <000f01dc8c3e$2b6dcf30$82496d90$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEa27yOGkcSyej7W4JCG0x5iKXFKwH8TUbRAqvnhIQBf1ky2raxgCUA Content-Language: en-in X-CMS-MailID: 20260123075918epcas5p44ea70a01dc6d73b60ce3276e189f8aa0 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P cpgsPolicy: CPGSC10-542,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20260122125136epcas5p2db0fa3d04671ddc915e60ae8c5bcfb98 References: <20260122130721.205664-1-pritam.sutar@samsung.com> <20260122130721.205664-4-pritam.sutar@samsung.com> <6f381f88-3a51-4fc8-844c-41b167b07628@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260122_235928_508199_7282E027 X-CRM114-Status: GOOD ( 18.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thank you for your feedback.=20 > -----Original Message----- > From: Krzysztof Kozlowski > Sent: 22 January 2026 07:05 PM > To: Pritam Manohar Sutar ; robh=40kernel.org; > krzk+dt=40kernel.org; conor+dt=40kernel.org; alim.akhtar=40samsung.com > Cc: devicetree=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org;= linux- > samsung-soc=40vger.kernel.org; linux-kernel=40vger.kernel.org; > rosa.pila=40samsung.com; dev.tailor=40samsung.com; > faraz.ata=40samsung.com; muhammed.ali=40samsung.com; > selvarasu.g=40samsung.com > Subject: Re: =5BPATCH v2 3/3=5D arm64: dts: exynos: ExynosAutov920: Enabl= e USB > nodes >=20 > On 22/01/2026 14:07, Pritam Manohar Sutar wrote: > > Enable USB PHY and DWC3 USB controllers' nodes. > > > > Signed-off-by: Pritam Manohar Sutar > > --- > > .../boot/dts/exynos/exynosautov920-sadk.dts =7C 21 > +++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts > > b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts > > index f90f7704597c..5896dd69334a 100644 > > --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts > > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts > > =40=40 -160,15 +160,20 =40=40 &xtcxo =7B > > &usbdrd31_ssphy =7B > > dvdd-supply =3D <&dummy_regulator>; > > vdd18-supply =3D <&dummy_regulator>; > > + status =3D =22okay=22; >=20 > You just added the node in the previous patch, so why it cant be enavled > there? >=20 > > =7D; > > > > &usbdrd31_hsphy =7B > > dvdd-supply =3D <&dummy_regulator>; > > vdd18-supply =3D <&dummy_regulator>; > > vdd33-supply =3D <&dummy_regulator>; > > + status =3D =22okay=22; > > =7D; > > > > &usbdrd31_dwc3 =7B > > + dr_mode =3D =22otg=22; > > + usb-role-switch; > > + role-switch-default-mode =3D =22peripheral=22; >=20 > Why did you add incomplete node in previous commit? The commit was added to align with the existing convention of separating=20 node addition and enabling logic in USB configurations. This approach is=20 referenced from commits such as: https://lore.kernel.org/all/20250710-resends-july-exynos990-dt-v2-5-55033f7= 3d1b0=40mentallysanemainliners.org/ https://lore.kernel.org/all/20240429-usb-dts-gs101-v2-2-7c1797c9db80=40lina= ro.org/ Please let me know if this commit to be merged in previous commit. >=20 >=20 > Best regards, > Krzysztof Regards, Pritam