linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: Add Cortex A5 proc info
Date: Fri, 20 May 2011 10:14:15 +0100	[thread overview]
Message-ID: <001001cc16ce$4af0a260$e0d1e720$@deacon@arm.com> (raw)
In-Reply-To: <20110519160819.GD2431@arm.com>

> >
> > > On top of that, I think you should take optional, additional HWCAPs as
> > > arguments to the macro which get ORd with the base v7 HWCAPs.
> >
> > Em, the "optional" bit here is a problem. I can't just do
> >
> > #define INFO(_a, _extra_hwcaps...) \
> > 	.long HWCAP | _extra_hwcaps;
> >
> >
> > Because the output would be ".long HWCAP | ;" when no _extra_hwcaps are
> > given... Unless I'm missing some preprocessor trick? :-)
> 
> You could use an assembler macro instead.
> 
> .macro blarg insert_hwcaps=0
> 	/* blah */
> 	.long HWCAP_ALICE | HWCAP_BOB | HWCAP_CHARLIE | ( \insert_hwcaps )
> 	/* blah */
> .endm
> 
> As an added bonus, this could substantially reduce the diffstat, because
> assembler macro definitions can have multiple lines, so you don't need
> all that awful semicolon-backslash line continuation stuff.
> 
> Not everyone likes assembler macros, though...

I think that looks better and we are in an assembly file after all.
 
> >
> > > This might be useful for A15 where we have integer division.
> >
> > What HWCAP would this be? I've checked Catalin's repo and the only
> > difference I've spotted between A9 and A15 proc info were the mmu
> > flags...
> 
> You could invent one, if none is defined yet.  You probably want to
> check with Catalin or Will.

This is a separate patch and not one that we should rush out until we've
spoken to the tools guys. Having the extensibility from the start makes
sense though.

Will

  reply	other threads:[~2011-05-20  9:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-17 16:49 [PATCH] arm: Add Cortex A5 proc_info Pawel Moll
2011-05-18  9:47 ` Pawel Moll
2011-05-18 10:53   ` Dave Martin
2011-05-18 12:06     ` Pawel Moll
2011-05-18 16:44       ` [PATCH v2] arm: Add Cortex A5 proc info Pawel Moll
2011-05-19 14:10         ` Will Deacon
2011-05-19 15:31           ` Pawel Moll
2011-05-19 16:08             ` Dave Martin
2011-05-20  9:14               ` Will Deacon [this message]
2011-05-20 11:51               ` Pawel Moll
2011-05-20 13:39                 ` [PATCH v3 1/2] arm: Convert v7 proc infos into a common macro Pawel Moll
2011-05-20 13:39                   ` [PATCH v3 2/2] arm: Add Cortex A5 proc info Pawel Moll
2011-05-20 14:32                     ` Will Deacon
2011-05-20 14:31                   ` [PATCH v3 1/2] arm: Convert v7 proc infos into a common macro Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001001cc16ce$4af0a260$e0d1e720$@deacon@arm.com' \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).