From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440
Date: Tue, 18 Dec 2012 19:26:07 -0800 [thread overview]
Message-ID: <001501cddd98$9698dba0$c3ca92e0$@samsung.com> (raw)
In-Reply-To: <50C545E8.8050301@samsung.com>
Joonyoung Shim wrote:
>
> Hi,
>
> On 12/10/2012 10:07 AM, Kukjin Kim wrote:
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> > arch/arm/mach-exynos/common.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-
> exynos/common.c
> > index 0eb3b9a..9ecda37 100644
> > --- a/arch/arm/mach-exynos/common.c
> > +++ b/arch/arm/mach-exynos/common.c
> > @@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
> > * Theses parameters should be NULL and 0 because EXYNOS4
> > * uses GIC instead of VIC.
> > */
> > - s5p_init_irq(NULL, 0);
> > + if (!of_machine_is_compatible("samsung,exynos5440"))
> > + s5p_init_irq(NULL, 0);
>
> How about remove to call s5p_init_irq() here because All exynos SoCs use
> GIC instead of VIC?
>
NO, the current s5p_init_irq() is not only for VIC but also Timer which is
used on EXYNOS SoCs, I know the name is strange...
> > gic_arch_extn.irq_set_wake = s3c_irq_wake;
> > }
next prev parent reply other threads:[~2012-12-19 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 1:07 [PATCH] ARM: EXYNOS: fix GIC using for EXYNOS5440 Kukjin Kim
2012-12-10 2:16 ` Joonyoung Shim
2012-12-19 3:26 ` Kukjin Kim [this message]
2012-12-20 2:04 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001501cddd98$9698dba0$c3ca92e0$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).