linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: exynos: Fix warning due to missing 'inline' in stub
@ 2012-12-16  7:26 Olof Johansson
  2012-12-19  3:29 ` Kukjin Kim
  0 siblings, 1 reply; 2+ messages in thread
From: Olof Johansson @ 2012-12-16  7:26 UTC (permalink / raw)
  To: linux-arm-kernel

In file included from arch/arm/mach-exynos/clock-exynos5.c:29:0:
arch/arm/mach-exynos/common.h:28:12: warning: 'exynos_pm_late_initcall' defined but not used [-Wunused-function]

Signed-off-by: Olof Johansson <olof@lixom.net>
Cc: Kukjin Kim <kgene.kim@samsung.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
---

I've added this to the fixes branch on arm-soc. I've also noticed that
every single non-EXYNOS5 board/config fails to build. Kukjin?

 arch/arm/mach-exynos/common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
index dac146d..04744f9 100644
--- a/arch/arm/mach-exynos/common.h
+++ b/arch/arm/mach-exynos/common.h
@@ -25,7 +25,7 @@ void exynos_init_late(void);
 #ifdef CONFIG_PM_GENERIC_DOMAINS
 int exynos_pm_late_initcall(void);
 #else
-static int exynos_pm_late_initcall(void) { return 0; }
+static inline int exynos_pm_late_initcall(void) { return 0; }
 #endif
 
 #ifdef CONFIG_ARCH_EXYNOS4
-- 
1.7.10.1.488.g05fbf7a

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: exynos: Fix warning due to missing 'inline' in stub
  2012-12-16  7:26 [PATCH] ARM: exynos: Fix warning due to missing 'inline' in stub Olof Johansson
@ 2012-12-19  3:29 ` Kukjin Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2012-12-19  3:29 UTC (permalink / raw)
  To: linux-arm-kernel

Olof Johansson wrote:
> 
> In file included from arch/arm/mach-exynos/clock-exynos5.c:29:0:
> arch/arm/mach-exynos/common.h:28:12: warning: 'exynos_pm_late_initcall'
> defined but not used [-Wunused-function]
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> ---
> 
> I've added this to the fixes branch on arm-soc. I've also noticed that
> every single non-EXYNOS5 board/config fails to build. Kukjin?
> 

I'm OK on this. Thanks for your fix.

- Kukjin

>  arch/arm/mach-exynos/common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-
> exynos/common.h
> index dac146d..04744f9 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -25,7 +25,7 @@ void exynos_init_late(void);
>  #ifdef CONFIG_PM_GENERIC_DOMAINS
>  int exynos_pm_late_initcall(void);
>  #else
> -static int exynos_pm_late_initcall(void) { return 0; }
> +static inline int exynos_pm_late_initcall(void) { return 0; }
>  #endif
> 
>  #ifdef CONFIG_ARCH_EXYNOS4
> --
> 1.7.10.1.488.g05fbf7a

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-12-19  3:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-16  7:26 [PATCH] ARM: exynos: Fix warning due to missing 'inline' in stub Olof Johansson
2012-12-19  3:29 ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).