* [PATCH] usb: gadget: s3c2410_udc: fix error return code in s3c2410_udc_probe()
@ 2013-05-07 11:48 Wei Yongjun
2013-05-08 1:41 ` Jingoo Han
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-05-07 11:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code in the gpio_to_irq() error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/usb/gadget/s3c2410_udc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
index d0e75e1..c974776 100644
--- a/drivers/usb/gadget/s3c2410_udc.c
+++ b/drivers/usb/gadget/s3c2410_udc.c
@@ -1851,6 +1851,7 @@ static int s3c2410_udc_probe(struct platform_device *pdev)
irq = gpio_to_irq(udc_info->vbus_pin);
if (irq < 0) {
dev_err(dev, "no irq for gpio vbus pin\n");
+ retval = irq;
goto err_gpio_claim;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] usb: gadget: s3c2410_udc: fix error return code in s3c2410_udc_probe()
2013-05-07 11:48 [PATCH] usb: gadget: s3c2410_udc: fix error return code in s3c2410_udc_probe() Wei Yongjun
@ 2013-05-08 1:41 ` Jingoo Han
0 siblings, 0 replies; 2+ messages in thread
From: Jingoo Han @ 2013-05-08 1:41 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday, May 07, 2013 8:48 PM, Wei Yongjun wrote:
>
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code in the gpio_to_irq() error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/usb/gadget/s3c2410_udc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c
> index d0e75e1..c974776 100644
> --- a/drivers/usb/gadget/s3c2410_udc.c
> +++ b/drivers/usb/gadget/s3c2410_udc.c
> @@ -1851,6 +1851,7 @@ static int s3c2410_udc_probe(struct platform_device *pdev)
> irq = gpio_to_irq(udc_info->vbus_pin);
> if (irq < 0) {
> dev_err(dev, "no irq for gpio vbus pin\n");
> + retval = irq;
> goto err_gpio_claim;
> }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-08 1:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 11:48 [PATCH] usb: gadget: s3c2410_udc: fix error return code in s3c2410_udc_probe() Wei Yongjun
2013-05-08 1:41 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).