From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S5P: Add System Timer
Date: Thu, 08 Apr 2010 09:59:36 +0200 [thread overview]
Message-ID: <001b01cad6f1$71bdd890$553989b0$%szyprowski@samsung.com> (raw)
In-Reply-To: <1269916185-30533-1-git-send-email-kgene.kim@samsung.com>
Hello,
On Tuesday, March 30, 2010 4:30 AM Kukjin Kim wrote:
> From: Jongpill Lee <boyko.lee@samsung.com>
>
> This patch addes system timer for Samsung S5P series SoCs
>
> Signed-off-by: Jongpill Lee <boyko.lee@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
I've tested this patch on Samsung Aquila board and it works fine.
> ...
> diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c
> index a278832..22ed209 100644
> --- a/arch/arm/mach-s5pv210/mach-smdkv210.c
> +++ b/arch/arm/mach-s5pv210/mach-smdkv210.c
> @@ -94,5 +94,5 @@ MACHINE_START(SMDKV210, "SMDKV210")
> .init_irq = s5pv210_init_irq,
> .map_io = smdkv210_map_io,
> .init_machine = smdkv210_machine_init,
> - .timer = &s3c24xx_timer,
> + .timer = &s5p_systimer,
> MACHINE_END
What about mach-smdkc110.c ?
> diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig
> index d400a6a..a73fc56 100644
> --- a/arch/arm/plat-s5p/Kconfig
> +++ b/arch/arm/plat-s5p/Kconfig
> @@ -23,3 +23,10 @@ config PLAT_S5P
> select SAMSUNG_IRQ_UART
> help
> Base platform code for Samsung's S5P series SoC.
> +
> +config SYSTIMER_S5P
> + bool
> + depends on (ARCH_S5P6442 || ARCH_S5PV210)
> + default y
> + help
> + Support System Timer for S5P Series
IMHO 'S5P_SYSTIMER' would be a better name, but it is only a matter
of taste.
A new Kconfig option to conditionally disable plat-samsung/time.c timer
build would be nice to disable unused code on S5PV210.
> ...
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2010-04-08 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 2:29 [PATCH] ARM: S5P: Add System Timer Kukjin Kim
2010-04-08 7:59 ` Marek Szyprowski [this message]
2010-05-06 3:29 ` Kukjin Kim
2010-05-06 6:05 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001b01cad6f1$71bdd890$553989b0$%szyprowski@samsung.com' \
--to=m.szyprowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).