From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Tue, 22 Feb 2011 18:30:01 -0000 Subject: [PATCH 2/5] ARM: omap: update GPIO chained IRQ handler to use EOI in parent chip In-Reply-To: References: <1298302096-21275-1-git-send-email-will.deacon@arm.com> <1298302096-21275-3-git-send-email-will.deacon@arm.com> Message-ID: <001b01cbd2be$84ea7c10$8ebf7430$@deacon@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Santosh, > > > On OMAP4, gpio_irq_handler can be chained to a physical interrupt > > > using > > > the GIC as the primary IRQ chip. Now that the GIC uses the fasteoi > > > flow > > > model, the chained handler must invoke ->irq_eoi once handling is > > > complete. > > > > > > This patch adds a conditional call to ->irq_eoi in the GPIO IRQ > > > handler > > > for OMAP platforms. For OMAP implementations using other primary > > > interrupt controllers, the ->irq_ack call remains and is also made > > > conditional on the support offered by the controller. > > > > > > Cc: Santosh Shilimkar > > > Cc: Colin Cross > > > Signed-off-by: Will Deacon > > > --- > > Thanks Will for changes. They look fine. > > Acked-by: Santosh Shilimkar > > > > I will test your series tomorrow on OMAP with some > > GPIO interrupts. > > > Tested your series on OMAP4 SDP, where GPIO is used for > ethernet interrupts. They seems to work as expected. > For omap changes, > Tested-by: Santosh Shilimkar That's good news, thanks! One down, three to go... Will