linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: tegra: update GPIO chained IRQ handler to use EOI in parent chip
Date: Tue, 22 Feb 2011 19:21:09 -0000	[thread overview]
Message-ID: <001d01cbd2c5$a97f17a0$fc7d46e0$@deacon@arm.com> (raw)
In-Reply-To: <AANLkTimYvHOzv2w_oxOB5HJfMhp8Kg_A0-Y7Mj41M-HX@mail.gmail.com>

Hi Colin,

> On Mon, Feb 21, 2011 at 7:28 AM, Will Deacon <will.deacon@arm.com> wrote:
> > The chained GPIO IRQ handler on Tegra calls ->irq_ack on the parent
> > chip prior to handling the interrupt.
> >
> > This patch updates the code to use ->irq_eoi now that the GIC has moved
> > to using the fasteoi flow model.
> >
> > Cc: Colin Cross <ccross@google.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > ---
> >  arch/arm/mach-tegra/gpio.c |   17 +----------------
> >  1 files changed, 1 insertions(+), 16 deletions(-)

[...]

> Acked-by: Colin Cross <ccross@android.com>

Thanks Colin.

> Works with chained gpio handlers on Tegra, although the patch is
> filled with = escaping.

Hmm, I've seen this problem before. See Russell's explanation here:

http://lists.arm.linux.org.uk/lurker/message/20101201.172105.938cf2c5.en.html

I don't believe it's a problem my end, but if it starts happening
regularly I'll investigate further.

Cheers,

Will

  reply	other threads:[~2011-02-22 19:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-21 15:28 [PATCH 0/5] Migrate GIC to fasteoi flow control Will Deacon
2011-02-21 15:28 ` [PATCH 1/5] ARM: gic: use handle_fasteoi_irq for SPIs Will Deacon
2011-02-21 15:28 ` [PATCH 2/5] ARM: omap: update GPIO chained IRQ handler to use EOI in parent chip Will Deacon
2011-02-21 19:15   ` Santosh Shilimkar
2011-02-22 14:14     ` Santosh Shilimkar
2011-02-22 18:30       ` Will Deacon
2011-02-22 18:18   ` Tony Lindgren
2011-02-22 18:32     ` Will Deacon
2011-02-21 15:28 ` [PATCH 3/5] ARM: tegra: " Will Deacon
2011-02-22 19:09   ` Colin Cross
2011-02-22 19:21     ` Will Deacon [this message]
2011-02-22 19:52       ` Russell King - ARM Linux
2011-02-23 10:39         ` Will Deacon
2011-02-21 15:28 ` [PATCH 4/5] ARM: s5pv310: update IRQ combiner " Will Deacon
2011-02-23  6:59   ` Kyungmin Park
2011-02-23 15:58     ` Will Deacon
2011-02-21 15:28 ` [PATCH 5/5] ARM: msm: update GPIO chained IRQ handler " Will Deacon
2011-02-24  0:22   ` Abhijeet Dharmapurikar
2011-02-24 12:40     ` Thomas Gleixner
2011-02-24 14:12       ` Will Deacon
2011-02-24 15:42         ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001d01cbd2c5$a97f17a0$fc7d46e0$@deacon@arm.com' \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).