From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C64XX: Remove un-used code
Date: Fri, 19 Aug 2011 14:29:44 +0900 [thread overview]
Message-ID: <001d01cc5e31$00c9dee0$025d9ca0$%kim@samsung.com> (raw)
In-Reply-To: <20110819045346.GA26979@opensource.wolfsonmicro.com>
Mark Brown wrote:
>
> On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote:
> > On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown
> > <broonie@opensource.wolfsonmicro.com> wrote:
> > > On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote:
> > >> Remove un-used backlight code for SMDK6410 board
>
> > > Is the data actually wrong? ?If not it'd seem better to finish hooking
> > > it up properly than to remove it.
>
> > No, this code is no longer needed, as we are having a common backlight
> > infrastructure , which serves the same purpose.
>
> Ideally your commit log should make this clear - it looks like you're
> just deleting unreferenced code.
Yes, I agree with your opinion...It was difficult to know why it is un-used
code when I applied that.
OK, I will amend its commit log in my tree to clear.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2011-08-19 5:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 12:41 [PATCH] ARM: S3C64XX: Remove un-used code Banajit Goswami
2011-08-19 1:59 ` Mark Brown
2011-08-19 4:10 ` Banajit Goswami
2011-08-19 4:53 ` Mark Brown
2011-08-19 5:29 ` Kukjin Kim [this message]
2011-08-19 5:39 ` Banajit Goswami
2011-08-19 6:59 ` Banajit Goswami
2011-08-19 5:24 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001d01cc5e31$00c9dee0$025d9ca0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox