From mboxrd@z Thu Jan 1 00:00:00 1970 From: tgih.jun@samsung.com (Seungwon Jeon) Date: Thu, 04 Oct 2012 21:40:59 +0900 Subject: [PATCH 03/12] mmc: dw_mmc: fix building exynos driver as a module In-Reply-To: References: <1348868177-21205-1-git-send-email-arnd@arndb.de> <1348868177-21205-4-git-send-email-arnd@arndb.de> Message-ID: <001d01cda22d$81a3b4f0$84eb1ed0$%jun@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Monday, October 01, 2012, Will Newton wrote: > On Fri, Sep 28, 2012 at 10:36 PM, Arnd Bergmann wrote: > > The MODULE_DEVICE_TABLE() entry in the dw_mmc_exynos driver > > points to the wrong symbol which results in a link error > > when building as a loadable module. > > > > Further, we get a warning about the driver_data being > > marked constant, which requires annotating a few pointers > > as const. > > > > Signed-off-by: Arnd Bergmann > > Cc: Chris Ball > > Cc: Thomas Abraham > > Cc: Will Newton > > Cc: Jaehoon Chung > > Cc: Seungwon Jeon > > Cc: Kyungmin Park > > Cc: linux-mmc at vger.kernel.org > > --- > > drivers/mmc/host/dw_mmc-exynos.c | 4 ++-- > > drivers/mmc/host/dw_mmc-pltfm.c | 2 +- > > drivers/mmc/host/dw_mmc-pltfm.h | 2 +- > > drivers/mmc/host/dw_mmc.c | 2 +- > > include/linux/mmc/dw_mmc.h | 2 +- > > 5 files changed, 6 insertions(+), 6 deletions(-) > > This looks ok to me, but I'll let one of the Exynos guys ack those > specific changes as I don't have the hardware. > > There's already a patch for the dev_info warning in dw_mmc.c frm > Seungwon Jeon, and it seems to me like a separate change but I don't > really mind how it gets merged. Looks good to me. I don't mind it about including 'dev_info warning'. Acked-by: Seungwon Jeon > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html