linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/16] ARM: SMDKC100: enable i2c support again
Date: Wed, 12 May 2010 15:06:15 +0900	[thread overview]
Message-ID: <001e01caf199$3de2bb40$b9a831c0$%kim@samsung.com> (raw)
In-Reply-To: <1270190944-21644-12-git-send-email-m.szyprowski@samsung.com>

Marek Szyprowski wrote:
> 
> This patch enables support for i2c busses on SMDKC100 machine.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/mach-s5pc100/Kconfig         |    2 ++
>  arch/arm/mach-s5pc100/mach-smdkc100.c |    8 +++-----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pc100/Kconfig b/arch/arm/mach-s5pc100/Kconfig
> index 03a51e2..f2d5c23 100644
> --- a/arch/arm/mach-s5pc100/Kconfig
> +++ b/arch/arm/mach-s5pc100/Kconfig
> @@ -28,7 +28,9 @@ config MACH_SMDKC100
>  	bool "SMDKC100"
>  	select CPU_S5PC100
>  	select S5PC100_SETUP_FB_24BPP
> +	select S5PC100_SETUP_I2C1
>  	select S3C_DEV_FB
> +	select S3C_DEV_I2C1
>  	help
>  	  Machine support for the Samsung SMDKC100
> 
> diff --git a/arch/arm/mach-s5pc100/mach-smdkc100.c b/arch/arm/mach-
> s5pc100/mach-smdkc100.c
> index 44984be..93af963 100644
> --- a/arch/arm/mach-s5pc100/mach-smdkc100.c
> +++ b/arch/arm/mach-s5pc100/mach-smdkc100.c
> @@ -77,7 +77,6 @@ static struct s3c2410_uartcfg smdkc100_uartcfgs[]
__initdata
> = {
>  	},
>  };
> 
> -#if 0

Ok.

>  /* I2C0 */
>  static struct i2c_board_info i2c_devs0[] __initdata = {
>  };
> @@ -85,7 +84,7 @@ static struct i2c_board_info i2c_devs0[] __initdata = {
>  /* I2C1 */
>  static struct i2c_board_info i2c_devs1[] __initdata = {
>  };
> -#endif
> +
>  /* LCD power controller */
>  static void smdkc100_lcd_power_set(struct plat_lcd_data *pd,
>  				   unsigned int power)
> @@ -142,9 +141,9 @@ static struct s3c_fb_platdata smdkc100_lcd_pdata
> __initdata = {
>  static struct platform_device *smdkc100_devices[] __initdata = {
>  	&s3c_device_fb,
>  	&smdkc100_lcd_powerdev,
> -#if 0
>  	&s3c_device_i2c0,
>  	&s3c_device_i2c1,
> +#if 0

Aha ;-)

>  	&s3c_device_hsmmc0,
>  	&s3c_device_hsmmc1,
>  	&s3c_device_hsmmc2,
> @@ -160,13 +159,12 @@ static void __init smdkc100_map_io(void)
> 
>  static void __init smdkc100_machine_init(void)
>  {
> -#if 0
>  	/* I2C */
>  	s3c_i2c0_set_platdata(NULL);
>  	s3c_i2c1_set_platdata(NULL);
>  	i2c_register_board_info(0, i2c_devs0, ARRAY_SIZE(i2c_devs0));
>  	i2c_register_board_info(1, i2c_devs1, ARRAY_SIZE(i2c_devs1));
> -#endif
> +
>  	s3c_fb_set_platdata(&smdkc100_lcd_pdata);
> 
>  	/* LCD init */
> --
> 1.6.4
> 

Looks good except remaining if 0 :-)
I understand your intention.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2010-05-12  6:06 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-02  6:48 [PATCH] ARM: Samsung: S5PC100 platform cleanup Marek Szyprowski
2010-04-02  6:48 ` [PATCH 01/16] ARM: S5PC1xx rename registers to match plat-s5p style Marek Szyprowski
2010-05-12  4:55   ` Kukjin Kim
2010-05-12  5:33     ` Marek Szyprowski
2010-05-13  0:54   ` Ben Dooks
2010-04-02  6:48 ` [PATCH 02/16] drivers: serial: S5PC100 serial driver cleanup Marek Szyprowski
2010-04-06 15:59   ` Ben Dooks
2010-04-08  8:08     ` Marek Szyprowski
2010-04-02  6:48 ` [PATCH 03/16] ARM: Samsung: plat-s5p - enable access to clk_27m clock Marek Szyprowski
2010-05-12  4:55   ` Kukjin Kim
2010-05-12 16:14     ` Marek Szyprowski
2010-04-02  6:48 ` [PATCH 04/16] ARM: S5PC100: copy clocks from plat-s5pc1xx Marek Szyprowski
2010-05-12  4:55   ` Kukjin Kim
2010-05-12  5:22     ` Marek Szyprowski
2010-04-02  6:48 ` [PATCH 05/16] ARM: S5PC100: new clocks definition Marek Szyprowski
2010-05-12  4:56   ` Kukjin Kim
2010-05-12  6:43     ` Marek Szyprowski
2010-05-12  7:34       ` Kukjin Kim
2010-05-12  8:37         ` Marek Szyprowski
2010-05-12  8:48           ` Jassi Brar
2010-05-13  0:59           ` Ben Dooks
2010-05-12 17:48     ` Marek Szyprowski
2010-05-13  0:22       ` Kukjin Kim
2010-04-02  6:48 ` [PATCH 06/16] ARM: Samsung: move S5PC100 support from plat-s5pc1xx to plat-s5p framework Marek Szyprowski
2010-05-12  5:41   ` Kukjin Kim
2010-05-12  5:54     ` Marek Szyprowski
2010-05-12  6:31       ` jassi brar
2010-05-12  6:40         ` Marek Szyprowski
2010-05-12  6:57           ` jassi brar
2010-04-02  6:48 ` [PATCH 07/16] ARM: S5PC100: Move gpio support from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-12  5:50   ` Kukjin Kim
2010-05-12  6:02     ` Marek Szyprowski
2010-05-13  1:05   ` Ben Dooks
2010-04-02  6:48 ` [PATCH 08/16] ARM: S5PC100: Move frame buffer helpers " Marek Szyprowski
2010-05-12  5:52   ` Kukjin Kim
2010-05-12  6:08     ` Marek Szyprowski
2010-04-02  6:48 ` [PATCH 09/16] ARM: SMDKC100: enable frame buffer again Marek Szyprowski
2010-05-12  5:55   ` Kukjin Kim
2010-04-02  6:48 ` [PATCH 10/16] ARM: S5PC100: Move i2c helpers from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-12  6:05   ` Kukjin Kim
2010-04-02  6:48 ` [PATCH 11/16] ARM: SMDKC100: enable i2c support again Marek Szyprowski
2010-05-12  6:06   ` Kukjin Kim [this message]
2010-04-02  6:49 ` [PATCH 12/16] ARM: S5PC100: Move sdhci helpers from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-12  7:04   ` Kukjin Kim
2010-05-12  7:24     ` Marek Szyprowski
2010-04-02  6:49 ` [PATCH 13/16] ARM: SMDKC100: enable sdhci support again Marek Szyprowski
2010-05-12  7:05   ` Kukjin Kim
2010-04-02  6:49 ` [PATCH 14/16] ARM: Samsung: Move external interrupts support from plat-s5pc1xx to plat-s5p Marek Szyprowski
2010-04-02  6:49 ` [PATCH 15/16] ARM: S5PC100: Add support for gpio interrupt Marek Szyprowski
2010-04-02  6:49 ` [PATCH 16/16] ARM: remove obsolete plat-s5pc1xx directory Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001e01caf199$3de2bb40$b9a831c0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).