From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/2] ARM: perf_event: allow platform-specific interrupt handler
Date: Fri, 18 Feb 2011 11:34:18 -0000 [thread overview]
Message-ID: <001e01cbcf5f$c7ab5bd0$57021370$@deacon@arm.com> (raw)
In-Reply-To: <AANLkTi=ph8U3qGFgfhc15SNuYcj6oSUq8VPyJ+h_8b5O@mail.gmail.com>
> On Thu, Feb 17, 2011 at 22:03, Will Deacon <will.deacon@arm.com> wrote:
> >> I gave this a try, along with the modifications to enable IRQ_PER_CPU
> >> and have the pmu code use the appropriate flags and set the affinity.
> >> Didn't work though; it always ends up triggering the spurious IRQ check.
> >
> > Hmm, that doesn't sound right. Did you have any synchronisation to ensure
> > that the CPU without the overflow didn't return IRQ_NONE until the handling
> > CPU had returned IRQ_HANDLED?
>
> No. What kind of synchronization do you mean?
Well my guess is that the CPU returning IRQ_NONE is perpetually taking the
same interrupt until the other CPU has poked the PMU to stop it asserting
the line (otherwise I can't see how the spurious check would trip). You could
have a lock in the driver to synchronise between the two CPUs so that if you
don't have an overflow, you wait for the other CPU to clear the interrupt before
returning.
This has quickly started to become horrible but I was just curious as to whether
it provides better results than the affinity-setting approach (which is certainly
less invasive).
Cheers,
Will
prev parent reply other threads:[~2011-02-18 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 3:54 [PATCHv2 1/2] ARM: perf_event: allow platform-specific interrupt handler Rabin Vincent
2011-02-08 3:54 ` [PATCHv2 2/2] ux500: DB8500 PMU support Rabin Vincent
2011-02-11 16:33 ` [PATCHv2 1/2] ARM: perf_event: allow platform-specific interrupt handler Will Deacon
[not found] ` <-6723806473392693428@unknownmsgid>
2011-02-16 10:34 ` Rabin Vincent
2011-02-17 16:33 ` Will Deacon
[not found] ` <-3663809140750500272@unknownmsgid>
2011-02-17 16:50 ` Rabin Vincent
2011-02-18 11:34 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001e01cbcf5f$c7ab5bd0$57021370$@deacon@arm.com' \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).