From mboxrd@z Thu Jan 1 00:00:00 1970 From: suzuki.katsuhiro@socionext.com (Katsuhiro Suzuki) Date: Thu, 21 Jun 2018 12:09:01 +0900 Subject: [RESEND PATCH] media: helene: fix xtal frequency setting at power on In-Reply-To: <20180529010920.20320-1-suzuki.katsuhiro@socionext.com> References: <20180529010920.20320-1-suzuki.katsuhiro@socionext.com> Message-ID: <001f01d4090d$34a04310$9de0c930$@socionext.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Mauro, Ping... If I got some mistake, please comment it... Regards, -- Katsuhiro Suzuki > -----Original Message----- > From: Katsuhiro Suzuki > Sent: Tuesday, May 29, 2018 10:09 AM > To: Abylay Ospan ; Mauro Carvalho Chehab > ; linux-media at vger.kernel.org > Cc: Masami Hiramatsu ; Jassi Brar > ; linux-arm-kernel at lists.infradead.org; > linux-kernel at vger.kernel.org; Suzuki, Katsuhiro/?? ?? > > Subject: [RESEND PATCH] media: helene: fix xtal frequency setting at power on > > This patch fixes crystal frequency setting when power on this device. > > Signed-off-by: Katsuhiro Suzuki > Acked-by: Abylay Ospan > > --- > > Changes from before: > - Add Abylay's Ack > > --- > drivers/media/dvb-frontends/helene.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/helene.c > b/drivers/media/dvb-frontends/helene.c > index 0a4f312c4368..8fcf7a00782a 100644 > --- a/drivers/media/dvb-frontends/helene.c > +++ b/drivers/media/dvb-frontends/helene.c > @@ -924,7 +924,10 @@ static int helene_x_pon(struct helene_priv *priv) > helene_write_regs(priv, 0x99, cdata, sizeof(cdata)); > > /* 0x81 - 0x94 */ > - data[0] = 0x18; /* xtal 24 MHz */ > + if (priv->xtal == SONY_HELENE_XTAL_16000) > + data[0] = 0x10; /* xtal 16 MHz */ > + else > + data[0] = 0x18; /* xtal 24 MHz */ > data[1] = (uint8_t)(0x80 | (0x04 & 0x1F)); /* 4 x 25 = 100uA */ > data[2] = (uint8_t)(0x80 | (0x26 & 0x7F)); /* 38 x 0.25 = 9.5pF */ > data[3] = 0x80; /* REFOUT signal output 500mVpp */ > -- > 2.17.0