From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: gic: use handle_fasteoi_irq for SPIs
Date: Fri, 18 Feb 2011 12:09:49 -0000 [thread overview]
Message-ID: <002001cbcf64$bdc562a0$395027e0$@deacon@arm.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1102181240370.2701@localhost6.localdomain6>
> > I don't think the cascaded handlers would have assumed that because ack
> > just sends EOI - it doesn't do any masking. We do have a problem with
> > the percpu_irq flow though (the GIC reference manual says that EOIing a
> > non-active interrupt is UNPREDICTABLE).
> >
> > Another easy hack is to set IRQ_PER_CPU in the irq_desc->status for PPI
> > interrupts and then check this in the ack routine. It's pretty ugly, but
> > it doesn't affect the common case and it at least postpones the platform
> > changes.
>
> Conditionals in irq_chip callbacks are almost always a sign of
> doom. Don't do that.
Ok, that was a hack too far! Let's fix this properly.
> How many chained handlers need to be fixed, when the whole gic stuff
> switches to eoi ?
Well, grepping for set_chained_irq_handler yields a whole bunch of platforms
but the set of these which appear to use the gic is only:
mach-msm
mach-s5pv310
mach-shmobile
mach-tegra
I'll have a look through the code there and post some patches next week.
Hopefully if I've missed anybody, they'll shout then.
Cheers,
Will
next prev parent reply other threads:[~2011-02-18 12:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 15:26 [PATCH] ARM: gic: use handle_fasteoi_irq for SPIs Will Deacon
2011-02-16 11:29 ` Rabin Vincent
2011-02-16 13:09 ` Will Deacon
[not found] ` <-4413647205110644369@unknownmsgid>
2011-02-16 14:05 ` Rabin Vincent
2011-02-16 16:17 ` Will Deacon
[not found] ` <146267380211262372@unknownmsgid>
2011-02-16 17:35 ` Rabin Vincent
2011-02-16 19:20 ` Thomas Gleixner
2011-02-17 9:17 ` Russell King - ARM Linux
2011-02-17 9:38 ` Thomas Gleixner
2011-02-17 10:19 ` Russell King - ARM Linux
2011-02-17 10:43 ` Thomas Gleixner
2011-02-17 10:56 ` Russell King - ARM Linux
2011-02-17 11:21 ` Thomas Gleixner
2011-02-17 16:26 ` Will Deacon
2011-02-17 17:34 ` Thomas Gleixner
2011-02-17 23:38 ` Abhijeet Dharmapurikar
2011-02-18 11:29 ` Will Deacon
2011-02-18 11:42 ` Thomas Gleixner
2011-02-18 12:09 ` Will Deacon [this message]
[not found] ` <-8083923411736601789@unknownmsgid>
2011-02-18 18:30 ` Colin Cross
2011-02-18 18:36 ` Santosh Shilimkar
2011-02-18 18:57 ` Will Deacon
-- strict thread matches above, loose matches on Subject: below --
2011-02-10 12:29 Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002001cbcf64$bdc562a0$395027e0$@deacon@arm.com' \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).