linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jsgood.yang@samsung.com (Jinsung Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 12/12] [ARM][S3C6410] Add support gpio function for keypad device
Date: Mon, 07 Sep 2009 19:04:18 +0900	[thread overview]
Message-ID: <002101ca2fa2$9080fba0$b182f2e0$%yang@samsung.com> (raw)
In-Reply-To: <9c9fda240909061651y68dd8579r6cea25638ea120f1@mail.gmail.com>

Hi,

> > +
> > +       /* Set all the necessary GPK pins to special-function 0 */
> 
> special-function 3?

Sorry, my mistake

> 
> > +       for (gpio = S3C64XX_GPK(8); gpio < end; gpio++) {
> > +               s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(3));
> > +               s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
> > +       }
> > +
> > +       end = S3C64XX_GPL(0 + columns);
> > +
> > +       /* Set all the necessary GPK pins to special-function 0 */
> 
> ditto

Also mistake

      reply	other threads:[~2009-09-07 10:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-05 13:30 [PATCH 12/12] [ARM][S3C6410] Add support gpio function for keypad device 양진성
2009-09-05 14:13 ` Jinsung Yang
2009-09-05 14:49   ` Ben Dooks
2009-09-06 23:51 ` Kyungmin Park
2009-09-07 10:04   ` Jinsung Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002101ca2fa2$9080fba0$b182f2e0$%yang@samsung.com' \
    --to=jsgood.yang@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).