From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BFC6C3DA4A for ; Fri, 16 Aug 2024 06:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=erdeOGfMKnjJZthRQ74ZwqFW9cbRAdXya4HEE8czlZo=; b=WGL2eHiDWDuvz7V3tqdOjBh1c1 aCO8l702cgjhfHkSsLp+khi4pNnqnsbMbVec4cqRC4yypZcsp+JPJK6mg8HSA2TuxlzkBicCWoDgQ MmDg3hlfMYa8MU+ktsTfhUofMtSuycq5DGO427+PG1VJ/e+68vDI6+AiV3V0eYEvKDmDSHXDJl7Ir hNiTBPwuAkRogRyWFO6Hpzrvn1HpC+uMHANj1h+T/oXezjbMmxXlhPF72K3uS107L5nr74oonWEZo gm7HHEWplNaFSFNKzmZ9tJv8Pc7upH2YkmAevTcFvYK7yYvWhsJLoW35xD7Rmq2x6+XlGCt+Y4dta PfVAo2CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seqp1-0000000BzKx-0JGP; Fri, 16 Aug 2024 06:52:27 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seqoL-0000000BzCW-2lov; Fri, 16 Aug 2024 06:51:47 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1723791101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=erdeOGfMKnjJZthRQ74ZwqFW9cbRAdXya4HEE8czlZo=; b=DtUekxEajDyHcJ1DEsY/8VEsO+N6NYgruSKHNHe0ivJpXlj9DQu/LRb+Eg3kHDi0x6mIBo gS+Hsibva5U/JDu847lT27TVtlRnMf3tPXALDAvVk9XVa3rpxkalsV6HUL/2mKXzy/Acj0 fBUWYKfvvG1Fj3JeXQ1WVgXmp5uKvu/ApsuYIYdHC1qLx1bbE5yxTMQ9pps75Wxy1pWhmJ 2SxOAuk5zOVSCMtwajBHCL+wo26g84iFVAenQILZzc9ci2KZTYz0cWmlwfmuwXHkNbrv7K a6BQHUXj0mIZy7QY/5HRbx+MobPTlxrzJsjrGI2xGFXw4H0HmSfso3pHUyFk4Q== Date: Fri, 16 Aug 2024 08:51:40 +0200 From: Dragan Simic To: Sergey Bostandzhyan Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: improve eMMC speed on NanoPi R2S Plus In-Reply-To: <20240814170048.23816-4-jin@mediatomb.cc> References: <20240814170048.23816-1-jin@mediatomb.cc> <20240814170048.23816-4-jin@mediatomb.cc> Message-ID: <002107db3dcf3f1d1d1a767f049b5b79@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_235146_246748_743EE893 X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Sergey, On 2024-08-14 19:00, Sergey Bostandzhyan wrote: > This change has been suggested by Daniel Golle during patch review, > adding mmc-hs200-1_8v; makes sure that eMMC gets detected as HS200 > which improves it's performance. Describing who suggested the patch in the patch description looks out of place. Instead, you should add a Suggested-by tag, whose purpose is exactly to describe who suggested the patch. > Signed-off-by: Sergey Bostandzhyan > --- > arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > index 12eabdbf8fe8..146b1da198b8 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > @@ -23,6 +23,7 @@ > cap-mmc-highspeed; > supports-emmc; > disable-wp; > + mmc-hs200-1_8v; > non-removable; > num-slots = <1>; > pinctrl-names = "default";