linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: chanho.min@lge.com (Chanho Min)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64:kconfig: make default for CONFIG_COMPAT
Date: Tue, 15 Apr 2014 09:07:00 +0900	[thread overview]
Message-ID: <002201cf583e$9fb01f10$df105d30$@min@lge.com> (raw)
In-Reply-To: <20140414164618.GC12916@arm.com>

> -----Original Message-----
> From: Will Deacon [mailto:will.deacon at arm.com]
> Sent: Tuesday, April 15, 2014 1:46 AM
> To: Chanho Min
> Cc: Catalin Marinas; linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> Subject: Re: [PATCH] arm64:kconfig: make default for CONFIG_COMPAT
> 
> On Mon, Apr 14, 2014 at 09:08:03AM +0100, Chanho Min wrote:
> > 'make savedefconfig' doesn't generate defconfig properly due to
> > missing COMPAT default. So Add default and set to yes.
> 
> I thought a missing `default' line in a Kconfig entry meant that the option
> ended up defaulting to 'n'. What exactly is the problem you are seeing?

Correct minimal config is not generated without default line.
If we want to set COMPAT to 'n', 'default n' should be added.

Chanho
> 
> Will
> 
> > Signed-off-by: Chanho Min <chanho.min@lge.com>
> > ---
> >  arch/arm64/Kconfig |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > index 4907b85..93b7531 100644
> > --- a/arch/arm64/Kconfig
> > +++ b/arch/arm64/Kconfig
> > @@ -294,6 +294,7 @@ source "fs/Kconfig.binfmt"
> >
> >  config COMPAT
> >  	bool "Kernel support for 32-bit EL0"
> > +	default y
> >  	depends on !ARM64_64K_PAGES
> >  	select COMPAT_BINFMT_ELF
> >  	select HAVE_UID16
> > --
> > 1.7.9.5
> >
> >

  reply	other threads:[~2014-04-15  0:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14  8:08 [PATCH] arm64:kconfig: make default for CONFIG_COMPAT Chanho Min
2014-04-14 16:46 ` Will Deacon
2014-04-15  0:07   ` Chanho Min [this message]
2014-04-15  7:54   ` Arnd Bergmann
2014-04-15 10:41     ` Chanho Min

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002201cf583e$9fb01f10$df105d30$@min@lge.com' \
    --to=chanho.min@lge.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).