* [PATCH 01/12] [ARM][S3C6410] keypad memory map support
@ 2009-09-05 13:24 양진성
2009-09-07 0:08 ` Kyungmin Park
0 siblings, 1 reply; 5+ messages in thread
From: 양진성 @ 2009-09-05 13:24 UTC (permalink / raw)
To: linux-arm-kernel
This patch introduces keypad memory map for new keypad driver.
Also the new keypad driver will be provided to the mainline soon.
Signed-off-by: Jinsung Yang <jsgood.yang@samsung.com>
Signed-off-by: Kyeongil Kim <ki0351.kim@samsung.com>
---
arch/arm/mach-s3c6400/include/mach/map.h | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-s3c6400/include/mach/map.h
index 5057d99..d935570 100644
--- a/arch/arm/mach-s3c6400/include/mach/map.h
+++ b/arch/arm/mach-s3c6400/include/mach/map.h
@@ -65,6 +65,10 @@
#define S3C_VA_VIC0 (S3C_VA_IRQ + 0x00)
#define S3C_VA_VIC1 (S3C_VA_IRQ + 0x10000)
+/* keypad */
+#define S3C64XX_PA_KEYPAD (0x7E00A000)
+#define S3C64XX_SZ_KEYPAD SZ_4K
+
/* compatibiltiy defines. */
#define S3C_PA_TIMER S3C64XX_PA_TIMER
#define S3C_PA_HSMMC0 S3C64XX_PA_HSMMC0
@@ -75,5 +79,7 @@
#define S3C_PA_FB S3C64XX_PA_FB
#define S3C_PA_USBHOST S3C64XX_PA_USBHOST
#define S3C_PA_USB_HSOTG S3C64XX_PA_USB_HSOTG
+#define S3C_PA_KEYPAD S3C64XX_PA_KEYPAD
+#define S3C_SZ_KEYPAD S3C64XX_SZ_KEYPAD
#endif /* __ASM_ARCH_6400_MAP_H */
--
1.6.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 01/12] [ARM][S3C6410] keypad memory map support
2009-09-05 13:24 [PATCH 01/12] [ARM][S3C6410] keypad memory map support 양진성
@ 2009-09-07 0:08 ` Kyungmin Park
2009-09-07 1:49 ` Jinsung Yang
0 siblings, 1 reply; 5+ messages in thread
From: Kyungmin Park @ 2009-09-07 0:08 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
First, where's keypad driver source codes?
Second, why how many patches are needed? I think only two patch, one
for keypad related, another is smdkc100 board specific.
Thank you,
Kyungmin Park
2009/9/5 ??? <jsgood.yang@samsung.com>:
> This patch introduces keypad memory map for new keypad driver.
> Also the new keypad driver will be provided to the mainline soon.
>
> Signed-off-by: Jinsung Yang <jsgood.yang@samsung.com>
> Signed-off-by: Kyeongil Kim <ki0351.kim@samsung.com>
> ---
> ?arch/arm/mach-s3c6400/include/mach/map.h | ? ?6 ++++++
> ?1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-s3c6400/include/mach/map.h
> index 5057d99..d935570 100644
> --- a/arch/arm/mach-s3c6400/include/mach/map.h
> +++ b/arch/arm/mach-s3c6400/include/mach/map.h
> @@ -65,6 +65,10 @@
> ?#define S3C_VA_VIC0 ? ? ? ? ? ?(S3C_VA_IRQ + 0x00)
> ?#define S3C_VA_VIC1 ? ? ? ? ? ?(S3C_VA_IRQ + 0x10000)
>
> +/* keypad */
> +#define S3C64XX_PA_KEYPAD ? ? ?(0x7E00A000)
> +#define S3C64XX_SZ_KEYPAD ? ? ?SZ_4K
> +
> ?/* compatibiltiy defines. */
> ?#define S3C_PA_TIMER ? ? ? ? ? S3C64XX_PA_TIMER
> ?#define S3C_PA_HSMMC0 ? ? ? ? ?S3C64XX_PA_HSMMC0
> @@ -75,5 +79,7 @@
> ?#define S3C_PA_FB ? ? ? ? ? ? ?S3C64XX_PA_FB
> ?#define S3C_PA_USBHOST ? ? ? ? S3C64XX_PA_USBHOST
> ?#define S3C_PA_USB_HSOTG ? ? ? S3C64XX_PA_USB_HSOTG
> +#define S3C_PA_KEYPAD ? ? ? ? ?S3C64XX_PA_KEYPAD
> +#define S3C_SZ_KEYPAD ? ? ? ? ?S3C64XX_SZ_KEYPAD
>
> ?#endif /* __ASM_ARCH_6400_MAP_H */
> --
> 1.6.2.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 01/12] [ARM][S3C6410] keypad memory map support
2009-09-07 0:08 ` Kyungmin Park
@ 2009-09-07 1:49 ` Jinsung Yang
2009-09-07 3:15 ` Kyungmin Park
0 siblings, 1 reply; 5+ messages in thread
From: Jinsung Yang @ 2009-09-07 1:49 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: kyungmin78 at gmail.com [mailto:kyungmin78 at gmail.com] On Behalf Of
> Kyungmin Park
> Sent: Monday, September 07, 2009 9:09 AM
> To: ???
> Cc: ben-linux at fluff.org; ???/AP???/E3/????; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH 01/12] [ARM][S3C6410] keypad memory map support
>
> Hi,
>
> First, where's keypad driver source codes?
> Second, why how many patches are needed? I think only two patch, one
> for keypad related, another is smdkc100 board specific.
I sent keypad source code to the linux-input mailing lists and Ben Dooks as cc.
I have to send keypad driver also to arm-linux as public? I'm not sure..
And, the reason why I sent many patches is that we should split all changes as change-set based.
Even though these changes are related just with single topic (keypad), the details should be published as individual change-set.
Harald who is supporting our team's mainline work has recommended that.
>
> Thank you,
> Kyungmin Park
>
>
> 2009/9/5 ??? <jsgood.yang@samsung.com>:
> > This patch introduces keypad memory map for new keypad driver.
> > Also the new keypad driver will be provided to the mainline soon.
> >
> > Signed-off-by: Jinsung Yang <jsgood.yang@samsung.com>
> > Signed-off-by: Kyeongil Kim <ki0351.kim@samsung.com>
> > ---
> > arch/arm/mach-s3c6400/include/mach/map.h | 6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-
> s3c6400/include/mach/map.h
> > index 5057d99..d935570 100644
> > --- a/arch/arm/mach-s3c6400/include/mach/map.h
> > +++ b/arch/arm/mach-s3c6400/include/mach/map.h
> > @@ -65,6 +65,10 @@
> > #define S3C_VA_VIC0 (S3C_VA_IRQ + 0x00)
> > #define S3C_VA_VIC1 (S3C_VA_IRQ + 0x10000)
> >
> > +/* keypad */
> > +#define S3C64XX_PA_KEYPAD (0x7E00A000)
> > +#define S3C64XX_SZ_KEYPAD SZ_4K
> > +
> > /* compatibiltiy defines. */
> > #define S3C_PA_TIMER S3C64XX_PA_TIMER
> > #define S3C_PA_HSMMC0 S3C64XX_PA_HSMMC0
> > @@ -75,5 +79,7 @@
> > #define S3C_PA_FB S3C64XX_PA_FB
> > #define S3C_PA_USBHOST S3C64XX_PA_USBHOST
> > #define S3C_PA_USB_HSOTG S3C64XX_PA_USB_HSOTG
> > +#define S3C_PA_KEYPAD S3C64XX_PA_KEYPAD
> > +#define S3C_SZ_KEYPAD S3C64XX_SZ_KEYPAD
> >
> > #endif /* __ASM_ARCH_6400_MAP_H */
> > --
> > 1.6.2.5
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 01/12] [ARM][S3C6410] keypad memory map support
2009-09-07 1:49 ` Jinsung Yang
@ 2009-09-07 3:15 ` Kyungmin Park
2009-09-07 11:20 ` Jinsung Yang
0 siblings, 1 reply; 5+ messages in thread
From: Kyungmin Park @ 2009-09-07 3:15 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Sep 7, 2009 at 10:49 AM, Jinsung Yang<jsgood.yang@samsung.com> wrote:
>> -----Original Message-----
>> From: kyungmin78 at gmail.com [mailto:kyungmin78 at gmail.com] On Behalf Of
>> Kyungmin Park
>> Sent: Monday, September 07, 2009 9:09 AM
>> To: ???
>> Cc: ben-linux at fluff.org; ???/AP???/E3/????; linux-arm-
>> kernel at lists.infradead.org
>> Subject: Re: [PATCH 01/12] [ARM][S3C6410] keypad memory map support
>>
>> Hi,
>>
>> First, where's keypad driver source codes?
>> Second, why how many patches are needed? I think only two patch, one
>> for keypad related, another is smdkc100 board specific.
>
> I sent keypad source code to the linux-input mailing lists and Ben Dooks as cc.
I see.
> I have to send keypad driver also to arm-linux as public? I'm not sure..
For who only subscribe the arm list. It's not problem to post two
mailing list with same topic.
If only input patches are merged and arm doesn't, then what happens?
> And, the reason why I sent many patches is that we should split all changes as change-set based.
> Even though these changes are related just with single topic (keypad), the details should be published as individual change-set.
I agree Mark Brown's opinion from input mailing list. Please consider
what's the concept of change-set vs change one.
Thank you,
Kyungmin Park
> Harald who is supporting our team's mainline work has recommended that.
>
>>
>> Thank you,
>> Kyungmin Park
>>
>>
>> 2009/9/5 ??? <jsgood.yang@samsung.com>:
>> > This patch introduces keypad memory map for new keypad driver.
>> > Also the new keypad driver will be provided to the mainline soon.
>> >
>> > Signed-off-by: Jinsung Yang <jsgood.yang@samsung.com>
>> > Signed-off-by: Kyeongil Kim <ki0351.kim@samsung.com>
>> > ---
>> > arch/arm/mach-s3c6400/include/mach/map.h | 6 ++++++
>> > 1 files changed, 6 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/arch/arm/mach-s3c6400/include/mach/map.h b/arch/arm/mach-
>> s3c6400/include/mach/map.h
>> > index 5057d99..d935570 100644
>> > --- a/arch/arm/mach-s3c6400/include/mach/map.h
>> > +++ b/arch/arm/mach-s3c6400/include/mach/map.h
>> > @@ -65,6 +65,10 @@
>> > #define S3C_VA_VIC0 (S3C_VA_IRQ + 0x00)
>> > #define S3C_VA_VIC1 (S3C_VA_IRQ + 0x10000)
>> >
>> > +/* keypad */
>> > +#define S3C64XX_PA_KEYPAD (0x7E00A000)
>> > +#define S3C64XX_SZ_KEYPAD SZ_4K
>> > +
>> > /* compatibiltiy defines. */
>> > #define S3C_PA_TIMER S3C64XX_PA_TIMER
>> > #define S3C_PA_HSMMC0 S3C64XX_PA_HSMMC0
>> > @@ -75,5 +79,7 @@
>> > #define S3C_PA_FB S3C64XX_PA_FB
>> > #define S3C_PA_USBHOST S3C64XX_PA_USBHOST
>> > #define S3C_PA_USB_HSOTG S3C64XX_PA_USB_HSOTG
>> > +#define S3C_PA_KEYPAD S3C64XX_PA_KEYPAD
>> > +#define S3C_SZ_KEYPAD S3C64XX_SZ_KEYPAD
>> >
>> > #endif /* __ASM_ARCH_6400_MAP_H */
>> > --
>> > 1.6.2.5
>> >
>> >
>> > _______________________________________________
>> > linux-arm-kernel mailing list
>> > linux-arm-kernel at lists.infradead.org
>> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>> >
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 01/12] [ARM][S3C6410] keypad memory map support
2009-09-07 3:15 ` Kyungmin Park
@ 2009-09-07 11:20 ` Jinsung Yang
0 siblings, 0 replies; 5+ messages in thread
From: Jinsung Yang @ 2009-09-07 11:20 UTC (permalink / raw)
To: linux-arm-kernel
> I agree Mark Brown's opinion from input mailing list. Please consider
> what's the concept of change-set vs change one.
>
I agree also with Mark's opinion.
I will submit again my driver as single patch file with any other fixes.
Best Regards
--
Jinsung, Yang <jsgood.yang@samsung.com>
AP Development Team
System LSI, Semiconductor Business
SAMSUNG Electronics Co., LTD
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-09-07 11:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-05 13:24 [PATCH 01/12] [ARM][S3C6410] keypad memory map support 양진성
2009-09-07 0:08 ` Kyungmin Park
2009-09-07 1:49 ` Jinsung Yang
2009-09-07 3:15 ` Kyungmin Park
2009-09-07 11:20 ` Jinsung Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).