linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
@ 2025-06-26 20:13 Kaustabh Chakraborty
  2025-06-26 20:13 ` [PATCH v2 1/6] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs Kaustabh Chakraborty
                   ` (7 more replies)
  0 siblings, 8 replies; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-06-26 20:13 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
  Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Kaustabh Chakraborty

Exynos7870 has a IP subsystem in its architecture dedicated to display
management. Notably, this block includes the Display Enhancement
Controller (DECON), and the DSI Master (DSIM).

The following series and its sub-series implement all components for a
functioning display pipeline. All vital information which helped shaping
up the patches have been retrieved from Exynos7870 vendor kernel sources
as provided by Samsung.

Testing has been done on all three devices available upstream, i.e.
Samsung Galaxy J7 Prime (samsung-on7xelte), Samsung Galaxy A2 Core
(samsung-a2corelte), and Samsung Galaxy J6 (samsung-j6lte). Regrettably,
I've only been able to test the functionality on video mode, as none of
the devices have panels working in command mode.

This series implements changes in the SoC subsystem, which includes
devicetree additions. It depends on all sub-series listed below:
(Legend: [R]eviewed, [A]ccepted)

exynosdrm-decon            - https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
exynos7870-mipi-phy        A https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
exynos7870-mipi-phy-fix    - https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
exynos7870-dsim            - https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
panel-samsung-s6e8aa5x01   - https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
panel-synaptics-tddi       - https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
Changes in v2:
- modified compatible hierarchy to use non-deprecated syntax (krzk)
- fixed subject prefixes of [v1 2/5], [v1 3/5], [v1 4/5], [v1 5/5] (krzk)
- removed simplefb nodes instead of disabling it (krzk)
- added dt-bindings patch to allow mipi-phy node under PMU
- changed clock names of dsim node
- Link to v1: https://lore.kernel.org/r/20250612-exynos7870-drm-dts-v1-0-88c0779af6cb@disroot.org

---
Kaustabh Chakraborty (6):
      dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs
      dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode
      arm64: dts: exynos7870: add DSI support
      arm64: dts: exynos7870-on7xelte: enable display panel support
      arm64: dts: exynos7870-a2corelte: enable display panel support
      arm64: dts: exynos7870-j6lte: enable display panel support

 .../bindings/soc/samsung/exynos-pmu.yaml           |  1 +
 .../soc/samsung/samsung,exynos-sysreg.yaml         |  2 +
 .../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 52 +++++++++----
 arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts    | 49 ++++++++----
 arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 51 ++++++++----
 arch/arm64/boot/dts/exynos/exynos7870.dtsi         | 90 ++++++++++++++++++++++
 6 files changed, 206 insertions(+), 39 deletions(-)
---
base-commit: 1b152eeca84a02bdb648f16b82ef3394007a9dcf
change-id: 20250523-exynos7870-drm-dts-87ccab731ba9

Best regards,
-- 
Kaustabh Chakraborty <kauschluss@disroot.org>



^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH v2 1/6] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs
  2025-06-26 20:13 [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Kaustabh Chakraborty
@ 2025-06-26 20:13 ` Kaustabh Chakraborty
  2025-06-27 21:41   ` Rob Herring (Arm)
  2025-06-26 20:13 ` [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode Kaustabh Chakraborty
                   ` (6 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-06-26 20:13 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
  Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Kaustabh Chakraborty

Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are
added, used for the SoC MIPI PHY's CSIS and DSIM blocks.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml          | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..546b450dc3e10a642b289f4b152bcd299ae65b22 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -26,6 +26,8 @@ properties:
               - samsung,exynos3-sysreg
               - samsung,exynos4-sysreg
               - samsung,exynos5-sysreg
+              - samsung,exynos7870-cam0-sysreg
+              - samsung,exynos7870-disp-sysreg
               - samsung,exynos8895-fsys0-sysreg
               - samsung,exynos8895-fsys1-sysreg
               - samsung,exynos8895-peric0-sysreg

-- 
2.49.0



^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode
  2025-06-26 20:13 [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Kaustabh Chakraborty
  2025-06-26 20:13 ` [PATCH v2 1/6] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs Kaustabh Chakraborty
@ 2025-06-26 20:13 ` Kaustabh Chakraborty
  2025-06-27 21:42   ` Rob Herring
  2025-06-26 20:13 ` [PATCH v2 3/6] arm64: dts: exynos7870: add DSI support Kaustabh Chakraborty
                   ` (5 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-06-26 20:13 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
  Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Kaustabh Chakraborty

Add Exynos7870's PMU compatible to the list of nodes which allow a MIPI
PHY driver.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
index f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
@@ -172,6 +172,7 @@ allOf:
               - samsung,exynos5250-pmu
               - samsung,exynos5420-pmu
               - samsung,exynos5433-pmu
+              - samsung,exynos7870-pmu
     then:
       properties:
         mipi-phy: true

-- 
2.49.0



^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 3/6] arm64: dts: exynos7870: add DSI support
  2025-06-26 20:13 [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Kaustabh Chakraborty
  2025-06-26 20:13 ` [PATCH v2 1/6] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs Kaustabh Chakraborty
  2025-06-26 20:13 ` [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode Kaustabh Chakraborty
@ 2025-06-26 20:13 ` Kaustabh Chakraborty
  2025-08-13  7:56   ` Krzysztof Kozlowski
  2025-06-26 20:13 ` [PATCH v2 4/6] arm64: dts: exynos7870-on7xelte: enable display panel support Kaustabh Chakraborty
                   ` (4 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-06-26 20:13 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
  Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Kaustabh Chakraborty

Add devicetree nodes for MIPI PHYs, Samsung's DECON and DSIM blocks, and
DECON IOMMU devicetree nodes. Enables SoC support for hardware to be
able to drive a MIPI DSI display.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 arch/arm64/boot/dts/exynos/exynos7870.dtsi | 90 ++++++++++++++++++++++++++++++
 1 file changed, 90 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7870.dtsi b/arch/arm64/boot/dts/exynos/exynos7870.dtsi
index 5cba8c9bb403405b2d9721ab8cf9d61e3d5faf95..5f143216c758d9994bd508dc60fbe30f4cd9ee5f 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7870.dtsi
@@ -178,6 +178,14 @@ pmu_system_controller: system-controller@10480000 {
 				     "samsung,exynos7-pmu", "syscon";
 			reg = <0x10480000 0x10000>;
 
+			mipi_phy: mipi-phy {
+				compatible = "samsung,exynos7870-mipi-video-phy";
+				#phy-cells = <1>;
+
+				samsung,cam0-sysreg = <&syscon_cam0>;
+				samsung,disp-sysreg = <&syscon_disp>;
+			};
+
 			reboot-mode {
 				compatible = "syscon-reboot-mode";
 				offset = <0x080c>;
@@ -674,6 +682,83 @@ cmu_isp: clock-controller@144d0000 {
 				 <&cmu_mif CLK_GOUT_MIF_CMU_ISP_VRA>;
 		};
 
+		syscon_cam0: syscon@144f1040 {
+			compatible = "samsung,exynos7870-cam0-sysreg", "syscon";
+			reg = <0x144f1040 0x04>;
+		};
+
+		dsi: dsi@14800000 {
+			compatible = "samsung,exynos7870-mipi-dsi";
+			reg = <0x14800000 0x100>;
+			interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
+
+			clock-names = "bus", "pll", "byte", "esc";
+			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_BUS_DISP>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_APB_DISP>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_MIPIPHY_TXBYTECLKHS_USER>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_MIPIPHY_RXCLKESC0_USER>;
+
+			phy-names = "dsim";
+			phys = <&mipi_phy 1>;
+
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+
+					dsi_to_decon: endpoint {
+						remote-endpoint = <&decon_to_dsi>;
+					};
+				};
+			};
+		};
+
+		decon: decon@14830000 {
+			compatible = "samsung,exynos7870-decon";
+			reg = <0x14830000 0x8000>;
+			interrupt-names = "fifo", "vsync", "lcd_sys";
+			interrupts = <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>;
+
+			clock-names = "pclk_decon0", "aclk_decon0",
+				      "decon0_eclk", "decon0_vclk";
+			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_PLL>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_BUS_USER>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_DECON_ECLK>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_DECON_VCLK>;
+
+			iommus = <&sysmmu_decon>;
+
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					decon_to_dsi: endpoint {
+						remote-endpoint = <&dsi_to_decon>;
+					};
+				};
+			};
+		};
+
+		sysmmu_decon: sysmmu@14860000 {
+			compatible = "samsung,exynos-sysmmu";
+			reg = <0x14860000 0x1000>;
+			interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
+			#iommu-cells = <0>;
+
+			clock-names = "sysmmu";
+			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_BUS_USER>;
+		};
+
 		pinctrl_dispaud: pinctrl@148c0000 {
 			compatible = "samsung,exynos7870-pinctrl";
 			reg = <0x148c0000 0x1000>;
@@ -691,6 +776,11 @@ cmu_dispaud: clock-controller@148d0000 {
 				 <&cmu_mif CLK_GOUT_MIF_CMU_DISPAUD_DECON_ECLK>,
 				 <&cmu_mif CLK_GOUT_MIF_CMU_DISPAUD_DECON_VCLK>;
 		};
+
+		syscon_disp: syscon@148f100c {
+			compatible = "samsung,exynos7870-disp-sysreg", "syscon";
+			reg = <0x148f100c 0x04>;
+		};
 	};
 
 	timer {

-- 
2.49.0



^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 4/6] arm64: dts: exynos7870-on7xelte: enable display panel support
  2025-06-26 20:13 [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Kaustabh Chakraborty
                   ` (2 preceding siblings ...)
  2025-06-26 20:13 ` [PATCH v2 3/6] arm64: dts: exynos7870: add DSI support Kaustabh Chakraborty
@ 2025-06-26 20:13 ` Kaustabh Chakraborty
  2025-06-26 20:13 ` [PATCH v2 5/6] arm64: dts: exynos7870-a2corelte: " Kaustabh Chakraborty
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-06-26 20:13 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
  Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Kaustabh Chakraborty

Enable DECON and DSI nodes, and add the compatible display panel and
appropriate panel timings for this device. Also, remove the
simple-framebuffer node in favor of the panel.

This device has a 1080x1920 Synaptics TD4300 display panel.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 51 ++++++++++++++++------
 1 file changed, 38 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
index eb97dcc415423f405d7df9b9869b2db3432fb483..149c72676c3c337388b1e4b631e563362750d4ee 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
@@ -27,20 +27,7 @@ aliases {
 	};
 
 	chosen {
-		#address-cells = <2>;
-		#size-cells = <1>;
-		ranges;
-
 		stdout-path = &serial2;
-
-		framebuffer@67000000 {
-			compatible = "simple-framebuffer";
-			reg = <0x0 0x67000000 (1080 * 1920 * 4)>;
-			width = <1080>;
-			height = <1920>;
-			stride = <(1080 * 4)>;
-			format = "a8r8g8b8";
-		};
 	};
 
 	gpio-keys {
@@ -122,6 +109,44 @@ vibrator {
 	};
 };
 
+&decon {
+	status = "okay";
+};
+
+&dsi {
+	status = "okay";
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	samsung,burst-clock-frequency = <1001000000>;
+	samsung,esc-clock-frequency = <16000000>;
+	samsung,pll-clock-frequency = <26000000>;
+
+	panel@0 {
+		compatible = "syna,td4300-panel";
+		reg = <0>;
+
+		backlight-gpios = <&gpd3 5 GPIO_ACTIVE_LOW>;
+
+		width-mm = <68>;
+		height-mm = <121>;
+
+		panel-timing {
+			clock-frequency = <144389520>;
+
+			hactive = <1080>;
+			hsync-len = <4>;
+			hfront-porch = <120>;
+			hback-porch = <32>;
+
+			vactive = <1920>;
+			vsync-len = <2>;
+			vfront-porch = <21>;
+			vback-porch = <4>;
+		};
+	};
+};
+
 &gpu {
 	status = "okay";
 };

-- 
2.49.0



^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 5/6] arm64: dts: exynos7870-a2corelte: enable display panel support
  2025-06-26 20:13 [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Kaustabh Chakraborty
                   ` (3 preceding siblings ...)
  2025-06-26 20:13 ` [PATCH v2 4/6] arm64: dts: exynos7870-on7xelte: enable display panel support Kaustabh Chakraborty
@ 2025-06-26 20:13 ` Kaustabh Chakraborty
  2025-06-26 20:13 ` [PATCH v2 6/6] arm64: dts: exynos7870-j6lte: " Kaustabh Chakraborty
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-06-26 20:13 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
  Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Kaustabh Chakraborty

Enable DECON and DSI nodes, and add the compatible display panel and
appropriate panel timings for this device. Also, remove the
simple-framebuffer node in favor of the panel.

This device has a 540x960 Synaptics TD4101 display panel.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 .../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 52 ++++++++++++++++------
 1 file changed, 39 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts b/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts
index eb7b48593187409ce6653b7d857b63f6946aa4f7..577c34b798438b2ed70f01b4f954dfa074e97941 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts
@@ -27,20 +27,7 @@ aliases {
 	};
 
 	chosen {
-		#address-cells = <2>;
-		#size-cells = <1>;
-		ranges;
-
 		stdout-path = &serial2;
-
-		framebuffer@67000000 {
-			compatible = "simple-framebuffer";
-			reg = <0x0 0x67000000 (540 * 960 * 4)>;
-			width = <540>;
-			height = <960>;
-			stride = <(540 * 4)>;
-			format = "a8r8g8b8";
-		};
 	};
 
 	gpio-keys {
@@ -124,6 +111,45 @@ vibrator {
 	};
 };
 
+&decon {
+	status = "okay";
+};
+
+&dsi {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	samsung,burst-clock-frequency = <836000000>;
+	samsung,esc-clock-frequency = <16000000>;
+	samsung,pll-clock-frequency = <26000000>;
+
+	status = "okay";
+
+	panel@0 {
+		compatible = "syna,td4101-panel";
+		reg = <0>;
+
+		backlight-gpios = <&gpd3 7 GPIO_ACTIVE_LOW>;
+
+		width-mm = <62>;
+		height-mm = <110>;
+
+		panel-timing {
+			clock-frequency = <69336720>;
+
+			hactive = <540>;
+			hsync-len = <4>;
+			hfront-porch = <364>;
+			hback-porch = <40>;
+
+			vactive = <960>;
+			vsync-len = <2>;
+			vfront-porch = <244>;
+			vback-porch = <13>;
+		};
+	};
+};
+
 &gpu {
 	status = "okay";
 };

-- 
2.49.0



^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH v2 6/6] arm64: dts: exynos7870-j6lte: enable display panel support
  2025-06-26 20:13 [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Kaustabh Chakraborty
                   ` (4 preceding siblings ...)
  2025-06-26 20:13 ` [PATCH v2 5/6] arm64: dts: exynos7870-a2corelte: " Kaustabh Chakraborty
@ 2025-06-26 20:13 ` Kaustabh Chakraborty
  2025-06-27 14:06 ` [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Rob Herring (Arm)
  2025-08-13  7:58 ` Krzysztof Kozlowski
  7 siblings, 0 replies; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-06-26 20:13 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
  Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Kaustabh Chakraborty

Enable DECON and DSI nodes, and add the compatible display panel and
appropriate panel timings for this device. Also, remove the
simple-framebuffer node in favor of the panel.

This device has a 720x1480 AMOLED Samsung S6E8AA5X01 display panel.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts | 49 ++++++++++++++++++-------
 1 file changed, 36 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts b/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts
index 61eec1aff32ef397c69ee3f0cba8050755f74fc6..6d57f583d687003850f0b03bd19fa9e2f6e33332 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts
@@ -27,20 +27,7 @@ aliases {
 	};
 
 	chosen {
-		#address-cells = <2>;
-		#size-cells = <1>;
-		ranges;
-
 		stdout-path = &serial2;
-
-		framebuffer@67000000 {
-			compatible = "simple-framebuffer";
-			reg = <0x0 0x67000000 (720 * 1480 * 4)>;
-			width = <720>;
-			height = <1480>;
-			stride = <(720 * 4)>;
-			format = "a8r8g8b8";
-		};
 	};
 
 	gpio-hall-effect-sensor {
@@ -133,6 +120,42 @@ vibrator {
 	};
 };
 
+&decon {
+	status = "okay";
+};
+
+&dsi {
+	status = "okay";
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	samsung,burst-clock-frequency = <500000000>;
+	samsung,esc-clock-frequency = <16000000>;
+	samsung,pll-clock-frequency = <26000000>;
+
+	panel@0 {
+		compatible = "samsung,s6e8aa5x01";
+		reg = <0>;
+
+		width-mm = <62>;
+		height-mm = <128>;
+
+		panel-timing {
+			clock-frequency = <73094400>;
+
+			hactive = <720>;
+			hsync-len = <2>;
+			hfront-porch = <62>;
+			hback-porch = <26>;
+
+			vactive = <1480>;
+			vsync-len = <2>;
+			vfront-porch = <12>;
+			vback-porch = <10>;
+		};
+	};
+};
+
 &gpu {
 	status = "okay";
 };

-- 
2.49.0



^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
  2025-06-26 20:13 [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Kaustabh Chakraborty
                   ` (5 preceding siblings ...)
  2025-06-26 20:13 ` [PATCH v2 6/6] arm64: dts: exynos7870-j6lte: " Kaustabh Chakraborty
@ 2025-06-27 14:06 ` Rob Herring (Arm)
  2025-08-13  7:58 ` Krzysztof Kozlowski
  7 siblings, 0 replies; 19+ messages in thread
From: Rob Herring (Arm) @ 2025-06-27 14:06 UTC (permalink / raw)
  To: Kaustabh Chakraborty
  Cc: linux-kernel, devicetree, linux-samsung-soc, Conor Dooley,
	Krzysztof Kozlowski, linux-arm-kernel, Alim Akhtar,
	Krzysztof Kozlowski


On Fri, 27 Jun 2025 01:43:23 +0530, Kaustabh Chakraborty wrote:
> Exynos7870 has a IP subsystem in its architecture dedicated to display
> management. Notably, this block includes the Display Enhancement
> Controller (DECON), and the DSI Master (DSIM).
> 
> The following series and its sub-series implement all components for a
> functioning display pipeline. All vital information which helped shaping
> up the patches have been retrieved from Exynos7870 vendor kernel sources
> as provided by Samsung.
> 
> Testing has been done on all three devices available upstream, i.e.
> Samsung Galaxy J7 Prime (samsung-on7xelte), Samsung Galaxy A2 Core
> (samsung-a2corelte), and Samsung Galaxy J6 (samsung-j6lte). Regrettably,
> I've only been able to test the functionality on video mode, as none of
> the devices have panels working in command mode.
> 
> This series implements changes in the SoC subsystem, which includes
> devicetree additions. It depends on all sub-series listed below:
> (Legend: [R]eviewed, [A]ccepted)
> 
> exynosdrm-decon            - https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
> exynos7870-mipi-phy        A https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
> exynos7870-mipi-phy-fix    - https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
> exynos7870-dsim            - https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
> panel-samsung-s6e8aa5x01   - https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
> panel-synaptics-tddi       - https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
> Changes in v2:
> - modified compatible hierarchy to use non-deprecated syntax (krzk)
> - fixed subject prefixes of [v1 2/5], [v1 3/5], [v1 4/5], [v1 5/5] (krzk)
> - removed simplefb nodes instead of disabling it (krzk)
> - added dt-bindings patch to allow mipi-phy node under PMU
> - changed clock names of dsim node
> - Link to v1: https://lore.kernel.org/r/20250612-exynos7870-drm-dts-v1-0-88c0779af6cb@disroot.org
> 
> ---
> Kaustabh Chakraborty (6):
>       dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs
>       dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode
>       arm64: dts: exynos7870: add DSI support
>       arm64: dts: exynos7870-on7xelte: enable display panel support
>       arm64: dts: exynos7870-a2corelte: enable display panel support
>       arm64: dts: exynos7870-j6lte: enable display panel support
> 
>  .../bindings/soc/samsung/exynos-pmu.yaml           |  1 +
>  .../soc/samsung/samsung,exynos-sysreg.yaml         |  2 +
>  .../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 52 +++++++++----
>  arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts    | 49 ++++++++----
>  arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 51 ++++++++----
>  arch/arm64/boot/dts/exynos/exynos7870.dtsi         | 90 ++++++++++++++++++++++
>  6 files changed, 206 insertions(+), 39 deletions(-)
> ---
> base-commit: 1b152eeca84a02bdb648f16b82ef3394007a9dcf
> change-id: 20250523-exynos7870-drm-dts-87ccab731ba9
> 
> Best regards,
> --
> Kaustabh Chakraborty <kauschluss@disroot.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 1b152eeca84a02bdb648f16b82ef3394007a9dcf

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20250627-exynos7870-drm-dts-v2-0-d4a59207390d@disroot.org:

arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: /soc@0/dsi@14800000: failed to match any schema with compatible: ['samsung,exynos7870-mipi-dsi']
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: /soc@0/dsi@14800000/panel@0: failed to match any schema with compatible: ['syna,td4300-panel']
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: decon@14830000 (samsung,exynos7870-decon): 'iommus', 'ports' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/display/samsung/samsung,exynos7-decon.yaml#
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: /soc@0/dsi@14800000: failed to match any schema with compatible: ['samsung,exynos7870-mipi-dsi']
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: /soc@0/dsi@14800000/panel@0: failed to match any schema with compatible: ['syna,td4101-panel']
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: decon@14830000 (samsung,exynos7870-decon): 'iommus', 'ports' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/display/samsung/samsung,exynos7-decon.yaml#
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: /soc@0/dsi@14800000: failed to match any schema with compatible: ['samsung,exynos7870-mipi-dsi']
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: /soc@0/dsi@14800000/panel@0: failed to match any schema with compatible: ['samsung,s6e8aa5x01']
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: decon@14830000 (samsung,exynos7870-decon): 'iommus', 'ports' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/display/samsung/samsung,exynos7-decon.yaml#







^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 1/6] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs
  2025-06-26 20:13 ` [PATCH v2 1/6] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs Kaustabh Chakraborty
@ 2025-06-27 21:41   ` Rob Herring (Arm)
  0 siblings, 0 replies; 19+ messages in thread
From: Rob Herring (Arm) @ 2025-06-27 21:41 UTC (permalink / raw)
  To: Kaustabh Chakraborty
  Cc: linux-samsung-soc, Krzysztof Kozlowski, Conor Dooley,
	Krzysztof Kozlowski, linux-kernel, Alim Akhtar, linux-arm-kernel,
	devicetree


On Fri, 27 Jun 2025 01:43:24 +0530, Kaustabh Chakraborty wrote:
> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are
> added, used for the SoC MIPI PHY's CSIS and DSIM blocks.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml          | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>



^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode
  2025-06-26 20:13 ` [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode Kaustabh Chakraborty
@ 2025-06-27 21:42   ` Rob Herring
  2025-06-28  7:19     ` Kaustabh Chakraborty
  0 siblings, 1 reply; 19+ messages in thread
From: Rob Herring @ 2025-06-27 21:42 UTC (permalink / raw)
  To: Kaustabh Chakraborty
  Cc: Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
	Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

On Fri, Jun 27, 2025 at 01:43:25AM +0530, Kaustabh Chakraborty wrote:
> Add Exynos7870's PMU compatible to the list of nodes which allow a MIPI
> PHY driver.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> index f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
> @@ -172,6 +172,7 @@ allOf:
>                - samsung,exynos5250-pmu
>                - samsung,exynos5420-pmu
>                - samsung,exynos5433-pmu
> +              - samsung,exynos7870-pmu

Don't you need to add this to 'compatible' and under 'select'?

>      then:
>        properties:
>          mipi-phy: true
> 
> -- 
> 2.49.0
> 


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode
  2025-06-27 21:42   ` Rob Herring
@ 2025-06-28  7:19     ` Kaustabh Chakraborty
  2025-06-28  9:33       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-06-28  7:19 UTC (permalink / raw)
  To: Rob Herring
  Cc: Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
	Krzysztof Kozlowski, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

On 2025-06-27 21:42, Rob Herring wrote:
> On Fri, Jun 27, 2025 at 01:43:25AM +0530, Kaustabh Chakraborty wrote:
>> Add Exynos7870's PMU compatible to the list of nodes which allow a 
>> MIPI
>> PHY driver.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml 
>> b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>> index 
>> f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 
>> 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>> @@ -172,6 +172,7 @@ allOf:
>>                - samsung,exynos5250-pmu
>>                - samsung,exynos5420-pmu
>>                - samsung,exynos5433-pmu
>> +              - samsung,exynos7870-pmu
> 
> Don't you need to add this to 'compatible' and under 'select'?

compatible: [1]

samsung,exynos7-pmu is under select. 7870 has a fallback on 7.
Do you think samsung,exynos7-pmu should've been added in this patch
instead?

[1] 
https://elixir.bootlin.com/linux/v6.16-rc3/source/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml#L56

> 
>>      then:
>>        properties:
>>          mipi-phy: true
>> 
>> --
>> 2.49.0
>> 


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode
  2025-06-28  7:19     ` Kaustabh Chakraborty
@ 2025-06-28  9:33       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-28  9:33 UTC (permalink / raw)
  To: Kaustabh Chakraborty, Rob Herring
  Cc: Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, devicetree,
	linux-arm-kernel, linux-samsung-soc, linux-kernel

On 28/06/2025 09:19, Kaustabh Chakraborty wrote:
>>> diff --git 
>>> a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml 
>>> b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>>> index 
>>> f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 
>>> 100644
>>> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
>>> @@ -172,6 +172,7 @@ allOf:
>>>                - samsung,exynos5250-pmu
>>>                - samsung,exynos5420-pmu
>>>                - samsung,exynos5433-pmu
>>> +              - samsung,exynos7870-pmu
>>
>> Don't you need to add this to 'compatible' and under 'select'?
> 
> compatible: [1]
> 
> samsung,exynos7-pmu is under select. 7870 has a fallback on 7.
> Do you think samsung,exynos7-pmu should've been added in this patch
> instead?
> 
If this uses exynos7-pmu as fallback then it is fine. This should be in
commit msg - that's the point of commit msg - explain the hardware and
things not easily visible, instead of repeating what is visible in the diff.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 3/6] arm64: dts: exynos7870: add DSI support
  2025-06-26 20:13 ` [PATCH v2 3/6] arm64: dts: exynos7870: add DSI support Kaustabh Chakraborty
@ 2025-08-13  7:56   ` Krzysztof Kozlowski
  2025-08-17 14:40     ` Kaustabh Chakraborty
  0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-13  7:56 UTC (permalink / raw)
  To: Kaustabh Chakraborty, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Alim Akhtar
  Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>  			reboot-mode {
>  				compatible = "syscon-reboot-mode";
>  				offset = <0x080c>;
> @@ -674,6 +682,83 @@ cmu_isp: clock-controller@144d0000 {
>  				 <&cmu_mif CLK_GOUT_MIF_CMU_ISP_VRA>;
>  		};
>  
> +		syscon_cam0: syscon@144f1040 {
> +			compatible = "samsung,exynos7870-cam0-sysreg", "syscon";
> +			reg = <0x144f1040 0x04>;
> +		};
> +
> +		dsi: dsi@14800000 {
> +			compatible = "samsung,exynos7870-mipi-dsi";
> +			reg = <0x14800000 0x100>;
> +			interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			clock-names = "bus", "pll", "byte", "esc";
> +			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_BUS_DISP>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_APB_DISP>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_MIPIPHY_TXBYTECLKHS_USER>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_MIPIPHY_RXCLKESC0_USER>;

First clocks, then clock-names, please. Same for phys here and in all
other place.

> +
> +			phy-names = "dsim";
> +			phys = <&mipi_phy 1>;
> +
> +			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					dsi_to_decon: endpoint {
> +						remote-endpoint = <&decon_to_dsi>;
> +					};
> +				};
> +			};
> +		};
> +
> +		decon: decon@14830000 {

node name: display-controller@

> +			compatible = "samsung,exynos7870-decon";
> +			reg = <0x14830000 0x8000>;
> +			interrupt-names = "fifo", "vsync", "lcd_sys";
> +			interrupts = <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			clock-names = "pclk_decon0", "aclk_decon0",
> +				      "decon0_eclk", "decon0_vclk";
> +			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_PLL>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_BUS_USER>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_DECON_ECLK>,
> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_DECON_VCLK>;
> +
> +			iommus = <&sysmmu_decon>;
> +
> +			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					decon_to_dsi: endpoint {
> +						remote-endpoint = <&dsi_to_decon>;
> +					};
> +				};
> +			};
> +		};
> +
> +		sysmmu_decon: sysmmu@14860000 {

iommu@

> +			compatible = "samsung,exynos-sysmmu";
> +			reg = <0x14860000 0x1000>;
> +			interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
> +			#iommu-cells = <0>;
> +
> +			clock-names = "sysmmu";
> +			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_BUS_USER>;
> +		};



Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
  2025-06-26 20:13 [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Kaustabh Chakraborty
                   ` (6 preceding siblings ...)
  2025-06-27 14:06 ` [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Rob Herring (Arm)
@ 2025-08-13  7:58 ` Krzysztof Kozlowski
  2025-08-17 14:49   ` Kaustabh Chakraborty
  7 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-13  7:58 UTC (permalink / raw)
  To: Kaustabh Chakraborty, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Alim Akhtar
  Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
> This series implements changes in the SoC subsystem, which includes
> devicetree additions. It depends on all sub-series listed below:
> (Legend: [R]eviewed, [A]ccepted)
> 
> exynosdrm-decon            - https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
> exynos7870-mipi-phy        A https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
> exynos7870-mipi-phy-fix    - https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
> exynos7870-dsim            - https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
> panel-samsung-s6e8aa5x01   - https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
> panel-synaptics-tddi       - https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>

What is the status of the bindings from dependencies? I think they were
not accepted.

I also replied with few nits for one of DTS patches. Everything else
looks fine.

BTW, really great job you did here, I am impressed!

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 3/6] arm64: dts: exynos7870: add DSI support
  2025-08-13  7:56   ` Krzysztof Kozlowski
@ 2025-08-17 14:40     ` Kaustabh Chakraborty
  0 siblings, 0 replies; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-08-17 14:40 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On 2025-08-13 07:56, Krzysztof Kozlowski wrote:
> On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>>  			reboot-mode {
>>  				compatible = "syscon-reboot-mode";
>>  				offset = <0x080c>;
>> @@ -674,6 +682,83 @@ cmu_isp: clock-controller@144d0000 {
>>  				 <&cmu_mif CLK_GOUT_MIF_CMU_ISP_VRA>;
>>  		};
>> 
>> +		syscon_cam0: syscon@144f1040 {
>> +			compatible = "samsung,exynos7870-cam0-sysreg", "syscon";
>> +			reg = <0x144f1040 0x04>;
>> +		};
>> +
>> +		dsi: dsi@14800000 {
>> +			compatible = "samsung,exynos7870-mipi-dsi";
>> +			reg = <0x14800000 0x100>;
>> +			interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
>> +
>> +			clock-names = "bus", "pll", "byte", "esc";
>> +			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_BUS_DISP>,
>> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_APB_DISP>,
>> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_MIPIPHY_TXBYTECLKHS_USER>,
>> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_MIPIPHY_RXCLKESC0_USER>;
> 
> First clocks, then clock-names, please. Same for phys here and in all
> other place.

x-names followed by x approach is followed by the entire dts.
I will apply your suggestion in the next rev, and will also send a
separate patch for the same in all other places.

> 
>> +
>> +			phy-names = "dsim";
>> +			phys = <&mipi_phy 1>;
>> +
>> +			status = "disabled";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {
>> +					reg = <0>;
>> +
>> +					dsi_to_decon: endpoint {
>> +						remote-endpoint = <&decon_to_dsi>;
>> +					};
>> +				};
>> +			};
>> +		};
>> +
>> +		decon: decon@14830000 {
> 
> node name: display-controller@

This was preemptively changed, thanks.

> 
>> +			compatible = "samsung,exynos7870-decon";
>> +			reg = <0x14830000 0x8000>;
>> +			interrupt-names = "fifo", "vsync", "lcd_sys";
>> +			interrupts = <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>;
>> +
>> +			clock-names = "pclk_decon0", "aclk_decon0",
>> +				      "decon0_eclk", "decon0_vclk";
>> +			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_PLL>,
>> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_BUS_USER>,
>> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_DECON_ECLK>,
>> +				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_DECON_VCLK>;
>> +
>> +			iommus = <&sysmmu_decon>;
>> +
>> +			status = "disabled";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {
>> +					reg = <0>;
>> +					decon_to_dsi: endpoint {
>> +						remote-endpoint = <&dsi_to_decon>;
>> +					};
>> +				};
>> +			};
>> +		};
>> +
>> +		sysmmu_decon: sysmmu@14860000 {
> 
> iommu@

Also preemptively changed.

> 
>> +			compatible = "samsung,exynos-sysmmu";
>> +			reg = <0x14860000 0x1000>;
>> +			interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
>> +			#iommu-cells = <0>;
>> +
>> +			clock-names = "sysmmu";
>> +			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_BUS_USER>;
>> +		};
> 
> 
> 
> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
  2025-08-13  7:58 ` Krzysztof Kozlowski
@ 2025-08-17 14:49   ` Kaustabh Chakraborty
  2025-08-18  6:32     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-08-17 14:49 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On 2025-08-13 07:58, Krzysztof Kozlowski wrote:
> On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>> This series implements changes in the SoC subsystem, which includes
>> devicetree additions. It depends on all sub-series listed below:
>> (Legend: [R]eviewed, [A]ccepted)
>> 
>> exynosdrm-decon            - 
>> https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
>> exynos7870-mipi-phy        A 
>> https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
>> exynos7870-mipi-phy-fix    - 
>> https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
>> exynos7870-dsim            - 
>> https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
>> panel-samsung-s6e8aa5x01   - 
>> https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
>> panel-synaptics-tddi       - 
>> https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> 
> What is the status of the bindings from dependencies? I think they were
> not accepted.

Except panel-synaptics-tddi, all have been accepted. A lot of them
haven't hit next though. I'm waiting for that to send the next revision.
This rev is pretty old, so the links are old revs too.

There's also another related patch, on the IOMMU driver, which has also
been accepted. I will also add it to the list.

> 
> I also replied with few nits for one of DTS patches. Everything else
> looks fine.
> 
> BTW, really great job you did here, I am impressed!

Thank you! This was quite a ride to work on it and upstream these
patches. Thanks again to you and other kernel maintainers for all the
reviews.

> 
> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
  2025-08-17 14:49   ` Kaustabh Chakraborty
@ 2025-08-18  6:32     ` Krzysztof Kozlowski
  2025-08-18 17:08       ` Kaustabh Chakraborty
  0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-18  6:32 UTC (permalink / raw)
  To: Kaustabh Chakraborty
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On 17/08/2025 16:49, Kaustabh Chakraborty wrote:
> On 2025-08-13 07:58, Krzysztof Kozlowski wrote:
>> On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>>> This series implements changes in the SoC subsystem, which includes
>>> devicetree additions. It depends on all sub-series listed below:
>>> (Legend: [R]eviewed, [A]ccepted)
>>>
>>> exynosdrm-decon            - 
>>> https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
>>> exynos7870-mipi-phy        A 
>>> https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
>>> exynos7870-mipi-phy-fix    - 
>>> https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
>>> exynos7870-dsim            - 
>>> https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
>>> panel-samsung-s6e8aa5x01   - 
>>> https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
>>> panel-synaptics-tddi       - 
>>> https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
>>>
>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>
>> What is the status of the bindings from dependencies? I think they were
>> not accepted.
> 
> Except panel-synaptics-tddi, all have been accepted. A lot of them
> haven't hit next though. I'm waiting for that to send the next revision.

What does it mean - accepted but not hit next? If it is accepted, it
must be visible in next. Which maintainer's tree are not in the next?


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
  2025-08-18  6:32     ` Krzysztof Kozlowski
@ 2025-08-18 17:08       ` Kaustabh Chakraborty
  2025-08-24 10:25         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 19+ messages in thread
From: Kaustabh Chakraborty @ 2025-08-18 17:08 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On 2025-08-18 06:32, Krzysztof Kozlowski wrote:
> On 17/08/2025 16:49, Kaustabh Chakraborty wrote:
>> On 2025-08-13 07:58, Krzysztof Kozlowski wrote:
>>> On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>>>> This series implements changes in the SoC subsystem, which includes
>>>> devicetree additions. It depends on all sub-series listed below:
>>>> (Legend: [R]eviewed, [A]ccepted)
>>>> 
>>>> exynosdrm-decon            -
>>>> https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
>>>> exynos7870-mipi-phy        A
>>>> https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
>>>> exynos7870-mipi-phy-fix    -
>>>> https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
>>>> exynos7870-dsim            -
>>>> https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
>>>> panel-samsung-s6e8aa5x01   -
>>>> https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
>>>> panel-synaptics-tddi       -
>>>> https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
>>>> 
>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>> 
>>> What is the status of the bindings from dependencies? I think they 
>>> were
>>> not accepted.
>> 
>> Except panel-synaptics-tddi, all have been accepted. A lot of them
>> haven't hit next though. I'm waiting for that to send the next 
>> revision.
> 
> What does it mean - accepted but not hit next? If it is accepted, it
> must be visible in next. Which maintainer's tree are not in the next?

drm-exynos [1] branches haven't been rebased to v6.17-rc1. This should
include all some DECON and all DSIM patches.

Although [2] has been accepted, I don't see the commit in [3] anymore.
But, there's [4] which mentions my panel patches, but then I don't see
them in next (there should be a panel-samsung-s6e8aa5x01-ams561ra01.c
in [5]).

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/
[2] 
https://lore.kernel.org/all/175432157792.3671011.1104200917154441096.b4-ty@linaro.org
[3] 
https://gitlab.freedesktop.org/drm/misc/kernel/-/commits/drm-misc-next?ref_type=heads
[4] https://lore.kernel.org/all/20250814072454.GA18104@linux.fritz.box
[5] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/panel?h=next-20250818

> 
> 
> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)
  2025-08-18 17:08       ` Kaustabh Chakraborty
@ 2025-08-24 10:25         ` Krzysztof Kozlowski
  0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-24 10:25 UTC (permalink / raw)
  To: Kaustabh Chakraborty
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On 18/08/2025 19:08, Kaustabh Chakraborty wrote:
> On 2025-08-18 06:32, Krzysztof Kozlowski wrote:
>> On 17/08/2025 16:49, Kaustabh Chakraborty wrote:
>>> On 2025-08-13 07:58, Krzysztof Kozlowski wrote:
>>>> On 26/06/2025 22:13, Kaustabh Chakraborty wrote:
>>>>> This series implements changes in the SoC subsystem, which includes
>>>>> devicetree additions. It depends on all sub-series listed below:
>>>>> (Legend: [R]eviewed, [A]ccepted)
>>>>>
>>>>> exynosdrm-decon            -
>>>>> https://lore.kernel.org/r/20250627-exynosdrm-decon-v3-0-5b456f88cfea@disroot.org
>>>>> exynos7870-mipi-phy        A
>>>>> https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
>>>>> exynos7870-mipi-phy-fix    -
>>>>> https://lore.kernel.org/r/20250627-exynos7870-mipi-phy-fix-v1-0-2eefab8b50df@disroot.org
>>>>> exynos7870-dsim            -
>>>>> https://lore.kernel.org/r/20250627-exynos7870-dsim-v2-0-1433b67378d3@disroot.org
>>>>> panel-samsung-s6e8aa5x01   -
>>>>> https://lore.kernel.org/r/20250625-panel-samsung-s6e8aa5x01-v3-0-9a1494fe6c50@disroot.org
>>>>> panel-synaptics-tddi       -
>>>>> https://lore.kernel.org/r/20250625-panel-synaptics-tddi-v2-0-7a62ab1d13c7@disroot.org
>>>>>
>>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>>>
>>>> What is the status of the bindings from dependencies? I think they 
>>>> were
>>>> not accepted.
>>>
>>> Except panel-synaptics-tddi, all have been accepted. A lot of them
>>> haven't hit next though. I'm waiting for that to send the next 
>>> revision.
>>
>> What does it mean - accepted but not hit next? If it is accepted, it
>> must be visible in next. Which maintainer's tree are not in the next?
> 
> drm-exynos [1] branches haven't been rebased to v6.17-rc1. This should
> include all some DECON and all DSIM patches.
> 
> Although [2] has been accepted, I don't see the commit in [3] anymore.

I don't understand this. How can you find a commit via web interface?
You should be having linux-next and there you can go through the history
to check if commit is there or not.

> But, there's [4] which mentions my panel patches, but then I don't see
> them in next (there should be a panel-samsung-s6e8aa5x01-ams561ra01.c
> in [5]).

so that's the problem to solve.

I'll drop the patchset from my queue. I think you got here some other
comments as well, so I will be expecting v3 anyway.


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2025-08-24 10:28 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-26 20:13 [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Kaustabh Chakraborty
2025-06-26 20:13 ` [PATCH v2 1/6] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs Kaustabh Chakraborty
2025-06-27 21:41   ` Rob Herring (Arm)
2025-06-26 20:13 ` [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode Kaustabh Chakraborty
2025-06-27 21:42   ` Rob Herring
2025-06-28  7:19     ` Kaustabh Chakraborty
2025-06-28  9:33       ` Krzysztof Kozlowski
2025-06-26 20:13 ` [PATCH v2 3/6] arm64: dts: exynos7870: add DSI support Kaustabh Chakraborty
2025-08-13  7:56   ` Krzysztof Kozlowski
2025-08-17 14:40     ` Kaustabh Chakraborty
2025-06-26 20:13 ` [PATCH v2 4/6] arm64: dts: exynos7870-on7xelte: enable display panel support Kaustabh Chakraborty
2025-06-26 20:13 ` [PATCH v2 5/6] arm64: dts: exynos7870-a2corelte: " Kaustabh Chakraborty
2025-06-26 20:13 ` [PATCH v2 6/6] arm64: dts: exynos7870-j6lte: " Kaustabh Chakraborty
2025-06-27 14:06 ` [PATCH v2 0/6] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.) Rob Herring (Arm)
2025-08-13  7:58 ` Krzysztof Kozlowski
2025-08-17 14:49   ` Kaustabh Chakraborty
2025-08-18  6:32     ` Krzysztof Kozlowski
2025-08-18 17:08       ` Kaustabh Chakraborty
2025-08-24 10:25         ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).