linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dustinb@codeaurora.org (Dustin Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: arm: Export save_stack_trace_tsk()
Date: Mon, 11 Sep 2017 10:12:01 -0700	[thread overview]
Message-ID: <002801d32b21$15c42e90$414c8bb0$@codeaurora.org> (raw)
In-Reply-To: <20170909153020.GC20805@n2100.armlinux.org.uk>

Hi Russell,

I apologize for the trouble! I'm not sure how it happened (it looks fund
below after all), but I will try to be extra careful in the future.

Thanks,

-Dustin

-----Original Message-----
From: Russell King - ARM Linux [mailto:linux at armlinux.org.uk] 
Sent: Saturday, September 9, 2017 8:30 AM
To: Dustin Brown <dustinb@codeaurora.org>
Cc: linux-arm-kernel at lists.infradead.org
Subject: Re: arm: Export save_stack_trace_tsk()

On Mon, Aug 28, 2017 at 01:53:49PM -0700, Dustin Brown wrote:
> The kernel watchdog is a great debugging tool for finding tasks that 
> consume a disproportionate amount of CPU time in contiguous chunks. 
> One can imagine building a similar watchdog for arbitrary driver 
> threads using save_stack_trace_tsk() and print_stack_trace(). However, 
> this is not viable for dynamically loaded driver modules on ARM 
> platforms because save_stack_trace_tsk() is not exported for those
architectures.
> Export save_stack_trace_tsk() for the ARM architecture to align with 
> x86 and support various debugging use cases such as arbitrary driver 
> thread watchdog timers.

Hi Dustin,

I'm not sure why, but when I merged this, your commit log appears to be
entirely on two very long lines.  Linux requires that commit messages are
sensibly wrapped such that they can be read in git log on an 80 column
display - please take care in future to ensure that commit messages are
appropriately wrapped.

I'm having to reformat the commit manually.

There are cases where wrapping is not appropriate (eg, when quoting program
output or kernel messages.)

Thanks.

--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

      reply	other threads:[~2017-09-11 17:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 20:53 arm: Export save_stack_trace_tsk() Dustin Brown
2017-09-09 15:30 ` Russell King - ARM Linux
2017-09-11 17:12   ` Dustin Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002801d32b21$15c42e90$414c8bb0$@codeaurora.org' \
    --to=dustinb@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).