linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/16] ARM: Samsung: plat-s5p - enable access to clk_27m clock
Date: Wed, 12 May 2010 18:14:57 +0200	[thread overview]
Message-ID: <002901caf1ee$45f7f930$d1e7eb90$%szyprowski@samsung.com> (raw)
In-Reply-To: <001301caf18f$4fd6e060$ef84a120$%kim@samsung.com>

Hello,

On Wednesday, May 12, 2010 6:55 AM Kukjin Kim wrote:

> Marek Szyprowski wrote:
> >
> > Clock clk_27m can be a source for other clocks in S5PC100 clocks.
> > This patch removes static attribute of it.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >  arch/arm/plat-s5p/clock.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/plat-s5p/clock.c b/arch/arm/plat-s5p/clock.c
> > index aa96e33..519cdb4 100644
> > --- a/arch/arm/plat-s5p/clock.c
> > +++ b/arch/arm/plat-s5p/clock.c
> > @@ -33,7 +33,7 @@ struct clk clk_ext_xtal_mux = {
> >  	.id		= -1,
> >  };
> >
> > -static struct clk s5p_clk_27m = {
> > +struct clk clk_27m = {
> >  	.name		= "clk_27m",
> >  	.id		= -1,
> >  	.rate		= 27000000,
> > @@ -129,7 +129,7 @@ int s5p_gatectrl(void __iomem *reg, struct clk *clk,
> int
> > enable)
> >  static struct clk *s5p_clks[] __initdata = {
> >  	&clk_ext_xtal_mux,
> >  	&clk_48m,
> > -	&s5p_clk_27m,
> > +	&clk_27m,
> >  	&clk_fout_apll,
> >  	&clk_fout_mpll,
> >  	&clk_fout_epll,
> > --
> 
> Since clk_27m is now not static, it would be good to rename it as
> s5p_clk_27m.
> Do you have any reason for renaming?

Yes, I wanted to make it compatible with mach-s3c64xx. A clock of the same name
is defined in mach-s3c64xx/clock.c.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center

  reply	other threads:[~2010-05-12 16:14 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-02  6:48 [PATCH] ARM: Samsung: S5PC100 platform cleanup Marek Szyprowski
2010-04-02  6:48 ` [PATCH 01/16] ARM: S5PC1xx rename registers to match plat-s5p style Marek Szyprowski
2010-05-12  4:55   ` Kukjin Kim
2010-05-12  5:33     ` Marek Szyprowski
2010-05-13  0:54   ` Ben Dooks
2010-04-02  6:48 ` [PATCH 02/16] drivers: serial: S5PC100 serial driver cleanup Marek Szyprowski
2010-04-06 15:59   ` Ben Dooks
2010-04-08  8:08     ` Marek Szyprowski
2010-04-02  6:48 ` [PATCH 03/16] ARM: Samsung: plat-s5p - enable access to clk_27m clock Marek Szyprowski
2010-05-12  4:55   ` Kukjin Kim
2010-05-12 16:14     ` Marek Szyprowski [this message]
2010-04-02  6:48 ` [PATCH 04/16] ARM: S5PC100: copy clocks from plat-s5pc1xx Marek Szyprowski
2010-05-12  4:55   ` Kukjin Kim
2010-05-12  5:22     ` Marek Szyprowski
2010-04-02  6:48 ` [PATCH 05/16] ARM: S5PC100: new clocks definition Marek Szyprowski
2010-05-12  4:56   ` Kukjin Kim
2010-05-12  6:43     ` Marek Szyprowski
2010-05-12  7:34       ` Kukjin Kim
2010-05-12  8:37         ` Marek Szyprowski
2010-05-12  8:48           ` Jassi Brar
2010-05-13  0:59           ` Ben Dooks
2010-05-12 17:48     ` Marek Szyprowski
2010-05-13  0:22       ` Kukjin Kim
2010-04-02  6:48 ` [PATCH 06/16] ARM: Samsung: move S5PC100 support from plat-s5pc1xx to plat-s5p framework Marek Szyprowski
2010-05-12  5:41   ` Kukjin Kim
2010-05-12  5:54     ` Marek Szyprowski
2010-05-12  6:31       ` jassi brar
2010-05-12  6:40         ` Marek Szyprowski
2010-05-12  6:57           ` jassi brar
2010-04-02  6:48 ` [PATCH 07/16] ARM: S5PC100: Move gpio support from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-12  5:50   ` Kukjin Kim
2010-05-12  6:02     ` Marek Szyprowski
2010-05-13  1:05   ` Ben Dooks
2010-04-02  6:48 ` [PATCH 08/16] ARM: S5PC100: Move frame buffer helpers " Marek Szyprowski
2010-05-12  5:52   ` Kukjin Kim
2010-05-12  6:08     ` Marek Szyprowski
2010-04-02  6:48 ` [PATCH 09/16] ARM: SMDKC100: enable frame buffer again Marek Szyprowski
2010-05-12  5:55   ` Kukjin Kim
2010-04-02  6:48 ` [PATCH 10/16] ARM: S5PC100: Move i2c helpers from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-12  6:05   ` Kukjin Kim
2010-04-02  6:48 ` [PATCH 11/16] ARM: SMDKC100: enable i2c support again Marek Szyprowski
2010-05-12  6:06   ` Kukjin Kim
2010-04-02  6:49 ` [PATCH 12/16] ARM: S5PC100: Move sdhci helpers from plat-s5pc1xx to mach-s5pc100 Marek Szyprowski
2010-05-12  7:04   ` Kukjin Kim
2010-05-12  7:24     ` Marek Szyprowski
2010-04-02  6:49 ` [PATCH 13/16] ARM: SMDKC100: enable sdhci support again Marek Szyprowski
2010-05-12  7:05   ` Kukjin Kim
2010-04-02  6:49 ` [PATCH 14/16] ARM: Samsung: Move external interrupts support from plat-s5pc1xx to plat-s5p Marek Szyprowski
2010-04-02  6:49 ` [PATCH 15/16] ARM: S5PC100: Add support for gpio interrupt Marek Szyprowski
2010-04-02  6:49 ` [PATCH 16/16] ARM: remove obsolete plat-s5pc1xx directory Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002901caf1ee$45f7f930$d1e7eb90$%szyprowski@samsung.com' \
    --to=m.szyprowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).