linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: add Versatile Express defconfig
Date: Tue, 1 Feb 2011 09:52:13 -0000	[thread overview]
Message-ID: <002a01cbc1f5$b3ea0dc0$1bbe2940$@deacon@arm.com> (raw)
In-Reply-To: <AANLkTimzz5RAeuAWwss5krD_ogtN6u5ioQUS+e1ecyiB@mail.gmail.com>

Hey Linus,

> > This will probably cause a compile-time error with a mainline kernel
> > because the necessary hotplug functions aren't implemented for vexpress.
> 
> Does compile for me on 2.6.38-rc1 (after I avoid an compiler ICE
> on the NOR flash driver by deselecting it, I don't blame the kernel
> for that one tho):

Is the ICE similar to this? :

drivers/mtd/maps/integrator-flash.c: In function 'armflash_probe':
drivers/mtd/maps/integrator-flash.c:262: internal compiler error: in remove_insn, at emit-rtl.c:3803
Please submit a full bug report,
with preprocessed source if appropriate.

If so, I reported that to the compiler guys in ARM and I think it
got fixed in the 2010q3 codesourcery toolchain (not sure where it
is upstream).
 
> Might this have something to do with it:
> 
> git log arch/arm/mach-vexpress/hotplug.c
> commit e9882777d992b76e0b80deadd66ad886c25f5d1f
> Author: Russell King <rmk+kernel@arm.linux.org.uk>
> Date:   Sun Dec 19 11:33:12 2010 +0000
> 
>     ARM: CPU hotplug: add Versatile Express hotplug CPU support
> 
>     Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Great, I missed that! Feel free to hotplug away in your defconfig.
 
> I don't know if it boots tho, if you pack up a Vexpress and
> mail it to my place I promise I will make more than just
> compiletests ;-)

I'd swap one for one of your boards with the funky PMU, but I think
some people might not be too happy about that.

Will

      reply	other threads:[~2011-02-01  9:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 19:14 [PATCH] ARM: add Versatile Express defconfig Linus Walleij
2011-01-31 19:25 ` Will Deacon
2011-01-31 19:30 ` Russell King - ARM Linux
2011-01-31 20:31   ` Linus Walleij
     [not found] ` <3093351151219722808@unknownmsgid>
2011-01-31 20:27   ` Linus Walleij
2011-02-01  9:52     ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002a01cbc1f5$b3ea0dc0$1bbe2940$@deacon@arm.com' \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).