linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix isb regression on CPU < v7
Date: Wed, 6 Oct 2010 09:29:10 +0100	[thread overview]
Message-ID: <002e01cb6530$8cfb8300$a6f28900$@deacon@arm.com> (raw)
In-Reply-To: <1286308412-8252-1-git-send-email-linus.walleij@stericsson.com>

Hi Linus,

> The kernel does not compile for my ARM926EJ-S system U300 due to
> the isb instruction inserted in generic assember statement from
> commit 8925ec4c530094b878e7e28a1fd78e7122afd973, "ARM: 6385/1:
> setup: detect aliasing I-cache when D-cache is non-aliasing"
> hey the isb is only available when assembling for v7 so let's
> use the generic isb() macro from setup.h instead.
> 
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
> ---

Oops, well spotted! I suppose it's asking a bit much of the compiler
for it to optimise that case statement away when you're not building
for a v7 target :)

Acked-by: Will Deacon <will.deacon@arm.com>

Cheers,

Will

      reply	other threads:[~2010-10-06  8:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-05 19:53 [PATCH] ARM: fix isb regression on CPU < v7 Linus Walleij
2010-10-06  8:29 ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002e01cb6530$8cfb8300$a6f28900$@deacon@arm.com' \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).