From mboxrd@z Thu Jan  1 00:00:00 1970
From: m.szyprowski@samsung.com (Marek Szyprowski)
Date: Tue, 14 Sep 2010 07:46:05 +0200
Subject: [PATCH 5/6] ARM: S5PC110: add support for otg usb gadget on Goni
	board
In-Reply-To: <000b01cb50d5$37981140$a6c833c0$%kim@samsung.com>
References: <1284103403-10696-1-git-send-email-m.szyprowski@samsung.com>
	<1284103403-10696-6-git-send-email-m.szyprowski@samsung.com>
	<000b01cb50d5$37981140$a6c833c0$%kim@samsung.com>
Message-ID: <003101cb53d0$222898e0$6679caa0$%szyprowski@samsung.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hello,

On Friday, September 10, 2010 12:45 PM Kukjin Kim wrote:

> Marek Szyprowski wrote:
> >
> > Add required platform definitions for s3c-hsotg driver to enable usb
> > gadget support on Samsung Goni board.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >  arch/arm/mach-s5pv210/Kconfig     |    1 +
> >  arch/arm/mach-s5pv210/mach-goni.c |    5 +++++
> >  2 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-
> s5pv210/Kconfig
> > index b1f671d..f8bac5a 100644
> > --- a/arch/arm/mach-s5pv210/Kconfig
> > +++ b/arch/arm/mach-s5pv210/Kconfig
> > @@ -85,6 +85,7 @@ config MACH_GONI
> >  	select S3C_DEV_HSMMC2
> >  	select S3C_DEV_I2C1
> >  	select S5P_DEV_ONENAND
> > +	select S3C_DEV_USB_HSOTG
> >  	select SAMSUNG_DEV_KEYPAD
> >  	select S5PV210_SETUP_FB_24BPP
> >  	select S5PV210_SETUP_I2C1
> > diff --git a/arch/arm/mach-s5pv210/mach-goni.c
> b/arch/arm/mach-s5pv210/mach-
> > goni.c
> > index 30da422..b28a42b 100644
> > --- a/arch/arm/mach-s5pv210/mach-goni.c
> > +++ b/arch/arm/mach-s5pv210/mach-goni.c
> > @@ -41,6 +41,8 @@
> >  #include <plat/iic.h>
> >  #include <plat/keypad.h>
> >  #include <plat/sdhci.h>
> > +#include <plat/clock.h>
> > +#include <plat/s5p-clock.h>
> 
> Hmm...same 'extern struct clk_xusbxti' defined both.
> I will sort out :-)
> 
> I think, just one inclusion is enough now.

Ok. I will fix this. This patch is quite old and I remember that
some time ago both includes were required.

> If any problems, please let me know.
> 
> >
> >  /* Following are default values for UCON, ULCON and UFCON UART registers
> */
> >  #define GONI_UCON_DEFAULT	(S3C2410_UCON_TXILEVEL |	\
> > @@ -569,6 +571,7 @@ static struct platform_device *goni_devices[]
> __initdata = {
> >  	&s3c_device_fb,
> >  	&s5p_device_onenand,
> >  	&goni_spi_gpio,
> > +	&s3c_device_usb_hsotg,
> >  	&goni_i2c_gpio_pmic,
> >  	&goni_device_gpiokeys,
> >  	&s5p_device_fimc0,
> > @@ -613,6 +616,8 @@ static void __init goni_machine_init(void)
> >  	samsung_keypad_set_platdata(&keypad_data);
> >
> >  	platform_add_devices(goni_devices, ARRAY_SIZE(goni_devices));
> > +
> > +	clk_xusbxti.rate = 24000000;
> >  }
> >
> >  MACHINE_START(GONI, "GONI")
> > --
> 

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center