public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions.
Date: Wed, 29 Dec 2010 10:03:44 +0900	[thread overview]
Message-ID: <003301cba6f4$3f6b2a90$be417fb0$%kim@samsung.com> (raw)
In-Reply-To: <1293535562-24715-1-git-send-email-inki.dae@samsung.com>

Inki Dae wrote:
> 
One more comment.

Please work on S5P SoCs based on maintainer's latest for-next.
You can find the reason in below.

> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>  arch/arm/mach-s5pv210/include/mach/regs-clock.h |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
b/arch/arm/mach-
> s5pv210/include/mach/regs-clock.h
> index ebaabe0..09680d9 100644
> --- a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
> +++ b/arch/arm/mach-s5pv210/include/mach/regs-clock.h
> @@ -146,6 +146,7 @@
>  #define S5P_OM_STAT		S5P_CLKREG(0xE100)
>  #define S5P_USB_PHY_CONTROL	S5P_CLKREG(0xE80C)
>  #define S5P_DAC_CONTROL		S5P_CLKREG(0xE810)
> +#define S5P_MIPI_DPHY_CONTROL		S5P_CLKREG(0xE814)
> 
Already added by Sylwester's patch.

>  #define S5P_INFORM0		S5P_CLKREG(0xF000)
>  #define S5P_INFORM1		S5P_CLKREG(0xF004)
> @@ -196,7 +197,10 @@
>  #define S5P_OTHERS_USB_SIG_MASK		(1 << 16)
> 
>  /* MIPI */
> -#define S5P_MIPI_DPHY_EN		(3)

Oops, already removed because not used anywhere at that time.

> +#define S5P_MIPI_DPHY_EN		(3 << 0)
> +
> +/* S5P_MIPI_PHY_CON0 */
> +#define S5P_MIPI_M_RESETN		(1 << 1)
> 
>  /* S5P_DAC_CONTROL */
>  #define S5P_DAC_ENABLE			(1)
> --

Please re-work your all patches.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  parent reply	other threads:[~2010-12-29  1:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-28 11:26 [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions Inki Dae
2010-12-29  0:50 ` Kukjin Kim
2010-12-30  1:23   ` InKi Dae
2010-12-29  1:03 ` Kukjin Kim [this message]
2010-12-29  1:45   ` Kyungmin Park
2010-12-29  2:07     ` Kukjin Kim
2010-12-29  2:24       ` Kyungmin Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003301cba6f4$3f6b2a90$be417fb0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox